Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-12 Thread via GitHub
zhtk commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2872715728 I also thank you for reviews and for patience in getting these changes merged 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-10 Thread via GitHub
exceptionfactory merged PR #9874: URL: https://github.com/apache/nifi/pull/9874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-09 Thread via GitHub
exceptionfactory commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2866994578 > @exceptionfactory I approve these changes. Is there anything else you see which needs changing? Thanks, I will follow up soon. -- This is an automated message from the Ap

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-09 Thread via GitHub
dan-s1 commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2866883550 @exceptionfactory I approve these changes. Is there anything else you see which needs changing? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r207996 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelReader.java: ## @@ -85,6 +85,16 @@ public class ExcelReader extends Schem

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r207521 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softw

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
dan-s1 commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2863428038 > TBH I don't see conflicts, github interface says: "No conflicts with base branch. Changes can be cleanly merged.", and local merge also was performed cleanly. To make sure everything is ok,

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2079892177 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelReader.java: ## @@ -85,6 +85,16 @@ public class ExcelReader extends Sch

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
zhtk commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2863408159 TBH I don't see conflicts, github interface says: "No conflicts with base branch. Changes can be cleanly merged.", and local merge also was performed cleanly. To make sure everything is ok, I h

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2079798467 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
dan-s1 commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2863315611 @zhtk Can you please fix the conflicts you have locally and then push? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2079799098 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +44,26 @@ class RowIterator implements Iterator

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2079799538 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/test/java/org/apache/nifi/excel/TestExcelRecordReader.java: ## @@ -318,17 +328,47 @@ void testPasswordProtecte

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-08 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2079798107 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelReader.java: ## @@ -53,13 +53,13 @@ import java.util.List; import java.

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2078020755 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +44,26 @@ class RowIterator impleme

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077968211 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +44,26 @@ class RowIterator impleme

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077998688 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +44,26 @@ class RowIterator implements Iterat

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077959225 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Ap

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077914006 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +44,26 @@ class RowIterator implements Iterat

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077889061 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softw

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077889061 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softw

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077889061 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softw

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077889061 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softw

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077852005 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Ap

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2077806119 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/test/java/org/apache/nifi/excel/TestExcelRecordReader.java: ## @@ -122,20 +112,32 @@ public void testNonExce

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
dan-s1 commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2858778016 @zhtk From message above it seems there are conflicts you must resolve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-07 Thread via GitHub
zhtk commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2858250013 After reading whole discussion I decided to remove type detection and to add `Input File Type` property. There are 2 reasons for that: 1. In case of passworded Excel file, to determine file t

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-06 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2075890623 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator impleme

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-06 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2075826260 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator implements Iterator

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-06 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2075680791 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator impleme

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-05-06 Thread via GitHub
zhtk commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2075613587 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator implements Iterator

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-25 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2060255148 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator implements Iterat

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052863689 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator impleme

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052850697 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator implements Iterat

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052633543 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhau

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052629031 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052617455 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052629031 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052617455 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052566486 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052617455 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052566486 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052566486 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052566486 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052566486 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -129,4 +151,37 @@ private boolean hasExhaustedRows()

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-21 Thread via GitHub
exceptionfactory commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2052503679 ## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/RowIterator.java: ## @@ -42,13 +51,26 @@ class RowIterator impleme

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-11 Thread via GitHub
zhtk commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2797765173 Yes, rebased @exceptionfactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-11 Thread via GitHub
exceptionfactory commented on PR #9874: URL: https://github.com/apache/nifi/pull/9874#issuecomment-2797412950 Thanks @zhtk, can you rebase this pull request from the updated `main` branch? That will address an unrelated unit test failure. -- This is an automated message from the Apache G

[PR] NIFI-14426: Add support for HSSF format in ExcelReader processor [nifi]

2025-04-11 Thread via GitHub
zhtk opened a new pull request, #9874: URL: https://github.com/apache/nifi/pull/9874 # Summary [NIFI-14426](https://issues.apache.org/jira/browse/NIFI-14426): Add support for HSSF format in ExcelReader processor # Tracking