dan-s1 commented on code in PR #9874: URL: https://github.com/apache/nifi/pull/9874#discussion_r2079999521
########## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/InputFileType.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.excel; + +import org.apache.nifi.components.DescribedValue; + +public enum InputFileType implements DescribedValue { + XLS("XLS", "XLS 1997-2007 file format"), + XLSX("XLSX", "XLSX 2007-present OOXML file format"); + + InputFileType(String displayName, String description) { + this.displayName = displayName; + this.description = description; + } + + private final String displayName; + private final String description; + + @Override + public String getValue() { + return name(); + } + + @Override + public String getDisplayName() { + return displayName; + } Review Comment: Since the value for `displayName` is the same as `value `just use `name()`. ```suggestion public enum InputFileType implements DescribedValue { XLS("XLS 1997-2007 file format"), XLSX("XLSX 2007-present OOXML file format"); InputFileType(String description) { this.description = description; } private final String description; @Override public String getValue() { return name(); } @Override public String getDisplayName() { return name(); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
