[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769480#comment-15769480 ] Matt McCline commented on HIVE-15335: - Committed to master. Thanks [~sershe], [~prasa

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769465#comment-15769465 ] Matt McCline commented on HIVE-15335: - HIVE-15335.0993.patch is final patch. > Fast D

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769383#comment-15769383 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768058#comment-15768058 ] Matt McCline commented on HIVE-15335: - Query benchmark on V1 showed very, very high co

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767775#comment-15767775 ] Owen O'Malley commented on HIVE-15335: -- Review comments: * Thank you for addressing m

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767523#comment-15767523 ] Owen O'Malley commented on HIVE-15335: -- To create a pull request, push your change to

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767509#comment-15767509 ] Owen O'Malley commented on HIVE-15335: -- The patch doesn't apply cleanly because the r

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766078#comment-15766078 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765845#comment-15765845 ] Matt McCline commented on HIVE-15335: - [~prasanth_j] Thanks for your review! 24-hour

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765693#comment-15765693 ] Prasanth Jayachandran commented on HIVE-15335: -- the new changes look good to

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765479#comment-15765479 ] Prasanth Jayachandran commented on HIVE-15335: -- Left some comments in RB - bl

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765409#comment-15765409 ] Matt McCline commented on HIVE-15335: - This fully addresses Owen's -1 from 5 days ago

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765383#comment-15765383 ] Matt McCline commented on HIVE-15335: - The HiveDecimal and HiveDecimalWritable support

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764029#comment-15764029 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763888#comment-15763888 ] Matt McCline commented on HIVE-15335: - The avro changes in the diff are essentially re

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763881#comment-15763881 ] Matt McCline commented on HIVE-15335: - Changed decimal.toBytes(..) to toString to get

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763703#comment-15763703 ] Prasanth Jayachandran commented on HIVE-15335: -- I think this will break bloom

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763649#comment-15763649 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763320#comment-15763320 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756221#comment-15756221 ] Matt McCline commented on HIVE-15335: - A good test run (all failures are known and Tes

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756031#comment-15756031 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755929#comment-15755929 ] Sergey Shelukhin commented on HIVE-15335: - +1, I am assuming it is on by default s

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755395#comment-15755395 ] Sergey Shelukhin commented on HIVE-15335: - Done with RB up to iter #7. Phew! Left

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754023#comment-15754023 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753102#comment-15753102 ] Matt McCline commented on HIVE-15335: - I am very clear I do not want to support 3rd pa

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751776#comment-15751776 ] Owen O'Malley commented on HIVE-15335: -- Speeding up the decimal vectorization is insa

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751519#comment-15751519 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749966#comment-15749966 ] Matt McCline commented on HIVE-15335: - I have great difficulty accepting that DecimalC

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749845#comment-15749845 ] Matt McCline commented on HIVE-15335: - I haven't created a pull request before. But, d

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749741#comment-15749741 ] Owen O'Malley commented on HIVE-15335: -- * This breaks API compatibility of DecimalCol

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749719#comment-15749719 ] Owen O'Malley commented on HIVE-15335: -- Please create a pull request. > Fast Decimal

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749455#comment-15749455 ] Matt McCline commented on HIVE-15335: - Patch 091 is a good test run (all test failures

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748570#comment-15748570 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747971#comment-15747971 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745172#comment-15745172 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744545#comment-15744545 ] Matt McCline commented on HIVE-15335: - I haven't created a pull request before. But,

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743990#comment-15743990 ] Sergey Shelukhin commented on HIVE-15335: - Did a pass of everything except FastHiv

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734741#comment-15734741 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734523#comment-15734523 ] Matt McCline commented on HIVE-15335: - Build for #6 crashed. > Fast Decimal > ---

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728726#comment-15728726 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725456#comment-15725456 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725337#comment-15725337 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722187#comment-15722187 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721412#comment-15721412 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717495#comment-15717495 ] Hive QA commented on HIVE-15335: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716935#comment-15716935 ] Matt McCline commented on HIVE-15335: - Current patch is a Work-In-Progress so the perf

[jira] [Commented] (HIVE-15335) Fast Decimal

[ https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716807#comment-15716807 ] Owen O'Malley commented on HIVE-15335: -- Matt, Can you post a pull request please? >