[
https://issues.apache.org/jira/browse/HIVE-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763703#comment-15763703
]
Prasanth Jayachandran commented on HIVE-15335:
----------------------------------------------
I think this will break bloom filters for decimal columns. Changing addString()
to addBytes() will have different hashcode based on the default charset of the
system. I can see from comments that decimal.toBytes() returns UTF-8 bytes. But
the earlier addString() could return UTF-16 bytes or some other charset based
on the system default.
Also avro_decimal*.q test cases are returning different column stats for
num_false. Not sure why is this changing the column stats output.
> Fast Decimal
> ------------
>
> Key: HIVE-15335
> URL: https://issues.apache.org/jira/browse/HIVE-15335
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Attachments: HIVE-15335.01.patch, HIVE-15335.02.patch,
> HIVE-15335.03.patch, HIVE-15335.04.patch, HIVE-15335.05.patch,
> HIVE-15335.06.patch, HIVE-15335.07.patch, HIVE-15335.08.patch,
> HIVE-15335.09.patch, HIVE-15335.091.patch, HIVE-15335.092.patch,
> HIVE-15335.093.patch, HIVE-15335.094.patch, HIVE-15335.095.patch,
> HIVE-15335.096.patch, HIVE-15335.097.patch, HIVE-15335.098.patch
>
>
> Replace HiveDecimal implementation that currently represents the decimal
> internally as a BigDecimal with a faster version that does not allocate extra
> objects
> Replace HiveDecimalWritable implementation with a faster version that has new
> mutable* calls (e.g. mutableAdd, mutableEnforcePrecisionScale, etc) and
> stores the result as a fast decimal instead of a slow byte array containing a
> serialized BigInteger.
> Provide faster ways to serialize/deserialize decimals.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
