[jira] [Comment Edited] (HIVE-7172) Potential resource leak in HiveSchemaTool#getMetaStoreSchemaVersion()

2017-03-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561965#comment-14561965 ] Ted Yu edited comment on HIVE-7172 at 3/10/17 1:43 AM: --- lgtm {code}

[jira] [Commented] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2016-11-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638620#comment-15638620 ] Ted Yu commented on HIVE-8176: -- Test failure was not related. > Close of FSDataOutputStream i

[jira] [Comment Edited] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2016-11-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613247#comment-15613247 ] Ted Yu edited comment on HIVE-8458 at 11/5/16 4:55 AM: --- Agree with Na

[jira] [Comment Edited] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2016-10-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058348#comment-15058348 ] Ted Yu edited comment on HIVE-7305 at 10/29/16 2:30 PM: lgtm nit:

[jira] [Commented] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2016-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613247#comment-15613247 ] Ted Yu commented on HIVE-8458: -- Agree with Navis. > Potential null dereference in Utilities#c

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2016-05-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2016-05-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2016-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Status: Patch Available (was: Open) > Potential null dereference in Utilities#clearWork() > --

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2016-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Attachment: HIVE-8458.v2.patch > Potential null dereference in Utilities#clearWork() >

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2016-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Resolution: Not A Problem Status: Resolved (was: Patch Available) This is no longer a problem. > Referenc

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2016-05-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2016-05-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()

2016-04-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8177: - Description: {code} JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(), true,

[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2016-04-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8176: - Description: {code} try { FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2016-04-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()

2016-04-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7598: - Description: Call to Utilities.mvFileToFinalPath() passes null as second last parameter, conf. null gets passed to

[jira] [Commented] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2016-03-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185933#comment-15185933 ] Ted Yu commented on HIVE-7862: -- Test failures didn't seem to be related. > close of InputStre

[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2016-03-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7672: - Description: Here is related code: {code} OutputStream out = fs.create(metadataPath); out.write(jsonCon

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2016-02-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2016-02-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7862: - Attachment: HIVE-7862.1.patch > close of InputStream in Utils#copyToZipStream() should be placed in finally > bloc

[jira] [Commented] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()

2016-01-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125561#comment-15125561 ] Ted Yu commented on HIVE-8177: -- I don't think the test failure was related to the patch. > Wr

[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2016-01-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8176: - Attachment: HIVE-8176.v1.patch > Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally > claus

[jira] [Commented] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2016-01-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125552#comment-15125552 ] Ted Yu commented on HIVE-7862: -- QA still didn't pick up the patch. > close of InputStream in

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2016-01-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2015-12-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7862: - Attachment: HIVE-7862.1.patch > close of InputStream in Utils#copyToZipStream() should be placed in finally > bloc

[jira] [Commented] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2015-12-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058348#comment-15058348 ] Ted Yu commented on HIVE-7305: -- lgtm nit: indentation is off please add space between if and

[jira] [Commented] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2015-12-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058358#comment-15058358 ] Ted Yu commented on HIVE-7672: -- lgtm nit: indentation is off - please use two spaces > Poten

[jira] [Commented] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2015-12-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043973#comment-15043973 ] Ted Yu commented on HIVE-7862: -- I wonder why QA run didn't start. > close of InputStream in U

[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()

2015-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8177: - Description: {code} JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(), true,

[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2015-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7862: - Description: In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , line 278 : {code} private

[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2015-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7672: - Description: Here is related code: {code} OutputStream out = fs.create(metadataPath); out.write(jsonCon

[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2015-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8176: - Description: {code} try { FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);

[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()

2015-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7598: - Description: Call to Utilities.mvFileToFinalPath() passes null as second last parameter, conf. null gets passed to

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2015-10-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2015-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8176: - Description: {code} try { FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);

[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

2015-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7862: - Description: In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , line 278 : {code} private

[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2015-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7672: - Description: Here is related code: {code} OutputStream out = fs.create(metadataPath); out.write(jsonCon

[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()

2015-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7598: - Description: Call to Utilities.mvFileToFinalPath() passes null as second last parameter, conf. null gets passed to

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2015-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-7172) Potential resource leak in HiveSchemaTool#getMetaStoreSchemaVersion()

2015-10-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7172: - Description: {code} ResultSet res = stmt.executeQuery(versionQuery); if (!res.next()) { throw n

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-09-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-09-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-09-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-09-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-09-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-09-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-09-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-08-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2015-08-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-7172) Potential resource leak in HiveSchemaTool#getMetaStoreSchemaVersion()

2015-08-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7172: - Description: {code} ResultSet res = stmt.executeQuery(versionQuery); if (!res.next()) { throw n

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-08-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-07-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2015-07-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8176: - Description: {code} try { FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-07-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-07-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-07-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()

2015-07-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7598: - Description: Call to Utilities.mvFileToFinalPath() passes null as second last parameter, conf. null gets passed to

[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2015-07-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7672: - Description: Here is related code: {code} OutputStream out = fs.create(metadataPath); out.write(jsonCon

[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8176: - Description: {code} try { FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);

[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8177: - Description: {code} JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(), true,

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-07-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8177: - Description: {code} JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(), true,

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7598: - Description: Call to Utilities.mvFileToFinalPath() passes null as second last parameter, conf. null gets passed t

[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2015-06-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7672: - Description: Here is related code: {code} OutputStream out = fs.create(metadataPath); out.write(jsonCon

[jira] [Updated] (HIVE-7150) FileInputStream is not closed in HiveConnection#getHttpClient()

2015-06-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7150: - Description: Here is related code: {code} sslTrustStore.load(new FileInputStream(sslTrustStorePath),

[jira] [Updated] (HIVE-7172) Potential resource leak in HiveSchemaTool#getMetaStoreSchemaVersion()

2015-06-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7172: - Description: {code} ResultSet res = stmt.executeQuery(versionQuery); if (!res.next()) { throw n

[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-06-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7180: - Description: Here is related code: {code} BufferedReader bfReader = new BufferedReader(new FileReader

[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()

2015-06-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7305: - Description: {code} long readLongLE(InputStream in) throws IOException { in.read(readBuffer, 0, 8); retur

[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()

2015-06-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7672: - Description: Here is related code: {code} OutputStream out = fs.create(metadataPath); out.write(jsonCo

[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()

2015-06-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-7598: - Description: Call to Utilities.mvFileToFinalPath() passes null as second last parameter, conf. null gets passed to

[jira] [Updated] (HIVE-8343) Return value from BlockingQueue.offer() is not checked in DynamicPartitionPruner

2015-06-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8343: - Description: In addEvent() and processVertex(), there is call such as the following: {code} queue.offer(e

[jira] [Updated] (HIVE-8458) Potential null dereference in Utilities#clearWork()

2015-06-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8458: - Description: {code} Path mapPath = getPlanPath(conf, MAP_PLAN_NAME); Path reducePath = getPlanPath(conf, RE

[jira] [Updated] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

2015-06-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8282: - Description: In convertJoinMapJoin(): {code} for (Operator parentOp : joinOp.getParentOperators()) { if

[jira] [Updated] (HIVE-8342) Potential null dereference in ColumnTruncateMapper#jobClose()

2015-06-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8342: - Description: {code} Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx, null, reporter

[jira] [Updated] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()

2015-06-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HIVE-8285: - Description: {code} if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo && eC.getValue() == Bool

[jira] [Commented] (HIVE-7150) FileInputStream is not closed in HiveConnection#getHttpClient()

2015-05-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563754#comment-14563754 ] Ted Yu commented on HIVE-7150: -- Patch v2 looks good. > FileInputStream is not closed in HiveC

  1   2   >