[ https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058358#comment-15058358 ]
Ted Yu commented on HIVE-7672: ------------------------------ lgtm nit: indentation is off - please use two spaces > Potential resource leak in EximUtil#createExportDump() > ------------------------------------------------------ > > Key: HIVE-7672 > URL: https://issues.apache.org/jira/browse/HIVE-7672 > Project: Hive > Issue Type: Bug > Reporter: Ted Yu > Assignee: SUYEON LEE > Priority: Minor > Attachments: HIVE-7672.patch > > > Here is related code: > {code} > OutputStream out = fs.create(metadataPath); > out.write(jsonContainer.toString().getBytes("UTF-8")); > out.close(); > {code} > If out.write() throws exception, out would be left unclosed. > out.close() should be enclosed in finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)