GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5140
[FLINK-7797] [table] Add support for windowed outer joins for streaming
tables
## What is the purpose of the change
This PR adds support for windowed outer joins for streaming tables
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5068
Hi @fhueske and @twalthr, I wonder if you could have a look at the latest
update. Thanks!
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5165
[FLINK-8285] [table] Enable query configuration for batch queries
## What is the purpose of the change
This PR enables the query configuration for queries in batch table
environment
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5165
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5169
[FLINK-8258] [table] Enable query configuration for batch queries
## What is the purpose of the change
This PR enables the query configuration for queries in batch table
environment
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5177
[FLINK-8278] [doc] Fix the private member init problem for Scala examples
in docs
## What is the purpose of the change
This PR fixes the improper initialization problem for Scala private
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5192
[FLINK-8257] [conf] Unify the value checks for setParallelism()
## What is the purpose of the change
This PR unifies the value checks for `setParallelism()` methods in
different components
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5192
Hi @aljoscha, I wonder if you could help review this PR when you are
convenient.
Thanks, Xingcan
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5169
Hi @twalthr, I wonder if you could help review this PR when you are
convenient.
Thanks, Xingcan
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5177
Hi @fhueske, I wonder if you could have a look at this PR when you are
convenient.
Thanks, Xingcan
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5177
Thanks for looking into this @fhueske. I'll close this PR.
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5177
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5210
[FLINK-8316][table]The CsvTableSink and the CsvInputFormat are not in sync
## What is the purpose of the change
This PR adds an extra parameter (`trailingDelim`) to `CsvTableSink` to
enable
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159023858
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -142,50 +143,47 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159069074
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinAwareCollector.scala
---
@@ -0,0 +1,68
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159069304
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
@@ -182,16 +196,64 @@ abstract class
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5140
Hi @fhueske, thanks for your review. I've made the following changes to the
PR.
1. Fixes the "wrong sides" problem in `TimeBoundedStreamJoin`.
2. Adds the logic for outer-join
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5192
Thanks for the review, @aljoscha ð . I'll close this PR.
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5192
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5169
Thanks for the review @twalthr ð
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5140
Hi @fhueske, thanks for your concrete suggestions! IMO, the refactorings in
`TimeBoundedStreamJoin` are quite reasonable, while the refactoring for
`createNegativeWindowSizeJoin()` may not be so
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5210
Hi @sunjincheng121, thanks for the review! You may refer to [this
thread](https://lists.apache.org/thread.html/cfe3b1718a479300dc91d1523be023ef5bc702bd5ad53af4fea5a596@%3Cuser.flink.apache.org%3E)
for
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5210
Hi @sunjincheng121, yes, the reported issue should be solved with
FLINK-8331. In addition, maybe we can add the trailing delimiter as a new
feature (like the
[CSVParser.java](https://github.com
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5210
Hi @sunjincheng121, thanks for your reply. I think an example would be
that, for some non-standard CSV files like `a, b , c,`, if the boolean flag
`trailingDelimiter=false`, the file will be parsed
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5368
[Flink-8407][DataStream]Setting the parallelism after a partitioning
operation should be forbidden
## What is the purpose of the change
This PR forbids the users to set parallelism after a
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5368
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5369
[FLINK-8407] [DataStream] Setting the parallelism after a partitioninâ¦
## What is the purpose of the change
This PR forbids the users to set parallelism after a partitioning operation
(e.g
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Sure. I'll update the PR to make it more appropriate and thanks for your
review, @aljoscha.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Hi @aljoscha, since the `DataStream` in Java API do not own a
`setParallelism` method as the Scala API, do you think it's necessary to add
such one?
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
That makes sense to me. I just wonder what do you mean by "add a test for
the Java API"...
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Ah ha, it doesn't matter. ð The test has been updated. Actually, I
wanted to ensure that all the partitioning methods should cause the exception.
However, that would be fussy and thus I only
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5369
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5369
Sure. Thanks for helping merge this!
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168436287
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonNodeDeserializationSchema.java
---
@@ -0,0 +1,53
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168439885
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonSchemaConverter.java
---
@@ -0,0 +1,358 @@
+/*
+ * Licensed to the
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168449398
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168438157
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonNodeDeserializationSchema.java
---
@@ -0,0 +1,53
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168439090
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
---
@@ -0,0 +1,217
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5491#discussion_r168446783
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonSchemaConverter.java
---
@@ -0,0 +1,358 @@
+/*
+ * Licensed to the
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5505
[FLINK-8538][table]Add a Kafka table source factory with JSON format support
## What is the purpose of the change
This PR adds Kafka JSON table source factories for different Kafka versions
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5505
Yes @twalthr, that will be great! I'll start working on the
`KafkaAvroTableSourceFactory` and keep an eye on the API refactorings.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170194561
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptorValidator.scala
---
@@ -27,13 +27,27 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170180103
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170191830
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170185039
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/table/descriptors/KafkaValidator.java
---
@@ -0,0 +1,123
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170181909
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactoryService.scala
---
@@ -43,7 +42,7 @@ object
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170175378
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170175473
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170188551
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5505
---
201 - 250 of 250 matches
Mail list logo
