GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/5210

    [FLINK-8316][table]The CsvTableSink and the CsvInputFormat are not in sync

    ## What is the purpose of the change
    
    This PR adds an extra parameter (`trailingDelim`) to `CsvTableSink` to 
enable appending a trailing field delimiter for each row.
    
    ## Brief change log
    
      - Adds an extra boolean parameter `trailingDelim` to `CsvTableSink`.
      - Adds a related test case to 
`org.apache.flink.table.runtime.batch.table.TableSinkITCase`.
    
    
    ## Verifying this change
    
    This change can be verified by the added test case in `TableSinkITCase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (**yes**)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-8316

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5210
    
----
commit 27a75a8ad593cddb69873c67ad9e486cca580dbe
Author: Xingcan Cui <xingcanc@...>
Date:   2017-12-28T08:30:01Z

    [FLINK-8316][table]The CsvTableSink and the CsvInputFormat are not in sync

----


---

Reply via email to