[PR] [FLINK-35016] catalog changes for model resource [flink]

2024-07-07 Thread via GitHub
lihaosky opened a new pull request, #25036: URL: https://github.com/apache/flink/pull/25036 ## What is the purpose of the change Catalog changes to support model resource ## Brief change log * Add `CatalogModel` related resource * Add model CRUD operations in `Cata

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-07-07 Thread via GitHub
lihaosky commented on PR #25036: URL: https://github.com/apache/flink/pull/25036#issuecomment-2212606448 cc @twalthr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25036: URL: https://github.com/apache/flink/pull/25036#issuecomment-2212607683 ## CI report: * dd6632371c5404780ab79e7ed308db46c6152154 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics ar… [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25037: URL: https://github.com/apache/flink/pull/25037 …en't updated after failover. (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.17 of https://github.com/

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25038: URL: https://github.com/apache/flink/pull/25038 (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.18 of https://github.com/apache/flink/pull/25021 -- This is

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25039: URL: https://github.com/apache/flink/pull/25039 (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.19 of https://github.com/apache/flink/pull/25021 -- This is

[PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal opened a new pull request, #25040: URL: https://github.com/apache/flink/pull/25040 (cherry picked from commit 615d19735b0691b57262a110e6078c3488349f5a) ## What is the purpose of the change BP for 1.20 of https://github.com/apache/flink/pull/25021 --

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25037: URL: https://github.com/apache/flink/pull/25037#issuecomment-221297 ## CI report: * 1300c054a1ffa88c18f4c6c28a154207ce12bf98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25038: URL: https://github.com/apache/flink/pull/25038#issuecomment-2212777977 ## CI report: * 8cb40a599c1e127b5f427be710f4a840c7fa4ca1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25039: URL: https://github.com/apache/flink/pull/25039#issuecomment-2212781383 ## CI report: * f1c40d72af10e7ba07304c018cdd2588a07bf395 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25040: URL: https://github.com/apache/flink/pull/25040#issuecomment-2212781614 ## CI report: * 7f1b9491efa0ce3bb7a4815732d9ff10a82056bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
1996fanrui commented on code in PR #25030: URL: https://github.com/apache/flink/pull/25030#discussion_r1667861271 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -773,6 +773,13 @@ static boolean shouldSyn

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
fredia merged PR #25032: URL: https://github.com/apache/flink/pull/25032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
fredia commented on PR #25032: URL: https://github.com/apache/flink/pull/25032#issuecomment-2212848554 @kartikeypant Thanks for the PR, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-35781][cli] Provide a default parallelism (1) for pipeline jobs [flink-cdc]

2024-07-07 Thread via GitHub
yuxiqian commented on PR #3458: URL: https://github.com/apache/flink-cdc/pull/3458#issuecomment-2212862904 @ruanhang1993 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [hotfix][doc] missing "STATISTICS" sql reserved keyword in zh doc [flink]

2024-07-07 Thread via GitHub
showuon opened a new pull request, #25041: URL: https://github.com/apache/flink/pull/25041 ## What is the purpose of the change In [FLINK-28493](https://github.com/apache/flink/pull/20506/), we implemented "ANALYZE TABLE" syntax feature and documented the reserved keyword: **

Re: [PR] [hotfix][doc] missing "STATISTICS" sql reserved keyword in zh doc [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25041: URL: https://github.com/apache/flink/pull/25041#issuecomment-2212873141 ## CI report: * aa4b31c68b9831a2e78bfff7d976e2b32dd229bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35737] Prevent Memory Leak by Closing MemoryExecutionGraphInfoStore on MiniCluster Shutdown [flink]

2024-07-07 Thread via GitHub
fengjiajie commented on PR #25009: URL: https://github.com/apache/flink/pull/25009#issuecomment-2212880693 Could you please take a look when you have time? @Samrat002 @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-07 Thread via GitHub
Zakelly commented on code in PR #25030: URL: https://github.com/apache/flink/pull/25030#discussion_r1667911678 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -773,6 +773,13 @@ static boolean shouldSyncAf

Re: [PR] [FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal commented on PR #25038: URL: https://github.com/apache/flink/pull/25038#issuecomment-2212931466 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] [hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25042: URL: https://github.com/apache/flink/pull/25042 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[PR] [BP-1.20][hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25043: URL: https://github.com/apache/flink/pull/25043 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25042: URL: https://github.com/apache/flink/pull/25042#issuecomment-2212952936 ## CI report: * b334fec2d8479c8e9e30928fc3fd6e6fa3f8f296 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.19][hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25044: URL: https://github.com/apache/flink/pull/25044 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [BP-1.20][hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25043: URL: https://github.com/apache/flink/pull/25043#issuecomment-2212960152 ## CI report: * 3639c3545b47b7a06562c3deb316a11dccf3c885 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
Zakelly opened a new pull request, #25045: URL: https://github.com/apache/flink/pull/25045 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [BP-1.19][hotfix][doc] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25044: URL: https://github.com/apache/flink/pull/25044#issuecomment-2212968492 ## CI report: * aa3002c4d9433402793d85bccbba3d0768c1761a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][hotfix][doc] Fix the broken link of standalone deployment [flink]

2024-07-07 Thread via GitHub
flinkbot commented on PR #25045: URL: https://github.com/apache/flink/pull/25045#issuecomment-2212968868 ## CI report: * 9dc582bf8e0ed6e19306431c9a71542bb238784b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-07 Thread via GitHub
kartikeypant commented on PR #25032: URL: https://github.com/apache/flink/pull/25032#issuecomment-2213000911 Thanks for the merge, @fredia. I have also created backport PRs for 1.19 (https://github.com/apache/flink/pull/25033) and 1.20 versions (https://github.com/apache/flink/pull/25034),

Re: [PR] [BP-1.17][FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal commented on PR #25037: URL: https://github.com/apache/flink/pull/25037#issuecomment-2213100328 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [BP-1.18][FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-07 Thread via GitHub
RocMarshal commented on PR #25038: URL: https://github.com/apache/flink/pull/25038#issuecomment-2213100224 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [BP-1.19][FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-07 Thread via GitHub
zhuzhurk merged PR #25024: URL: https://github.com/apache/flink/pull/25024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. [flink-cdc]

2024-07-07 Thread via GitHub
yuxiqian commented on code in PR #3438: URL: https://github.com/apache/flink-cdc/pull/3438#discussion_r1668075424 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java: ## Review Comment: In the future, defining multiple sink in one sin

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-07 Thread via GitHub
whhe commented on code in PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1668077202 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java: ## @@ -82,6 +84,14 @@ public static AbstractJdbcCatalog cr

Re: [PR] [FLINK-35781][cli] Provide a default parallelism (1) for pipeline jobs [flink-cdc]

2024-07-07 Thread via GitHub
ruanhang1993 commented on code in PR #3458: URL: https://github.com/apache/flink-cdc/pull/3458#discussion_r1668081572 ## docs/content.zh/docs/core-concept/data-pipeline.md: ## @@ -98,5 +98,5 @@ The following config options of Data Pipeline level are supported: | parameter

Re: [PR] [FLINK-35781][cli] Provide a default parallelism (1) for pipeline jobs [flink-cdc]

2024-07-07 Thread via GitHub
ruanhang1993 commented on code in PR #3458: URL: https://github.com/apache/flink-cdc/pull/3458#discussion_r1668081572 ## docs/content.zh/docs/core-concept/data-pipeline.md: ## @@ -98,5 +98,5 @@ The following config options of Data Pipeline level are supported: | parameter

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-07 Thread via GitHub
whhe commented on code in PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1668082863 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseTypeMapper.java: ## @@ -0,0 +1,167 @@ +/* + * Licens

Re: [PR] [FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. [flink-cdc]

2024-07-07 Thread via GitHub
proletarians commented on code in PR #3438: URL: https://github.com/apache/flink-cdc/pull/3438#discussion_r1668085508 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java: ## Review Comment: Got it! I will follow up on this. -- Thi

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly commented on code in PR #25030: URL: https://github.com/apache/flink/pull/25030#discussion_r1667911678 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -773,6 +773,13 @@ static boolean shouldSyncAf

Re: [PR] [docs][minor] Correct Typos in Documentation/Code [flink-cdc]

2024-07-08 Thread via GitHub
Karl-WangSK commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2213195743 hello , pls can trigger the CI e2e check? this cancelled not related to this pr. @leonardBang -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [docs][minor] Correct Typos in Documentation/Code [flink-cdc]

2024-07-08 Thread via GitHub
Karl-WangSK commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2213200856 hello , pls can trigger the CI e2e check? this cancelled not related to this pr. @ruanhang1993 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668120064 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
hlteoh37 merged PR #24964: URL: https://github.com/apache/flink/pull/24964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [BP-1.19] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-08 Thread via GitHub
hlteoh37 merged PR #25033: URL: https://github.com/apache/flink/pull/25033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [BP-1.20] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-07-08 Thread via GitHub
hlteoh37 merged PR #25034: URL: https://github.com/apache/flink/pull/25034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [Oracle][MySQL][SqlServer][PostgresSQL] Fix Oracle/MySQL/SqlServer/PostgresSQL CDC parser schema change event failed [flink-cdc]

2024-07-08 Thread via GitHub
shangeyao commented on PR #2315: URL: https://github.com/apache/flink-cdc/pull/2315#issuecomment-2213317177 > 合并到哪个版本了呢 3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#issuecomment-2213359349 > New feature has been introduced If yes, how is this documented? JavaDocs We will also need to document this on Flink docs - let's link the documentation update

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
z3d1k commented on PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#issuecomment-2213371351 > We will also need to document this on Flink docs - let's link the documentation update JIRA Linked documentation Jira. -- This is an automated message from the Apache

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-08 Thread via GitHub
whhe commented on PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2213542334 @RocMarshal Updated. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [BP-1.19][FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-08 Thread via GitHub
1996fanrui merged PR #25039: URL: https://github.com/apache/flink/pull/25039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [BP-1.20][FLINK-35750][runtime/metrics] Fix that the latency marker metrics aren't updated after failover. [flink]

2024-07-08 Thread via GitHub
1996fanrui merged PR #25040: URL: https://github.com/apache/flink/pull/25040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2024-07-08 Thread via GitHub
AHeise commented on PR #70: URL: https://github.com/apache/flink-connector-kafka/pull/70#issuecomment-2213583717 Please check my comment here. https://issues.apache.org/jira/browse/FLINK-33545?focusedCommentId=17863737&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#

[PR] [BP-1.19] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
showuon opened a new pull request, #25046: URL: https://github.com/apache/flink/pull/25046 ## What is the purpose of the change master branch PR: https://github.com/apache/flink/pull/24964. Flink UI always shows float metric value as int/long. For example, `outPoolUsage

[PR] [BP-1.20] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
showuon opened a new pull request, #25047: URL: https://github.com/apache/flink/pull/25047 ## What is the purpose of the change master branch PR: https://github.com/apache/flink/pull/24964. Flink UI always shows float metric value as int/long. For example, `outPoolUsage

Re: [PR] [BP-1.19] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
showuon commented on PR #25046: URL: https://github.com/apache/flink/pull/25046#issuecomment-2213589908 @hlteoh37 , PR to backport to 1.19. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [BP-1.20] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
showuon commented on PR #25047: URL: https://github.com/apache/flink/pull/25047#issuecomment-2213590142 @hlteoh37 , PR to backport to 1.20. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [BP-1.19] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25046: URL: https://github.com/apache/flink/pull/25046#issuecomment-2213598638 ## CI report: * b875e4639e6b694de4b12a127484d3308b3f1501 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-08 Thread via GitHub
mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1668364184 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -266,19 +30

Re: [PR] [BP-1.20] [FLINK-35657][runtime-web] use parseFloat for metric value [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25047: URL: https://github.com/apache/flink/pull/25047#issuecomment-2213599102 ## CI report: * 83126341fe0ac6764c0ae74ae354fa97968f37f6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
JimmyZZZ commented on code in PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#discussion_r1668370765 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -449,12 +460,17 @@ public void onCompletion(RecordMet

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
JimmyZZZ commented on code in PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#discussion_r1668387172 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -411,11 +411,22 @@ private void registerMetricSync()

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
JimmyZZZ commented on PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#issuecomment-2213634985 > Please also add some more details to the PR description and commit message in accordance with the [guidlines](https://flink.apache.org/how-to-contribute/reviewing-prs/). I

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
JimmyZZZ closed pull request #107: [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while URL: https://github.com/apache/flink-connector-kafka/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
JimmyZZZ commented on code in PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#discussion_r1668396762 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -411,11 +411,22 @@ private void registerMetricSync()

[PR] [hotfix][checkpoint] Rename file-merging options in documents [flink]

2024-07-08 Thread via GitHub
fredia opened a new pull request, #25048: URL: https://github.com/apache/flink/pull/25048 ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-34482 renamed options for checkpointing, but the file-merging documents are not updated. This PR updates

Re: [PR] [hotfix][checkpoint] Rename file-merging options in documents [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25048: URL: https://github.com/apache/flink/pull/25048#issuecomment-2213665532 ## CI report: * 051486f910ad10f192178a50b6bd42e34c9733c2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.20][hotfix][checkpoint] Rename file-merging options in documents [flink]

2024-07-08 Thread via GitHub
fredia opened a new pull request, #25049: URL: https://github.com/apache/flink/pull/25049 ## What is the purpose of the change 1.18 backport for parent PR https://github.com/apache/flink/pull/25048 No conflicts appeared during backport. ## Brief change log - Up

Re: [PR] [BP-1.20][hotfix][checkpoint] Rename file-merging options in documents [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25049: URL: https://github.com/apache/flink/pull/25049#issuecomment-2213681978 ## CI report: * cfda72da0150ea96a9b6a22935580c8757a517db UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [minor][test] Remove duplicate test code [flink-cdc]

2024-07-08 Thread via GitHub
Karl-WangSK opened a new pull request, #3460: URL: https://github.com/apache/flink-cdc/pull/3460 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [minor][test] Remove duplicate test code [flink-cdc]

2024-07-08 Thread via GitHub
Karl-WangSK commented on PR #3460: URL: https://github.com/apache/flink-cdc/pull/3460#issuecomment-2213697218 @yuxiqian @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-35774][cdc-runtime] Fix the cache of transform is not updated after process schema change event [flink-cdc]

2024-07-08 Thread via GitHub
yuxiqian commented on code in PR #3455: URL: https://github.com/apache/flink-cdc/pull/3455#discussion_r1668456054 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperator.java: ## Review Comment: I'm a bit unsure if `transfor

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1668396430 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/KinesisShardSplitWithAssignmentStatus.

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-07-08 Thread via GitHub
morazow commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2213814301 Thanks @dongwoo6kim, Looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-35776] Simplify job status handling [flink-kubernetes-operator]

2024-07-08 Thread via GitHub
ferenc-csaky commented on code in PR #851: URL: https://github.com/apache/flink-kubernetes-operator/pull/851#discussion_r1668491036 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -263,14 +268,24 @@ protec

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-08 Thread via GitHub
kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668545338 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManage

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly commented on PR #25030: URL: https://github.com/apache/flink/pull/25030#issuecomment-2213958804 Thanks Rui! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [BP-1.20][FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly merged PR #25031: URL: https://github.com/apache/flink/pull/25031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35778] Escape URI reserved characters when creating file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly merged PR #25030: URL: https://github.com/apache/flink/pull/25030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1668622658 ## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java: ## @@ -41,6 +42,41 @@ /** Base class for file

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668650443 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-08 Thread via GitHub
mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1668650953 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -266,19 +30

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668650443 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1668649676 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/event/SplitsFinishedEvent.java: ## @@ -0,

[PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan opened a new pull request, #25050: URL: https://github.com/apache/flink/pull/25050 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring th

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25050: URL: https://github.com/apache/flink/pull/25050#issuecomment-2214162634 ## CI report: * 2d524cf16224834ef4b8c3fd7f4c63caabdf43ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668797608 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668797608 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35707][Table SQL / API] Allow column definition in CREATE TABLE AS (CTAS) [flink]

2024-07-08 Thread via GitHub
twalthr merged PR #24987: URL: https://github.com/apache/flink/pull/24987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668850192 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdo

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668880762 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668880762 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668882384 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668896504 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdo

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668897088 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdo

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668927920 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -396,7 +399,9 @@ public void close() throws IOException { if (LOG.isInfoE

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668975142 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -396,7 +399,9 @@ public void close() throws IOException { if (LOG.

[PR] [FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly opened a new pull request, #25051: URL: https://github.com/apache/flink/pull/25051 ## What is the purpose of the change The `OperatorSubtaskState` only make keyed state register with `SharedStateRegistry`. However, the file-merging directories's handle are wrapped in `FileMer

[PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly opened a new pull request, #25052: URL: https://github.com/apache/flink/pull/25052 ## What is the purpose of the change The `OperatorSubtaskState` only make keyed state register with `SharedStateRegistry`. However, the file-merging directories's handle are wrapped in `FileMer

Re: [PR] [FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25051: URL: https://github.com/apache/flink/pull/25051#issuecomment-2214714463 ## CI report: * e555779cb606a2ecb5bcd7f5f6e7c12eddd85a65 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25052: URL: https://github.com/apache/flink/pull/25052#issuecomment-2214715238 ## CI report: * cadb2364f238bf047e938b742079f7f56a2b10ea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

<    5   6   7   8   9   10   11   12   13   14   >