JimmyZZZ commented on code in PR #107:
URL:
https://github.com/apache/flink-connector-kafka/pull/107#discussion_r1668370765
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -449,12 +460,17 @@ public void onCompletion(RecordMetadata metadata,
Exception exception) {
}
// Checking for exceptions from previous writes
- mailboxExecutor.submit(
+ // Notice: throwing exception in mailboxExecutor thread is not
safe enough for
+ // triggering global
+ // fail over, which has been fixed in [FLINK-31305]. And using
+ // mailboxExecutor.execute() is better than
+ // mailboxExecutor.submit() since submit will swallow
exceptions inside.
+ mailboxExecutor.execute(
Review Comment:
@AHeise removed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
