flinkbot commented on PR #24925:
URL: https://github.com/apache/flink/pull/24925#issuecomment-2162103966
## CI report:
* e5d84501e6a2781205494bf429c29e1afe0d4031 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158609
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158973
@gaborgsomogyi I have addressed the comment, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
fredia commented on code in PR #24924:
URL: https://github.com/apache/flink/pull/24924#discussion_r1635853720
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java:
##
@@ -167,22 +166,25 @@ private void verifyStateHandleType
yuxiqian commented on PR #3036:
URL: https://github.com/apache/flink-cdc/pull/3036#issuecomment-2162171729
Hi @pengmide, could you please rebase this PR with latest `master` branch
before it could be merged? Thanks!
--
This is an automated message from the Apache Git Service.
To respond t
TanYuxin-tyx commented on code in PR #24900:
URL: https://github.com/apache/flink/pull/24900#discussion_r1635860182
##
flink-runtime/src/test/java/org/apache/flink/runtime/util/NettyShuffleDescriptorBuilder.java:
##
@@ -80,8 +83,14 @@ public NettyShuffleDescriptor buildRemote()
loserwang1024 opened a new pull request, #3412:
URL: https://github.com/apache/flink-cdc/pull/3412
CDC pipeline connector provide ability to verify requiredOptions and
optionalOptions, nor will be hard to handle compatibility later。
--
This is an automated message from the Apache Git Ser
TanYuxin-tyx commented on code in PR #24900:
URL: https://github.com/apache/flink/pull/24900#discussion_r1635866275
##
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java:
##
@@ -490,6 +490,24 @@ public enum CompressionCodec {
joyCurry30 commented on code in PR #3398:
URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635870700
##
flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh:
##
@@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then
exit 1
fi
-# Setup Flink related configuratio
yuxiqian commented on PR #3412:
URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2162196171
Seems there's some overlap between this PR and #3382, @loserwang1024 mind if
I cherry pick your commit?
--
This is an automated message from the Apache Git Service.
To respond to the
yuxiqian commented on code in PR #3398:
URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635883374
##
flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh:
##
@@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then
exit 1
fi
-# Setup Flink related configurations
yuxiqian commented on code in PR #3398:
URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635883374
##
flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh:
##
@@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then
exit 1
fi
-# Setup Flink related configurations
morazow commented on code in PR #3412:
URL: https://github.com/apache/flink-cdc/pull/3412#discussion_r1635917238
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceFactoryTest.ja
joyCurry30 commented on code in PR #3398:
URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635923711
##
flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh:
##
@@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then
exit 1
fi
-# Setup Flink related configuratio
morazow commented on code in PR #3382:
URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635924042
##
flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundati
morazow commented on code in PR #3411:
URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1635930879
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableI
yuxiqian commented on code in PR #3382:
URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635956703
##
flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundat
GOODBOY008 commented on code in PR #3203:
URL: https://github.com/apache/flink-cdc/pull/3203#discussion_r1635937545
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/java/org/apache/flink/cdc/connectors/oracle/testutils/OracleTestUtils.java:
##
qg-lin commented on code in PR #3411:
URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1635967850
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableIT
morazow commented on code in PR #3382:
URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635999340
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/java/org/apache/flink/cdc/connectors/kafka/sink/KafkaDataSinkFactoryTest.java:
morazow commented on code in PR #3382:
URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1636001422
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksDataSinkFactor
morazow commented on code in PR #3411:
URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1636002649
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableI
pnowojski commented on PR #24895:
URL: https://github.com/apache/flink/pull/24895#issuecomment-2162389538
Yes, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Zakelly commented on code in PR #24924:
URL: https://github.com/apache/flink/pull/24924#discussion_r1636034323
##
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java:
##
@@ -167,22 +166,25 @@ private void verifyStateHandleTyp
Zakelly commented on PR #24924:
URL: https://github.com/apache/flink/pull/24924#issuecomment-2162569651
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
reswqa merged PR #24925:
URL: https://github.com/apache/flink/pull/24925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
jeyhunkarimov commented on PR #24725:
URL: https://github.com/apache/flink/pull/24725#issuecomment-2162579459
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
1996fanrui commented on code in PR #24881:
URL: https://github.com/apache/flink/pull/24881#discussion_r1636152962
##
flink-core/src/test/java/org/apache/flink/core/fs/InitOutputPathTest.java:
##
@@ -23,59 +23,52 @@
import org.apache.flink.core.fs.local.LocalFileSystem;
import
reswqa merged PR #24900:
URL: https://github.com/apache/flink/pull/24900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
gong commented on code in PR #3203:
URL: https://github.com/apache/flink-cdc/pull/3203#discussion_r1636249435
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/java/org/apache/flink/cdc/connectors/oracle/source/NewlyAddedTableITCase.java:
##
@@
elon-X commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1636303927
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -310,6 +310,53 @@ void testWatermarkAggregatorRando
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2162792331
Unless there are further comments I'm intended to merge it beginning of next
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
anupamaggarwal commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-2162795228
Hi @jeyhunkarimov thank you for contributing this PR!. Just wanted to check
if you were planning on working further on this, otherwise I'd be happy to
continue and address some of
dannycranmer commented on code in PR #24921:
URL: https://github.com/apache/flink/pull/24921#discussion_r1636357425
##
docs/setup_docs.sh:
##
@@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
integrate_connector_docs rabbitmq v3.0
integrate_connector_
pnowojski merged PR #24895:
URL: https://github.com/apache/flink/pull/24895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
pnowojski merged PR #24904:
URL: https://github.com/apache/flink/pull/24904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
snuyanzin commented on code in PR #24921:
URL: https://github.com/apache/flink/pull/24921#discussion_r1636362092
##
docs/setup_docs.sh:
##
@@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
integrate_connector_docs rabbitmq v3.0
integrate_connector_doc
pnowojski opened a new pull request, #24926:
URL: https://github.com/apache/flink/pull/24926
Simple documentation improvement.
## Verifying this change
N/A
## Does this pull request potentially affect one of the following parts:
N/A
## Documentation
flinkbot commented on PR #24926:
URL: https://github.com/apache/flink/pull/24926#issuecomment-2162942962
## CI report:
* b88ad00e20b5f2e76c3d7eb02c7adc3239faed8a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly closed pull request #24924: [FLINK-35570] Consider
PlaceholderStreamStateHandle in checkpoint file merging
URL: https://github.com/apache/flink/pull/24924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
rohimsh opened a new pull request, #24927:
URL: https://github.com/apache/flink/pull/24927
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them on
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636475673
##
pom.xml:
##
@@ -2371,6 +2371,11 @@ under the License.
org.apache.flink.util.function.SerializableF
twalthr commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1636474722
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDistribution.java:
##
@@ -70,17 +70,28 @@ public List getOperandList() {
@Overri
flinkbot commented on PR #24927:
URL: https://github.com/apache/flink/pull/24927#issuecomment-2163075264
## CI report:
* 658b68a6bb0f6227fa16f7e990ee67db64e471e9 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
MartijnVisser commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636516611
##
pom.xml:
##
@@ -2371,6 +2371,11 @@ under the License.
org.apache.flink.util.function.Serializa
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636561747
##
pom.xml:
##
@@ -2371,6 +2371,11 @@ under the License.
org.apache.flink.util.function.SerializableF
MartijnVisser commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636572746
##
pom.xml:
##
@@ -2371,6 +2371,11 @@ under the License.
org.apache.flink.util.function.Serializa
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636579070
##
pom.xml:
##
@@ -2371,6 +2371,11 @@ under the License.
org.apache.flink.util.function.SerializableF
jnh5y commented on code in PR #24886:
URL: https://github.com/apache/flink/pull/24886#discussion_r1636579991
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##
@@ -1361,16 +1374,36 @@ public void tes
MartijnVisser commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636585255
##
pom.xml:
##
@@ -2371,6 +2371,11 @@ under the License.
org.apache.flink.util.function.Serializa
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636591482
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -26,21 +26,18 @@ under the License.
# Pod template
-The operator CRD is designed to
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636591874
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -26,21 +26,18 @@ under the License.
# Pod template
-The operator CRD is designed to
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636593004
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -93,16 +90,18 @@ spec:
```
{{< hint info >}}
-When using the operator with Flink nati
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636593737
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}]
merged: [{name: a, p1: v
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provid
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provid
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636594307
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}]
merged: [{name: a, p1: v1,
caicancai commented on PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2163186911
@1996fanrui I'm very sorry for the late revision. I've been a bit busy
recently. I'll check it again tomorrow. You don't need to review it yet.
--
This is an automate
MartijnVisser commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636642416
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} pr
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provid
jeyhunkarimov commented on PR #24725:
URL: https://github.com/apache/flink/pull/24725#issuecomment-2163282560
Thanks a lot @reswqa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2163411240
@gaborgsomogyi Can this go in before the feature freeze on June 15?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
zoltar9264 opened a new pull request, #24928:
URL: https://github.com/apache/flink/pull/24928
## What is the purpose of the change
As title said, normalize file-merging sub dir, including subtask dir and
exclusive dir.
## Brief change log
*(for example:)*
- *The
flinkbot commented on PR #24928:
URL: https://github.com/apache/flink/pull/24928#issuecomment-2163701730
## CI report:
* a0719f7e58a3666e9ea39ce673c47a58679c38e6 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
mattayes commented on PR #837:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/837#issuecomment-2163720507
@gyfora Thanks for clarifying, I'll make the changes there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mattayes closed pull request #837: [hotfix] [docs] reference.md: Add missing
FlinkSessionJob CRD
URL: https://github.com/apache/flink-kubernetes-operator/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
MartijnVisser commented on PR #24805:
URL: https://github.com/apache/flink/pull/24805#issuecomment-2163842389
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ukby1234 closed pull request #24029: [FLINK-33759] [flink-parquet] Add support
for nested array with row type
URL: https://github.com/apache/flink/pull/24029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
jnh5y opened a new pull request, #24929:
URL: https://github.com/apache/flink/pull/24929
## What is the purpose of the change
Add documentation to cover FLIP-376.
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the fea
flinkbot commented on PR #24929:
URL: https://github.com/apache/flink/pull/24929#issuecomment-2163969225
## CI report:
* 401ad021195bca0d5329723dfb492760f4a147c8 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
lvyanquan opened a new pull request, #3413:
URL: https://github.com/apache/flink-cdc/pull/3413
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
reswqa closed pull request #24725: [FLINK-34977][API] Introduce State Access on
DataStream API V2
URL: https://github.com/apache/flink/pull/24725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
1996fanrui commented on PR #24881:
URL: https://github.com/apache/flink/pull/24881#issuecomment-2164197766
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
gong commented on PR #3203:
URL: https://github.com/apache/flink-cdc/pull/3203#issuecomment-2164201064
@leonardBang CI failure is not related to PR. Please help rerun CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongwoo6kim commented on PR #100:
URL:
https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2164206983
Thanks for confirming @morazow,
Please feel free to provide any additional advice before merging this fix.
It would be also helpful if you could elaborate more on t
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1637386871
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -310,6 +310,53 @@ void testWatermarkAggregatorR
elon-X commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1637436928
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -310,6 +310,53 @@ void testWatermarkAggregatorRando
ruanhang1993 opened a new pull request, #24930:
URL: https://github.com/apache/flink/pull/24930
## What is the purpose of the change
This pull request adds some notes about changes for flink-connector-base
dependency in externalized connectors.
## Brief change log
Add so
ruanhang1993 commented on PR #24930:
URL: https://github.com/apache/flink/pull/24930#issuecomment-2164284187
@rmetzger @leonardBang Would you like to help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
linmingze commented on PR #2494:
URL: https://github.com/apache/flink-cdc/pull/2494#issuecomment-2164291002
hello
en how about this fix going
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
flinkbot commented on PR #24930:
URL: https://github.com/apache/flink/pull/24930#issuecomment-2164316211
## CI report:
* ace19bbeee9cc5e5f8ecf784aa3ed5e55d073f7f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
whhe commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1637472845
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseEventSerializatio
Zakelly commented on code in PR #24928:
URL: https://github.com/apache/flink/pull/24928#discussion_r1637493879
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java:
##
@@ -31,12 +33,13 @@ public class Acro
SamBarker opened a new pull request, #24931:
URL: https://github.com/apache/flink/pull/24931
## What is the purpose of the change
Ensure that running `mvn clean verify` works for flink-clients (as is the
recommended step from [contributing to
flink](https://flink.apache.org/h
zoltar9264 commented on code in PR #24928:
URL: https://github.com/apache/flink/pull/24928#discussion_r1637586337
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java:
##
@@ -31,12 +33,13 @@ public class A
masteryhx closed pull request #24878: [FLINK-34482][checkpoint] Rename
checkpointing options
URL: https://github.com/apache/flink/pull/24878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
flinkbot commented on PR #24931:
URL: https://github.com/apache/flink/pull/24931#issuecomment-2164497999
## CI report:
* af743054861262cb5362528ff0e867717df16916 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
snuyanzin commented on code in PR #24921:
URL: https://github.com/apache/flink/pull/24921#discussion_r1637604401
##
docs/setup_docs.sh:
##
@@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
integrate_connector_docs rabbitmq v3.0
integrate_connector_doc
rkhachatryan commented on PR #24926:
URL: https://github.com/apache/flink/pull/24926#issuecomment-2164612236
LGTM
(please regenerate the documentation as CI suggests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
LadyForest commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1636497861
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##
@@ -124,6 +127,26 @@ public void t
1996fanrui commented on PR #24757:
URL: https://github.com/apache/flink/pull/24757#issuecomment-2164660806
@elon-X The CI fails, could you rebase the master branch first? We can
follow the CI after rebaseing.
--
This is an automated message from the Apache Git Service.
To respond to the m
1996fanrui merged PR #24881:
URL: https://github.com/apache/flink/pull/24881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
liyubin117 commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1637655816
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -342,6 +342,15 @@ public void alterCatalog(String catalog
liyubin117 commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1637666706
##
flink-table/flink-sql-client/src/test/resources/sql/catalog_database.q:
##
@@ -769,3 +769,28 @@ desc catalog extended cat2;
+-+--
liyubin117 commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1637667029
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##
@@ -124,6 +127,26 @@ public void t
thinker0 opened a new pull request, #94:
URL: https://github.com/apache/flink-connector-pulsar/pull/94
## Purpose of the change
*For example: Add dynamic sink topic support for Pulsar connector.*
## Brief change log
- *Change the internal design of `ProducerRegist
boring-cyborg[bot] commented on PR #94:
URL:
https://github.com/apache/flink-connector-pulsar/pull/94#issuecomment-2164765271
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2164843469
I'm fine with merging it on 14th of June EOB. Let's wait on other voices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1637750136
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Found
yuxiqian commented on PR #3083:
URL: https://github.com/apache/flink-cdc/pull/3083#issuecomment-2164936973
Seems there's some conflicts between `master` branch, could @loserwang1024
please rebase it when you're available?
--
This is an automated message from the Apache Git Service.
To res
101 - 200 of 53001 matches
Mail list logo
