fredia commented on code in PR #24924: URL: https://github.com/apache/flink/pull/24924#discussion_r1635853720
########## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ########## @@ -167,22 +166,25 @@ private void verifyStateHandleType(String checkpointPath, boolean fileMergingEna // Check keyed state handle List<KeyedStateHandle> keyedStateHandles = new ArrayList<>(subtaskState.getManagedKeyedState()); - keyedStateHandles.addAll(subtaskState.getRawKeyedState()); for (KeyedStateHandle keyedStateHandle : keyedStateHandles) { - Assertions.assertInstanceOf( - IncrementalRemoteKeyedStateHandle.class, keyedStateHandle); + assertThat(keyedStateHandle) Review Comment: IIUC, this bug can be reproduced if we perform several checkpoints before restoring to generate placeholder handle, would you like to change this ITCase to make it easier to reproduce? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org