[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2288 The associated issue for this can be found here: https://issues.apache.org/jira/browse/FLINK-4228. +1 to the points Stephan raised in his earlier comment. --- If your project is set up

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74742684 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -46,12 +47,13 @@ public void run

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74743009 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74743234 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74743269 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/HDFSCopyUtilitiesTest.java --- @@ -19,18 +19,18 @@ import

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74743303 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/HDFSCopyUtilitiesTest.java --- @@ -70,6 +70,85 @@ public void testCopyFromLocal

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74743404 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -255,4 +257,33 @@ private Utils() { } return result

[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2288 Thank you for contributing. All in all, this looks good and is an important fix. We would have to address the inline comments I've raised before merging it though. Do you have time to address

[GitHub] flink pull request #2141: [FLINK-4021] Problem of setting autoread for netty...

2016-08-15 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2141#discussion_r74760105 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandler.java --- @@ -292,7 +296,11 @@ else if

[GitHub] flink issue #2141: [FLINK-4021] Problem of setting autoread for netty channe...

2016-08-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2141 Very impressive that you made it through that part of the system. It's very poorly documented and overly complex. The change looks good and ensures that a staged buffer that cannot be decoded becau

[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2288 Thank you! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2075: [FLINK-3867] Provide Vagrant/Ansible based VMs to easily ...

2016-08-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2075 I agree. +1 to link in 3rd party packages if this is up to date and close this PR. What do you think @rmetzger and @jneuff? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893448 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893573 --- Diff: flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java --- @@ -88,4 +90,49 @@ private String typeParamToString(Class

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893581 --- Diff: flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java --- @@ -88,4 +90,49 @@ private String typeParamToString(Class

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74893687 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-16 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2371 Changes look good all in all. Could you also add a `org.apache.flink.util.Preconditions.checkNotNull` check for the backing config in the constructor? --- If your project is set up for it, you can

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74894098 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -178,14 +178,19 @@ public String toString

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-16 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2371 Thanks for addressing our comments! I'm going to merge this later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74901158 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java --- @@ -56,6 +57,7 @@ public DelegatingConfiguration

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r74918068 --- Diff: docs/setup/config.md --- @@ -285,7 +285,7 @@ of the JobManager, because the same ActorSystem is used. Its not possible to use ## High

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r74918209 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java --- @@ -77,7 +77,7 @@ /** * Shutdown hook thread to

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-16 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74961561 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink issue #2345: [FLINK-4340] Remove RocksDB Semi-Async Checkpoint Mode

2016-08-17 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2345 +1 to merge this. On a related note: we might want to add information to the checkpoint statistics part of the web frontend saying whether the checkpoints were async or sync. Users might get

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-17 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r75086582 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-17 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r75086698 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/HDFSCopyUtilitiesTest.java --- @@ -70,6 +70,85 @@ public void testCopyFromLocal

[GitHub] flink pull request #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-18 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2387 [FLINK-4317, FLIP-3] [docs] Restructure docs This is the initial layout for the docs restructuring as discussed in FLIP-3. We move the top level navigation to the left side and allow arbitrary

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-19 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2387 Yes, we still have to add content for the overview pages, in that case `apis.md`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #2385: FLINK-4322 (addendum)Issue with savepoint considering the...

2016-08-19 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2385 I will merge this and add the following test for min pause. This fails with the current master, but works with your PR. ```java /** * Tests that no minimum delay between savepoints is

[GitHub] flink issue #2141: [FLINK-4021] Problem of setting autoread for netty channe...

2016-08-19 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2141 I'm going to address the comments and merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-19 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2387 That was a bug. Fixed and updated preview. It's found under `Application Development` on the same level as `State Backends` etc. --- If your project is set up for it, you can reply to this emai

[GitHub] flink issue #2390: [FLINK-4431] [core] Introduce a "VisibleForTesting" annot...

2016-08-19 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2390 Makes sense +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-19 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2342 I will check this later today or on Monday. You will have to wait a little, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2399: [FLINK-4441] Make RocksDB backend return null on empty st...

2016-08-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2399 Related issue: https://issues.apache.org/jira/browse/FLINK-4445 Would appreciate your input on this Gyula. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2387 @aljoscha I will add some text to the overview pages. @tillrohrmann I will check out whether I can do it. It's certainly possible to do it, but we might need to do it as a follow up if I

[GitHub] flink pull request #2394: [FLINK-4434] [rpc] Add a testing RPC service.

2016-08-22 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2394#discussion_r75664816 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingRpcService.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

[GitHub] flink issue #2394: [FLINK-4434] [rpc] Add a testing RPC service.

2016-08-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2394 Cool stuff! Really looking forward to when this is merged back to `master` some day. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2342 I had to address some things when reviewing this: https://github.com/uce/flink/tree/ram In general the changes were good, but overlooked many occurrences that are not possible to catch with

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2387 I've addressed @aljoscha's and @jgrier's comments. @tillrohrmann I could not figure out how to do the centering in a different way, but I'm sure we (someone with more CSS skills) c

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-23 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2342 Builds are passing here: https://travis-ci.org/uce/flink/builds/154236174 I'm going to merge this later today. Thanks for starting this renaming. --- If your project is set up for it, yo

[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-23 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2288 Hey Cliff! I looked over this again and I think we have to address some things: - The problem you mentioned on the mailing list with respect to to flattening is actually something we should not

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105869850 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105898701 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105904946 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/AbstractStaticFileServerHandler.java --- @@ -0,0 +1,372

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105905806 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -183,6 +198,45 @@ class MemoryArchivist(private val

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105868354 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105906412 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/history/ArchivedJson.java --- @@ -27,6 +27,11 @@ * resembling the REST API

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105869478 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105907455 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -183,6 +198,45 @@ class MemoryArchivist(private val

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105878628 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala --- @@ -247,8 +248,11 @@ class LocalFlinkMiniCluster

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105868993 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105893041 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105899831 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105898348 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105893756 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105918260 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerStaticFileServerHandler.java --- @@ -0,0 +1,82

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105874859 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105876054 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105898216 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105876698 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105877694 --- Diff: flink-runtime-web/web-dashboard/app/index_hs.jade --- @@ -0,0 +1,60 @@ +// + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105870188 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105898278 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105875866 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105894483 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105894735 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105898166 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105906846 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerOptions.java --- @@ -32,6 +32,13 @@ public static final

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105918471 --- Diff: flink-runtime-web/web-dashboard/app/index_hs.jade --- @@ -0,0 +1,60 @@ +// + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105870285 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105897968 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105928423 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105929296 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105929511 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink issue #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3494 Thanks for this :-) It was interesting to follow your discussions @iemejia, @jgrier and @patricklucas. I've tried this out and it works as expected. I'm going to merge this later today if th

[GitHub] flink issue #3561: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3561 @aljoscha Could you have a brief look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3543: [FLINK-5985] [Backport for 1.2] Report no task states for...

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3543 Could you merge this @StefanRRichter? I think it is one of the last blockers for 1.2.1 and it's a pretty critical issue... --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOption is d...

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3552 Looking into #2680 that added this change, it was meant to be followed up on and move all web configuration to a new class. Could we do this here and not only a single one? --- If your project is set

[GitHub] flink pull request #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation c...

2017-03-20 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3572 [FLINK-6127] [checkstyle] Add MissingDeprecation check Adds the MissingDeprecation check to our set of checkstyle rules. Requires every `@Deprecated` annotation to have a `@deprecated` JavaDoc

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106901748 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/history/FsJobArchivist.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106903661 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,259

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900609 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,293 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900349 --- Diff: docs/monitoring/rest_api.md --- @@ -22,36 +22,69 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900686 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,293 @@ +/* + * Licensed to the

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900975 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,259

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106902557 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106948356 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,242

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106948899 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/history/FsJobArchivist.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation c...

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3572#discussion_r106942215 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateExpandDistinctAggregatesRule.java --- @@ -114,15 +114,21

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106949177 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,242

[GitHub] flink issue #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation check

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3572 Thanks for catching the unfortunate typo. I've fixed all of those. I left the confusing deprecation comment as is in the table API. I think this is good to merge then. --- If your proje

[GitHub] flink issue #3577: [FLINK-6133] fix build status in README.md

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3577 There is a discussion on the dev mailing list whether we want to have this or not. I would wait until that is resolved before continuing here. --- If your project is set up for it, you can reply to

[GitHub] flink issue #3583: [FLINK-6043] [web] Display exception timestamp

2017-03-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3583 Thanks for addressing the comments. I'm unsure about the `ErrorInfo` instead of adding the suggested method. Since @tillrohrmann and @StephanEwen often work on the `ExecutionGraph` I would like

[GitHub] flink pull request #3597: [FLINK-6170] [metrics] Don't rely on stats snapsho...

2017-03-22 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3597 [FLINK-6170] [metrics] Don't rely on stats snapshot for checkpoint metrics Some checkpoint metrics use the latest stats snapshot to get the returned metric value. In practice, this means that

[GitHub] flink issue #3597: [FLINK-6170] [metrics] Don't rely on stats snapshot for c...

2017-03-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3597 Thanks, will merge after Travis gives a green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #3606: [FLINK-6182] Fix possible NPE in SourceStreamTask

2017-03-24 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3606 [FLINK-6182] Fix possible NPE in SourceStreamTask A user ran into this and reported confusing NPEs in the logs. This could only happen if a source task is cancelled before it was invoked. You can

[GitHub] flink pull request #2783: [FLINK-5040] [jobmanager] Set correct input channe...

2016-11-10 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2783 [FLINK-5040] [jobmanager] Set correct input channel types with eager scheduling When we do eager deployment all intermediate stream/partition locations are already known when scheduling an

[GitHub] flink pull request #2784: [backport] [FLINK-5040] [jobmanager] Set correct i...

2016-11-10 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2784 [backport] [FLINK-5040] [jobmanager] Set correct input channel types with eager scheduling Backport of #2783 with no major differences. You can merge this pull request into a Git repository by running

[GitHub] flink pull request #2786: [FLINK-5016] [ci] Increase no output timeout to 10...

2016-11-11 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2786 [FLINK-5016] [ci] Increase no output timeout to 10 mins Some heavy test suites occasionally have quite long running times on Travis, in which cases the no output timeout of 5 mins is too aggressive and

[GitHub] flink pull request #2783: [FLINK-5040] [jobmanager] Set correct input channe...

2016-11-11 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/2783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   4   5   6   7   8   9   10   >