Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2288#discussion_r74743009
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
@@ -62,4 +64,34 @@ public void run() {
throw asyncException.f0;
}
}
+
+ /**
+ * Ensure that target path terminates with a new directory to be
created by fs. If remoteURI does not specify a new
+ * directory, append local directory name.
+ * @param fs
+ * @param localPath
+ * @param remoteURI
+ * @return
+ * @throws IOException
+ */
+ protected static URI checkInitialDirectory(final FileSystem fs,final
File localPath, final URI remoteURI) throws IOException {
--- End diff --
- Can you make this private or move the code to the `run` method?
- Can you add whitespace between the arguments, `FileSystem fs, File
localPath, URI remoteURI`?
- Can you make the arguments non-final?
- Can you complete the Javadocs?
Why do we need this check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
