Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2365#discussion_r74737756
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -25,33 +25,42 @@
import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2365#discussion_r74737803
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/messages/RemoteRpcInvocation.java
---
@@ -0,0 +1,187
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2365#discussion_r74737963
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -25,33 +25,42 @@
import
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2365
Thanks for the review @StephanEwen. I've addressed your comments. Once
Travis gives green light, I'll merge it.
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74768392
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74768700
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74768989
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74769608
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74769810
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74769869
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74770025
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2370
Thanks for you contribution @KurtYoung. Good work!
I only had some minor comments. Once they are addressed it's good to be
merged :-)
---
If your project is set up for it, yo
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2365
Somehow this PR was not closed automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/2365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2358
The stashing is a feature which comes for free with Akka. Of course the
sending side should not rely on this behaviour when implementing its failure
treatment. But in cases where we have a race
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74785154
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/AllocationID.java
---
@@ -0,0 +1,38 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2353#discussion_r74800246
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/TaskExecutorRegistrationResponse.java
---
@@ -0,0 +1,86
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2353#discussion_r74802315
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/ResourceManagerRegistration.java
---
@@ -0,0 +1,252
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2353#discussion_r74803435
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutorToResourceManagerConnection.java
---
@@ -0,0 +1,132
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2353
Really good code @StephanEwen :-) I like it a lot that you've pulled out
the registration logic from the `TaskExecutor`. This makes it much cleaner and
easier to test.
I'
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2370
Failing test cases are unrelated. Will merge this PR. Thanks for your
contribution @KurtYoung.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2371#discussion_r74893388
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java
---
@@ -178,14 +178,19 @@ public String toString
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2371
Thanks for your contribution @tsunny. Your changes look good. I only had a
minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2370
Not automatically closed by the asfgit bot. @KurtYoung could you close this
PR manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74937306
--- Diff: flink-dist/pom.xml ---
@@ -113,8 +113,13 @@ under the License.
flink-metrics-jmx
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74937890
--- Diff: flink-mesos/pom.xml ---
@@ -0,0 +1,294 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74938223
--- Diff: flink-mesos/pom.xml ---
@@ -0,0 +1,294 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74938631
--- Diff: flink-mesos/pom.xml ---
@@ -0,0 +1,294 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74940821
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/cli/FlinkMesosSessionCli.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74941466
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74941614
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74941852
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -0,0 +1,205
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74938853
--- Diff: flink-mesos/pom.xml ---
@@ -0,0 +1,294 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74947651
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74948586
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74948792
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74949114
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74947914
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74949669
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74948145
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74950002
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74950095
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74950716
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/2358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74963589
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74963941
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74964722
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74965913
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74971461
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74972631
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r74972977
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -0,0 +1,69
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75080549
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75080685
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java
---
@@ -0,0 +1,755
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75080823
--- Diff: flink-dist/pom.xml ---
@@ -113,8 +113,13 @@ under the License.
flink-metrics-jmx
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/commit/68addf39e0e5f9e1656818f923be362680ed93b0#commitcomment-18669730
Really nice abstraction @StephanEwen ð . I like it a lot :-)
---
If your project is set up for it, you can reply to this
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r7518
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -0,0 +1,618
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75113276
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerRunner.java
---
@@ -0,0 +1,117
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75113239
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerRunner.java
---
@@ -0,0 +1,117
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75113310
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerRunner.java
---
@@ -0,0 +1,117
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75113264
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerRunner.java
---
@@ -0,0 +1,117
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75114404
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75114471
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75114739
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75115154
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75115442
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75115525
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStore.java
---
@@ -0,0 +1,152
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75117043
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java
---
@@ -0,0 +1,290
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75119617
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java
---
@@ -0,0 +1,290
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75120223
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java
---
@@ -0,0 +1,290
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75120933
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/SchedulerProxy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75121105
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/SchedulerProxy.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75121439
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/messages/AcceptOffers.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75121525
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/messages/AcceptOffers.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75121852
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/messages/AcceptOffers.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75123394
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/messages/AcceptOffers.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75124552
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75124909
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75126761
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosConfiguration.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75126311
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75128222
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/ZooKeeperUtils.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75128299
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/ZooKeeperUtils.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75130862
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManager.scala
---
@@ -0,0 +1,65
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75131308
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManager.scala
---
@@ -0,0 +1,65
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75132701
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/ConnectionMonitor.scala
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75133244
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2381
Thanks for your contribution @wenlong88. The PR mixes multiple things
together. It would be better if you could separate these changes.
---
If your project is set up for it, you can reply to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2381#discussion_r75140948
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
---
@@ -197,11 +201,11 @@ public void stopService
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2381
Maybe it makes more sense to extends `RpcGateway` interface and offer a
getAddress method which returns the remote address of the gateway. We should
also add tests.
---
If your project is set
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75147221
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -0,0 +1,349 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75149938
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/Tasks.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75150474
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/Tasks.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75151735
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/runtime/clusterframework/ContaineredJobManager.scala
---
@@ -0,0 +1,174
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75156694
--- Diff: flink-mesos/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,32
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2315
Great work @EronWright. Code quality, testing and extent of this PR is
really impressive :-) I think you've nicely modularized the Mesos resource
manager with the additional actors. This
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2305
+1 for this approach.
On Thu, Aug 18, 2016 at 6:59 AM, Jark wrote:
> I'm ok with the with(...) approach. In addition, we should create a JIRA
> under
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75301960
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75302372
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,162 @@ public static JobExecutionResult
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75305261
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
@@ -198,10 +211,47 @@ else if (message instanceof
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75305767
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobInfo.scala
---
@@ -58,10 +62,63 @@ class JobInfo
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75307091
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java
---
@@ -100,13 +101,51 @@ public void
1 - 100 of 6586 matches
Mail list logo
