Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3579#discussion_r107069266
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -916,6 +916,10 @@ object
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3579
@twalthr, I saw you have removed the CHAR type when you merge this. Just
want to clarify. In FLINK-3916, in method typeInfoToSqlTypeName, you have added
```
case CHAR_TYPE_INFO
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3593#discussion_r107410682
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -201,14
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3593#discussion_r107410733
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MinAggFunctionWithRetract.scala
---
@@ -212,3
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3579
@twalthr thanks for the reply and explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3564#discussion_r107594707
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -162,6 +162,27 @@ abstract class
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3585#discussion_r107649062
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +397,24 @@ class
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3646
[FLINK-6216] [table] DataStream unbounded groupby aggregate with early
firing
1. Implemented an unbounded groupby aggregate with early firing (period is
1, emit per every record)
2
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3647
[FLINK-5915] [table] forward the entire aggregate ArgList to aggregate
runtime functions
This PR partially solved "FLINK-5915 Add support for the aggregate on multi
fields".
T
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3647
Thanks @fhueske, I overlooked a list is not always an arraylist. I change
it to scala array, but keep the type as integer, as this is type returned (and
not easy to be casted to Int) from
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3665
So we finally got those supported by Calcite 1.12ï¼Really excited to see
those features supported in flinkSQL. Thanks @haohui.
---
If your project is set up for it, you can reply to this
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3676
[FLINK-6241] [table] codeGen dataStream aggregates that use ProcessFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3646
@fhueske, thanks for your review. I have addressed all your comments, and
rebased the code to the master. Please take a look.
---
If your project is set up for it, you can reply to this
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3676
Thanks @fhueske, these changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3646#discussion_r110073336
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -299,27 +299,6
Github user shaoxuan-wang closed the pull request at:
https://github.com/apache/flink/pull/3646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3694
[FLINK-6240] [table] codeGen dataStream aggregates that use
AggregateAggFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3694#discussion_r110344806
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -403,6 +403,41 @@ class CodeGenerator
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3694#discussion_r110345902
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala
---
@@ -18,69 +18,51
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3696
@fhueske, thanks for the review and valuable comments.
Yes, we'd better add the attributes (which provide information for deriving
ACCMode) inside the DataStreamRel interface, such
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3694#discussion_r111813245
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -792,6 +792,20 @@ object
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3694
Thanks @fhueske , I have addressed your comments, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3735
[FLINK-6242] [table] Add code generation for DataSet Aggregates
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r111986331
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -36,6 +36,15
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3735
@fhueske thanks for your feedback.
Yes, we could keep GeneratedAggregations interface very clean as
```
abstract class GeneratedAggregations extends Function {
def
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3735
@fhueske , your changes look good to me, I left a few comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3762
[FLINK-6361] [table] Refactoring the AggregateFunction interface and
built-in aggregates
This PR includes the following changes:
1) remove Accumulator trait;
2) move accumulate
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3762
Hi @fhueske , it is good to have a dedicated Iterable for pair-merge.
Please go ahead. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3768
I ran into the same problem today when adding the new test cases for UDAGG.
Thanks for the fix, @xccui
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3809
[FLINK-5906] [table] Add support to register UDAGG in Table and SQL API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3809
Thanks for the review, @fhueske , and very good point regarding to the
approach to "replace UDAGGFunctionCall". I have addressed your comments. Please
take a look.
---
If your proj
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114498337
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/DStreamUDAGGITCase.scala
---
@@ -0,0 +1,309
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114571910
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -327,4 +332,56 @@ object
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114576600
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,24 @@ class
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114579772
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/DSetUDAGGITCase.scala
---
@@ -0,0 +1,192
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114690845
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
---
@@ -130,3 +142,63 @@ case class Avg
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114692276
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala
---
@@ -0,0 +1,177
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114692346
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala
---
@@ -0,0 +1,177
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/2653
Jack,
Giving this for the second thought, I feel we can just use LATERAL and
INNER/LEFT JOIN (which is already supported by Calcite) instead of
introducing "CROSS/OUTER APPLY&q
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3354
[FLINK-5767] [Table] New aggregate function interface and built-in
aggregate functions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3354
The travis-ci test build failed as it hits the Travis 50 min limit: "The
job exceeded the maximum time limit for jobs, and has been terminated". Robert
has a fix for this FLINK-
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102606570
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/builtInAggFuncs/SumAggFunction.scala
---
@@ -0,0 +1,146
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3354
@fhueske thanks for the review. I agree with you that we should provide
more specific types for the accumulators (backend state). I will update code
today to address all your comments
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3405
[FLINK-5899] [table] Fix the bug in EventTimeTumblingWindow for
non-partialMerge aggregate
I have changed the supportPartial to false for all built-in Aggregates, and
run all the UTs
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3423
[FLINK-5768] [table] Apply new aggregation functions for datastream and
dataset tables
This PR includes the following changes:
1. Change the implementation of the DataStream aggregation
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3423
I think we could further remove AggregateMapFunction and
DataSetWindowAggregateMapFunction for windowedDataSet and DataSet, and let
reduce function directly accumulator the input values. But
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3423
@fhueske thanks for the review. I completely agree with your suggestion on
"reworking the batch design". Actually I have proposed the same idea to
"rework the batch"
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103673820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala
---
@@ -0,0 +1,101
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103674711
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala
---
@@ -0,0 +1,101
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103674994
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala
---
@@ -0,0 +1,101
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3423
Thanks @fhueske , I updated the PR which has limited the batch merge to 16
rows, please take a look. This PR is primarily dedicated to change the
dataStream and DataSet to use new aggregate
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103834968
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateReduceGroupFunction.scala
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103835523
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -54,31 +58,31 @@ object
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103839943
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -363,199 +342,112 @@ object
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103883798
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -737,101 +632,121 @@ object
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3423
@fhueske Thanks for the detailed review. I have addressed all your
comments. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103885054
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -737,101 +632,121 @@ object
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3423
@fhueske I pushed a commit. Please take a look. Please note that this PR
will close both FLINK5768 and FLINK5769. Thanks!
---
If your project is set up for it, you can reply to this email and
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3464
[FLINK-5955] [table] Merging a list of buffered records will have problem
when ObjectReuse is turned on
This PR changes the dataSet AGG merge to pair-merge.
If we buffer the
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r104096189
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3465
[FLINK-5927] [table] Remove old Aggregate interface and built-in functions
This PR deprecate and remove the old Aggregate interface, built-in
functions, and associated Agg functions
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3470
[FLINK-5956] [table] Add retract method for aggregateFunction
This PR adds retraction method for AggregateFunction, it also implements
retract methods as well as test cases for all built-in
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3470
@fhueske, we should add different built-in aggregates for the ones that are
not easy to be retracted (for instance Max and Min), one as withRetract(used
for over window as # of items are
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104282131
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala
---
@@ -87,47 +89,67 @@ class
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3470
@fhueske sounds great. I updated the PR. Please take a look. I have add
non-retractable and retractable aggregates for MIN and MAX. And add a flag
parameter via
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104300989
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301022
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -137,6 +146,15
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301092
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -0,0 +1,205
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301147
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -0,0 +1,205
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301172
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -23,10 +23,11
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301312
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -49,13 +50,25
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104301347
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -36,14 +36,23
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104302135
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -36,14 +36,23
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104303912
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -49,13 +50,25
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104303999
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104304057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104304129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -137,6 +146,15
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3470
@fhueske Thanks for the review. I have addressed all your comments and
updated the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user shaoxuan-wang closed the pull request at:
https://github.com/apache/flink/pull/3464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3464
Sure @fhueske, this PR is closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104413472
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -72,37
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104413666
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
---
@@ -115,12
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104411239
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -321,12 +317,11
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3496
[FLINK-5984] [table] add resetAccumulator method for AggregateFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3496
@fhueske , do you have plan to merge FLINK-5983 and FLINK-5963 very soon?
This PR probably need rebase once your two PRs are merged, as changes are
overlapped.
---
If your project is set up
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3046#discussion_r95219196
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -785,13 +793,19 @@ class Table(
* will be
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3046#discussion_r95244683
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/windows.scala
---
@@ -150,7 +147,7 @@ class TumblingWindow(size
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3141
@wuchong @lincoln-lil , I do not think this is just for 1.2.0. The out join
with non equality functionality is broken on master. We should deliver this fix
to the master as well as release
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3186#discussion_r97226914
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/AggregateFunction.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3186#discussion_r97226958
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/AggregateFunction.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3186#discussion_r97246135
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/AggregateFunction.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r140951770
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,93
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3923
@twalthr, it seems we have reserved the keyword with the case insensitive.
For instance, we cannot use "Sum" and "SUM", as "sum" is reserved. Did we
intent t
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3993
[FLINK-6725][table] make requiresOver as a contracted method in udagg
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3993
Thanks for the review @fhueske @sunjincheng121 .
Fabian, yes, I do not think this will be a blocker for release. In fact,
this is a similar interface clean-up issue as FLINK-6457 that we
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/4546
[FLINK-6751] [docs] Add missing documentation for User-Defined Functions
Page
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink
Github user shaoxuan-wang closed the pull request at:
https://github.com/apache/flink/pull/3993
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3993
@fhueske @sunjincheng121 @wuchong, thanks for the valuable inputs. We
talked offline and get an agreement that we'd better to put
`getAccumulatorType()`, `getResultType()` et
Shaoxuan Wang created FLINK-6047:
Summary: Master Jira for "Retraction for Flink Streaming"
Key: FLINK-6047
URL: https://issues.apache.org/jira/browse/FLINK-6047
Project: Flink
Shaoxuan Wang created FLINK-6089:
Summary: Implement decoration phase for rewriting predicated
logical plan after volcano optimization phase
Key: FLINK-6089
URL: https://issues.apache.org/jira/browse/FLINK-6089
1 - 100 of 215 matches
Mail list logo
