GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3550
[FLINK-5654] - Add processing time OVER RANGE BETWEEN x PRECEDING
aggregation to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@fhueske @shaoxuan-wang @twalthr @wuchong @shijinkui
I re-implemented the time bounded window aggregates in scala. Can you
please take a look and merge it. Thanks
---
If your project is set
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106363300
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106363331
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106405078
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106405327
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
I have updated the code based on the review. @hongyuhong - thank you very
much for the review
@fhueske @twalthr - can you take a look and check if you can merge it
please
---
If your project
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106409879
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106611866
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106613652
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106614204
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106613249
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -136,13 +229,13
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106614631
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106613551
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106615434
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverAllWindowFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106615587
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverAllWindowFunction.scala
---
@@ -0,0
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@fhueske - can you please take a look over
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@shijinkui thank you for the remarks. I have addressed them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106658506
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106659524
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,6 +137,10
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106659962
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,66
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106658350
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r10656
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,66
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106667006
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@fhueske
"It would also be good if you could remove the merge commit from the PR
branch. Merge commits make it much harder to squash commits and merge them to
the master b
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106669122
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106672193
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106688280
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106688499
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@fhueske - Thank you very much for your review. It was very useful. I
integrated and addressed most of the remarks you made.
What remains to be discussed and it is not addressed is:
-using
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3502
I have opened an architecture design about how these can be implemented
FLINK-6077 - https://issues.apache.org/jira/browse/FLINK-6077?filter=-2
You can take a look at this as well
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3550
@fhueske @twalthr - I am not sure if you saw the updates last Friday with
all the things that are going on :)
If you have a chance to look over it would be great - I would like to merge
and
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107184664
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107264081
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107274117
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3590
[FLINK-5654] - Add processing time OVER RANGE BETWEEN x PRECEDING
aggregation to SQL
function
Added corresponding tests
Thanks for contributing to Apache Flink. Before you open your
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske @shijinkui @hongyuhong @twalthr @stefanobortoli
I have reimplemented the OVER logic with time bounds over processfunction.
PLease take a look
I also addressed in principle the
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107401146
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107402043
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107402759
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107403016
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107404646
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske Thanks for the review. Before i start to do the updates please
have a look on my remarks. I think we need to clarify some things - particular
the access to the state of the events - it
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107409919
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107417210
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107430992
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107437607
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107440866
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedNonPartitionedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107516906
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107518499
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107518911
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107519046
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -29,6 +29,60 @@ class
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107517633
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107604793
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107604045
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107605079
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107605260
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske @sunjincheng121
I have done another commit (actually i did it last evening but the network
of the machine was down and did not push it). What i did was:
1)address the formatting
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107616671
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107618097
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske
Now what?...reimplementation again or it is ok to keep this in this
way...at least for us/our scenarios it would make sense like this
Also are you doing a review?
---
If your
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107664558
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske
I tried before to use the
WindowOperatorTest#testProcessingTimeTumblingWindows() controls processing time
using the KeyedOneInputStreamOperatorTestHarness but i did not find the
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107692869
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +317,92 @@ class SqlITCase
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3590#discussion_r107695656
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +150,57
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3607
[FLINK-5654] - Add processing time OVER RANGE BETWEEN x PRECEDING
aggregation to SQL
processing time with MapState for event handling
Thanks for contributing to Apache Flink. Before you
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
@fhueske @sunjincheng121 @stefanobortoli
I have made an implementation also for implementing the management of the
events in the buffer based on MapState as suggested in #3590
I also
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske @sunjincheng121 @hongyuhong @stefanobortoli
I have run a test to compare the 3 approaches:
-windows based #3550
-processfunction based with events managed in ValueState
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3609
Inner query implementation model
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3609
@fhueske @twalthr @sunjincheng121 @shijinkui @stefanobortoli @hongyuhong
I have made a first implementation draft for supporting inner queries
mainly when operating on processing time. I
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
Hi @aljoscha sorry for not being more clear in presenting the benchamrk
/evaluation - i used in-memory state backend (for us the key scenario is to
support high performance so that is why i
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3609#discussion_r108062687
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,241
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
@sunjincheng121 i will take a look - although the branch was created
friday morning - there should not be any conflicts or anything...
---
If your project is set up for it, you can reply to this
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3590
@fhueske thanks Fabian for the note. I will do a rebase today on the PR as
there was apparently a merge of the retraction support. I will also try to
enhance the tests. Hopefully by tomorrow there
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
@sunjincheng121 @fhueske @stefanobortoli
I rebased and created the tests. Please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
@sunjincheng121 - Apperently there were many conflicts...most of them were
stupid conflicts when git was trying to do the automatic merging.
At least in 2 classes the methods you added and the
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
@sunjincheng121 i actually saw now that there are 64 files changed ...these
is definitely due to the rebase...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
@sunjincheng121 @fhueske
Of course i understand and work on the last master branch when starting an
implementation ...as mentioned the initial commit that was done friday evening
had the
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3641
[FLINK-5654] - Add processing time OVER RANGE BETWEEN x PRECEDING
aggregation to SQL
Added tests based on harness util framework
Thanks for contributing to Apache Flink. Before you open
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3641
@sunjincheng121 @fhueske
In order to revert the mess after the rebase that contained other comits, i
have reopened the PR.
I will close the previous one. Please consider this. It is the
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/3607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3607
I have reopened this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108715233
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -274,6 +286,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108715515
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1208,5 +1208,40 @@ object
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108716153
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108716511
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108717176
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -19,7 +19,10 @@
package
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108717425
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -696,6 +716,205 @@ class SqlITCase
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108717894
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -140,6 +140,20 @@ under the License.
${project.version
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3641
@sunjincheng121 - thanks for the review. I addressed most of the comments.
@fhueske
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108856359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -274,6 +286,57
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108856694
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108857410
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1208,5 +1208,40 @@ object
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108862890
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108863010
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108865827
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108866308
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108871122
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3641#discussion_r108871599
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -696,6 +713,205 @@ class SqlITCase
Github user rtudoran commented on the pull request:
https://github.com/apache/flink/commit/d4665a00a4262f89b166895f73a54daab2f25e1c#commitcomment-21554770
In
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala:
In
1 - 100 of 222 matches
Mail list logo
