Github user rtudoran commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3641#discussion_r108856694
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala
 ---
    @@ -0,0 +1,169 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.runtime.aggregate
    +
    +import org.apache.flink.api.common.state.{ ListState, ListStateDescriptor }
    +import org.apache.flink.api.java.typeutils.RowTypeInfo
    +import org.apache.flink.configuration.Configuration
    +import org.apache.flink.runtime.state.{ FunctionInitializationContext, 
FunctionSnapshotContext }
    +import org.apache.flink.streaming.api.functions.ProcessFunction
    +import org.apache.flink.table.functions.{ Accumulator, AggregateFunction }
    +import org.apache.flink.types.Row
    +import org.apache.flink.util.{ Collector, Preconditions }
    +import org.apache.flink.api.common.state.ValueState
    +import org.apache.flink.api.common.state.ValueStateDescriptor
    +import scala.util.control.Breaks._
    +import org.apache.flink.api.java.tuple.{ Tuple2 => JTuple2 }
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo
    +import org.apache.flink.api.java.typeutils.TupleTypeInfo
    +import scala.collection.mutable.Queue
    +import org.apache.flink.api.common.typeinfo.TypeHint
    +import org.apache.flink.api.common.state.MapState
    +import org.apache.flink.api.common.state.MapStateDescriptor
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.typeutils.ListTypeInfo
    +import java.util.{ ArrayList, LinkedList, List => JList }
    +
    +/**
    + * Process Function used for the aggregate in partitioned bounded windows 
in
    + * [[org.apache.flink.streaming.api.datastream.DataStream]]
    + *
    + * @param aggregates the list of all 
[[org.apache.flink.table.functions.AggregateFunction]]
    + *                   used for this aggregation
    + * @param aggFields  the position (in the input Row) of the input value 
for each aggregate
    + * @param forwardedFieldCount Is used to indicate fields in the current 
element to forward
    + * @param rowTypeInfo Is used to indicate the field schema
    + * @param timeBoundary Is used to indicate the processing time boundaries
    + * @param inputType It is used to mark the Row type of the input
    + */
    +class ProcTimeBoundedProcessingOverProcessFunction(
    +  private val aggregates: Array[AggregateFunction[_]],
    +  private val aggFields: Array[Int],
    +  private val forwardedFieldCount: Int,
    +  private val rowTypeInfo: RowTypeInfo,
    +  private val timeBoundary: Long,
    --- End diff --
    
    precedingTimeBoundary seems to be the combination of the 3 opinions :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to