GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2367
[FLINK-3703][cep] Add sequence matching semantics to discard matched events
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74698003
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74698018
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2289
Hi @rmetzger, Thank you for helping with this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74701625
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74701671
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -590,7 +592,7 @@ class Table(
.map(field
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74701669
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@wuchong @twalthr I've updated the PR according to your review. Could you
please review it one more time?
---
If your project is set up for it, you can reply to this email and have your
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74704156
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74705587
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -592,7 +592,7 @@ class Table(
.map(field
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
I removed fieldNames and fieldTypes from the constructor arguments and rely
on **configure** method. Because of that I had to add an additional method for
create serialization scheme in sub
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@wuchong
Tests passed on most platforms, and failures do not seem to be related to
code that added/changed:
```
java.lang.IllegalStateException: cannot create children while
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74723595
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
@@ -68,12 +68,16 @@ class FlinkPlannerImpl
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74723604
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
@@ -85,23 +89,27 @@ class FlinkPlannerImpl
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2374
[FLINK-3950] Add Meter Metric Type
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2367#discussion_r74837056
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -26,6 +26,7 @@
import
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Thank you for your detailed review. I'll update the PR today or
tomorrow.
Despite of the fact that this connector will probably moved to Bahir it
would make sense to make sure
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
>> Did you test the code on a cluster?
I tested it using the test ActiveMQ server (via an integration test), but I
can also test it using an ActiveMQ cluster.
>> Were t
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r74839402
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java
---
@@ -0,0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r74841557
--- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r74841591
--- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Hi @zentol
Thank you for your prompt review.
Sorry, I was not aware that there is Metrics documentation. I'll update the
PR today.
---
If your project is set up for it, you can rep
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75010826
--- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75010803
--- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75011140
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java
---
@@ -0,0 +1,155
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75011407
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java
---
@@ -0,0 +1,155
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75011452
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java
---
@@ -0,0 +1,155
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75011941
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java
---
@@ -0,0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75011880
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java
---
@@ -0,0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75024557
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java
---
@@ -0,0 +1,155
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger I've updated the PR according to your review. Could you please
take another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
@zentol Thank you for reviewing my PR! I'll fix these issues as soon as I
can.
On the metrics interface. Could you please elaborate why do you think
exponentially weighted rate a
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75091316
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java
---
@@ -0,0
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger About the "job jar". Could you suggest how to check this? Is
there anything I should do except performing "mvn clean install"?
---
If your project is set up for
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger About moving to bahir. Would you (or someone else) merge this
into Apache Flink and them move this code with other connectors, or should I
create another PR with the AMQ connector for
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Thank you for detailed instructions. I'll check this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Hi @zentol I've updated the PR according to your suggestions.
About the Meter interface I think we can make it more flexible in two ways:
* Update Meter to support variable numb
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r75260223
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/util/TestMeter.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@twalthr @wuchong
Could you please review one more time? This PR is blocking another similar
PR.
The test failure does not seem to have anything to do with the new code.
---
If your
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm @zentol @kl0u Could you please give it another review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger I performed the check as you described and everything seems to be
fine.
I also updated the PR according to your suggestions.
Is this commit in a good shape to merge it?
---
If
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@wuchong I've removed the test as you've suggested since it pretty much
duplicates `TableSinkITCase`.
---
If your project is set up for it, you can reply to this email and have your
re
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@twalthr Could you review this one more time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2289
@fhueske Thank you for your review!
Could you please merge it? I don't have write permissions.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2367
@tillrohrmann Thank you for the very detailed review. I do appreciate it.
I agree with your suggestions and I'll try to improve the code and write
documentation in the next couple of
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2367
Hi @tillrohrmann
I've updated the PR according to your review. I had to add reverse reverse
edges to buffer entries and changed the interface of the SharedBuffer a bit to
move code from
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2396
[FLINK-4395][cep] Eager processing of late arrivals in CEP operator
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2398
[gelly] Add Vertex.create and Edge.create helper methods
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2398
Added helper methods to make Gelly API more concise.
Now one can write this:
```
Vertex v = Vertex.create(42);
Edge e = Edge.create(5, 6);
```
Instead of this
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2398
Hi @vasia
I've created a JIRA issue for the pull request.
What do you think about this change?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75667574
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/internal/AMQExceptionListener.java
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
> One more thing: Let me know if you don't like to do the migration to
Bahir. I understand that this is a bit annoying and our fault. I can also do
the migration if you want.
@rm
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Please open a PR yourself.
Sorry for confusing you.
Would it make sense to address your comment first though?
---
If your project is set up for it, you can reply to this email
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Thank you for your help. I'll try to make the change today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
Hi @fhueske. Thank you for your code review. I'll update the PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2289
Thank you for your help @fhueske!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938408
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSink.scala
---
@@ -41,46 +38,13 @@ trait TableSink[T
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938654
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938617
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -26,6 +26,8 @@ import
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938632
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938748
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka09JsonTableSink.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938768
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka09JsonTableSink.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938899
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSinkTest.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938937
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka09JsonTableSinkTest.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938953
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -0,0
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938972
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75939007
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75938989
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/JsonRowSerializationSchemaTest.java
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
Hi @fhueske, I am running `mvn clean verify` locally right now and I hope
to update the commit soon.
Sorry for confusing you.
---
If your project is set up for it, you can reply to this
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@fhueske I've fixed the PR according to your review.
The only thing that I didn't do is reusing `ObjectNode` on every iteration.
It caused some weird NPEs during the integration test
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r76053759
--- Diff: docs/apis/metrics.md ---
@@ -157,6 +157,55 @@ public class MyMapper extends RichMapFunction {
}
{% endhighlight %}
+ Meter
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r76053776
--- Diff: docs/apis/metrics.md ---
@@ -157,6 +157,55 @@ public class MyMapper extends RichMapFunction {
}
{% endhighlight %}
+ Meter
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
This PR was not reviewed in the last 21 days. Could someone please review
it? It should be in a good shape at this stage.
---
If your project is set up for it, you can reply to this email and
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm Sorry for reminding you. I just thought that everybody forgot about
this PR at some point :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
@zentol What do you think about the proposed Meter interface? Should I
update my PR accordingly? Do you have other ideas?
---
If your project is set up for it, you can reply to this email and
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
Thank you for your review @fhueske. I've updated it. Could you please take
a look at it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76148725
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/DefaultFilterTest.java
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76148802
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -314,43 +299,95 @@ public void
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76148927
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm Thank you for the review. I've updated PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r76217714
--- Diff: docs/apis/metrics.md ---
@@ -157,6 +157,55 @@ public class MyMapper extends RichMapFunction {
}
{% endhighlight %}
+ Meter
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Thank you for explanation @zentol.
If we go with 1 minute rate, what do we do with the 5min and 15min rate in
the Dropwizard wrapper? Do we return zeros for non-supported rates or would you
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm Thank you for your reviews and for merging this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
0, seems more reasonable to me (sort of no-data).
I'll update the PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
Thank you for helping with this PR @fhueske
It's ok, I'll update the PR in an hour or so.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
Hey @fhueske
I've renamed tests as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
@zentol I've updated Meter's interface. Could you give this PR another
review?
Sorry for the force push, I had to rebase on top of `master` to resolve
merge conflict.
---
If your
Github user mushketyk commented on the pull request:
https://github.com/apache/flink/commit/abb4496781883937a935113c1e33ae1174aafa73#commitcomment-18789946
Hi Stephan.
I think you are right.
I'll update the testing as soon as possible and create a different PR to
ad
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2361
Could someone please take a look at this PR? It has been here without a
review for more than 2 weeks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm @aljoscha @StephanEwen Thank you for your comments. Seems like this is
sorted out :)
I'll remove Guava calls today at the evening.
---
If your project is set up for it, you can rep
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2426
[FLINK-3677] Remove Guava dependency from flink-core
Removed Guava dependency from flink-core as discussed here:
https://github.com/apache/flink/pull/2109
- [x] General
- The pull
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Hey @zentol. Thank you for your comments.
I've updated the PR. Could you take a look at it again?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2398
Closing according to discussion in JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mushketyk closed the pull request at:
https://github.com/apache/flink/pull/2398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2430
[FLINK-3874] Rewrite Kafka JSON Table sink tests
Turned Kafka JSON Table sink tests into unit tests as discussed here:
https://issues.apache.org/jira/browse/FLINK-3874
- [x] General
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2431
[FLINK-4521] Fix "Submit new Job" panel in development mode
Submit panel was completely empty in the development mode. This happened
because client-side code sent AJAX requests to a d
Github user mushketyk closed the pull request at:
https://github.com/apache/flink/pull/2426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2426
Already merged. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2426
@mxm Sure :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2418#discussion_r76802305
--- Diff:
flink-metrics/flink-metrics-jmx/src/main/java/org/apache/flink/metrics/jmx/JMXReporter.java
---
@@ -143,23 +144,27 @@ public int getPort
1 - 100 of 518 matches
Mail list logo
