Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2418#discussion_r76802305
--- Diff:
flink-metrics/flink-metrics-jmx/src/main/java/org/apache/flink/metrics/jmx/JMXReporter.java
---
@@ -143,23 +144,27 @@ public int getPort() {
@Override
public void notifyOfAddedMetric(Metric metric, String metricName,
MetricGroup group) {
- final String name = generateJmxName(metricName,
group.getScopeComponents());
+ final Hashtable<String, String> table =
generateJmxTable(metricName, group.getAllVariables());
--- End diff --
Out of curiosity. Why do we use Hashtable instead of HashMap?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
