GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2415
[FLINK-4407] Implement the trigger DSL
This PR implements the Trigger DSL as presented in
[FLIP-9](https://cwiki.apache.org/confluence/display/FLINK/FLIP-9%3A+Trigger+DSL)
with the addition of
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2434
[FLINK-4496] Refactor the TimeServiceProvider to take a Trigerable inâ¦
This is a first step towards
https://issues.apache.org/jira/browse/FLINK-4329
R: @aljoscha @rmetzger
You can merge
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2446
[hotfix] Fixes unstable ContinuousFileMonitoringTest.
R: @aljoscha
Please review. This is a fix to the unstable test shown here:
https://s3.amazonaws.com/archive.travis-ci.org/jobs
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2446
Thanks a lot @aljoscha !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r79390766
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/OneInputStreamOperatorTestHarness.java
---
@@ -98,7 +99,7 @@ public
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2434
R: @mxm @aljoscha @rmetzger
This is ready for review.
Thanks a lot for the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2532
[FLINK-4494] Expose the TimeServiceProvider from the Task to each Operator.
This is a PR for both [FLINK-4496] and [FLINK-4494].
R: @aljoscha
You can merge this pull request into a Git repository
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2434
Thanks @mxm and @aljoscha !
I already have the followup on this open here:
https://github.com/apache/flink/pull/2532
---
If your project is set up for it, you can reply to this email and have
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2532
Yes. Thanks a lot @aljoscha !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2434
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3501
[FLINK-5874] Restrict key types in the DataStream API.
Rejects a type from being a key in `DataStream.keyBy()` if it is:
1. it is a POJO type but does not override the `hashCode()` and
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105225561
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -419,6 +435,14 @@ public void
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3477
Hi @dawidwys , I will do this in the beginning of next week at the latest.
One thing that I saw is that in the `Pattern` class you do not check for
conflicting configurations e.g. oneToMany
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105377617
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java
---
@@ -736,7 +736,7 @@ public void restoreState(List state
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105377853
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -114,9 +121,53 @@ public KeyedStream(DataStream
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105377789
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -114,9 +121,53 @@ public KeyedStream(DataStream
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105378808
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java
---
@@ -906,6 +919,256 @@ public void testChannelSelectors
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105378932
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java
---
@@ -906,6 +919,256 @@ public void testChannelSelectors
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105380399
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java
---
@@ -906,6 +919,256 @@ public void testChannelSelectors
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3501
Thanks for the thorough review @zentol . I integrated the comments that I
agree with and commented on the rest. If you agree with the changes, I can
merge it.
---
If your project is set up for it
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105399939
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
---
@@ -72,6 +76,11 @@ public RecordWriterOutput
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105397424
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105398138
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java
---
@@ -17,13 +17,19
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105402678
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -1393,14 +1428,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105401947
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -539,5 +625,26 @@ public void collect
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105400890
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -326,33 +327,48 @@ public int getChainLength
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105402830
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -1618,14 +1664,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105402616
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -1267,14 +1291,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105397483
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105402899
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -1702,15 +1754,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105398702
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -333,32 +356,40 @@ public void addEdge(Integer
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105403240
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/CollectorOutput.java
---
@@ -53,5 +54,11 @@ public void collect(StreamRecord
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105402262
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -539,5 +625,26 @@ public void collect
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105397096
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeHint.java ---
@@ -46,7 +46,15 @@
public TypeHint
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105397933
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105401503
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -387,14 +403,25 @@ public int getChainLength
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105407208
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java
---
@@ -906,6 +919,256 @@ public void testChannelSelectors
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3501
Done! Let me know if you have any additional comments @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105399457
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SideOutputTransformation.java
---
@@ -0,0 +1,72
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105397306
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105403355
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/MockOutput.java
---
@@ -40,6 +41,12 @@ public void collect(StreamRecord record
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105401808
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -441,26 +491,55 @@ public void close
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105402746
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -1528,14 +1572,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105398836
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
---
@@ -300,6 +303,36 @@ private StreamGraph
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105441679
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3513
[hotfix] [doc] Fix error in ProcessFunction example.
Fixes an error in the `ProcessFunction` documentation that was reported in
the mailing list.
You can merge this pull request into a Git repository
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3514
[FLINK-6007] Allow key removal from within the watermark callback.
When deleting a key from the InternalWatermarkCallbackService, the
deleted key is put into a separate set, and the actual deletion
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3484
Thanks @aljoscha I will have a look on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3445
@aljoscha , I integrated your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3477
Hi @dawidwys , I will start reviewing your PR now.
I would say that for now it makes sense to have it with exceptions and not
change the `Pattern` hierarchy. The reason is:
1) not sure
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3514
Thanks for the review @aljoscha . Waiting for travis and then merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3514#discussion_r105649773
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java
---
@@ -58,7 +59,17
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105701064
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -217,23 +217,22 @@ public void prune(long pruningTimestamp
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700356
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105701669
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
@@ -55,6 +65,7 @@ public boolean equals(Object obj
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105702323
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java
---
@@ -18,9 +18,13 @@
package
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105698626
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -209,33 +204,66 @@ public boolean equals(Object obj
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105698031
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -71,19 +70,16 @@
private final NonDuplicatingTypeSerializer
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704335
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105699441
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -209,33 +204,66 @@ public boolean equals(Object obj
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105697452
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -41,8 +43,11 @@
// Timestamp of the first
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105698150
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -71,19 +70,16 @@
private final NonDuplicatingTypeSerializer
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105697591
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -52,14 +57,35 @@ public ComputationState
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105702140
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/InvalidPatternException.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105699655
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704267
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105699988
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700500
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704530
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704399
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105702715
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700521
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700201
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r105707379
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTest.java
---
@@ -75,9 +94,15 @@ public void
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/3514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3514
Merged at 14c1941d8eaa583eb8f7eeb5478e605850c0d355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3477
Thanks @dawidwys I will have a look now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3445
Thanks for the comments @aljoscha . I integrated them and I updated
https://issues.apache.org/jira/browse/FLINK-5969 to keep track.
---
If your project is set up for it, you can reply to this email
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3477
Hi @dawidwys , the following produces no output, which should not be the
case. The same holds if you change the pattern to `oneOrMore`.
```
public void testZeroOrMore
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106106765
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108080
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108841
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106107383
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108473
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106109112
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -74,11 +80,35 @@ public long getStartTimestamp
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106107521
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108553
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3541
[FLINK-6032] [cep] Clean-up operator state when not needed.
The CEP operator now cleans the registered state for a key. This happens:
1) for the priority queue, when the queue is empty.
2) for
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3541#discussion_r106133528
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java
---
@@ -153,6 +153,7 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106139449
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -387,18 +401,49 @@ public int getChainLength
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106138062
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106139311
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -326,33 +327,46 @@ public int getChainLength
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106138342
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/SingleOutputStreamOperator.java
---
@@ -416,4 +428,26 @@ private
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106139079
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -567,6 +600,17 @@ protected
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106138895
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SideOutputTransformation.java
---
@@ -0,0 +1,73
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106138237
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/SingleOutputStreamOperator.java
---
@@ -416,4 +428,26 @@ private
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r106139530
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -441,26 +486,53 @@ public void close
1 - 100 of 970 matches
Mail list logo
