Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105398702
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -333,32 +356,40 @@ public void addEdge(Integer upStreamVertexID, Integer
downStreamVertexID, int ty
downStreamVertexID,
typeNumber,
null,
- new ArrayList<String>());
+ new ArrayList<String>(), null);
}
private void addEdgeInternal(Integer upStreamVertexID,
Integer downStreamVertexID,
int typeNumber,
StreamPartitioner<?> partitioner,
- List<String> outputNames) {
-
+ List<String> outputNames,
+ OutputTag outputTag) {
- if (virtualSelectNodes.containsKey(upStreamVertexID)) {
+ if (virtualSideOutputNodes.containsKey(upStreamVertexID)) {
+ int virtualId = upStreamVertexID;
+ upStreamVertexID =
virtualSideOutputNodes.get(virtualId).f0;
+ if (outputTag == null) {
+ outputTag =
virtualSideOutputNodes.get(virtualId).f1;
+ }
+ addEdgeInternal(upStreamVertexID, downStreamVertexID,
typeNumber, partitioner, null, outputTag);
+ } else if (virtualSelectNodes.containsKey(upStreamVertexID)) {
int virtualId = upStreamVertexID;
upStreamVertexID = virtualSelectNodes.get(virtualId).f0;
if (outputNames.isEmpty()) {
// selections that happen downstream override
earlier selections
outputNames =
virtualSelectNodes.get(virtualId).f1;
}
- addEdgeInternal(upStreamVertexID, downStreamVertexID,
typeNumber, partitioner, outputNames);
+ addEdgeInternal(upStreamVertexID, downStreamVertexID,
typeNumber, partitioner, outputNames, outputTag);
} else if (virtualPartitionNodes.containsKey(upStreamVertexID))
{
int virtualId = upStreamVertexID;
upStreamVertexID =
virtualPartitionNodes.get(virtualId).f0;
if (partitioner == null) {
partitioner =
virtualPartitionNodes.get(virtualId).f1;
}
- addEdgeInternal(upStreamVertexID, downStreamVertexID,
typeNumber, partitioner, outputNames);
+
--- End diff --
Remove line for uniformity with the `if() ...` above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
