Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2152
Sorry for long no response. Could you give me few days more? I'll review in
weekend. Sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76550602
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/Block.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76550821
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/Block.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76550871
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/Block.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551066
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMapper.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551085
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMapper.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551077
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMapper.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551144
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551191
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551568
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76551557
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76552087
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -159,3 +183,68 @@ case class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r76580310
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2459
Hi @shijinkui, thanks for opening pull request. Unfortunately, this pull
request cause a problem with maven shading plugin
(https://issues.apache.org/jira/browse/MSHADE-200). Due to the problem
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r68041009
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,162
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1996
Looks good to me, +1. I'll merge this in few hours.
But I think we should change the type of row index to `Long` in near
future. I think we can deal with the incompatibility problem
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1985
Hi @skavulya, sorry for late response. I've checked the updated PR and
looks good to me. I wonder whether the name `RegularizationPenalty` is proper
because the class calculates lots of v
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2152
Thanks for opening pull request @chobeat! I would like to shepherd this PR.
I'll review in weekend.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696421
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696490
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696692
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696680
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696809
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68696822
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68885212
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala
---
@@ -0,0 +1,287 @@
+/*
+ * Licensed
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2152
This PR contains unnecessary code changes related to `DistributedRowMatrix`
(`DistributedRowMatrix.scala` and `DistributedRowMatrixSuite.scala`). Please
sync this PR with current master.
---
If
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/2152#discussion_r68891682
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/distributed/BlockMatrixSuite.scala
---
@@ -0,0 +1,106
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1220
Hi @thvasilo, I've checked the [FlinkML index
page](https://ci.apache.org/projects/flink/flink-docs-master/apis/batch/libs/ml/index.html#supervised-learning).
There is a link to k-NN page i
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-133315011
I just addressed the comments on each line. I think that here is the time
to decide whether to merge or not.
---
If your project is set up for it, you can reply to
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-133591848
Okay. You don't need to hurry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-133870941
+1 for moving histogram functions into `DataSetUtils`. It would be helpful
for range partitioning. I'll review this in next days.
---
If your project is set u
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1041#issuecomment-133874756
Looks good to merge. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/949#issuecomment-133999705
@ChengXiangLi I know that it is hard to verify random sampler
implementation. But we need to fix this test failing because of difficulty of
other pull requests
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1047#issuecomment-134130912
I've tested with increased count of sources and count of samples. It seems
okay but I'm not sure which approach is more proper.
https://tra
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1047#issuecomment-134145495
Here is my changes: chiwanpark@0699411
The changes are tested in my local environment about 200 hundred times and
also tested in Travis-CI 10 times
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1047#issuecomment-134449682
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-134457512
Hi, Thanks for your contribution. I'll review this and leave comments.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1047#issuecomment-134459358
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1047#issuecomment-134531036
@tillrohrmann Sorry for late. I forgot push the commit to apache master.
The commit is pushed.
---
If your project is set up for it, you can reply to this email and
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1053
[FLINK-2569] [core] Add CsvReader support for Value types
This PR contains following changes:
* Extend `TupleTypeInfo` to support `Value` type as basic (primitive) type.
* Rename
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-134623006
@rmetzger Thanks! I addressed your comment and rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1053#discussion_r37884384
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java ---
@@ -123,6 +132,21 @@ public void
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1053#issuecomment-134584979
@fhueske Thanks for review. :) I addressed your comments.
* Add `getBasicAndBasicValueTupleTypeInfo` method into `TupleTypeInfo`
* Add `isBasicValueType
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1053#discussion_r37947758
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java ---
@@ -123,6 +132,21 @@ public void
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1053#issuecomment-134853875
I fixed the test to use `collect` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1052#discussion_r37998051
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/SortMergeJoinDescriptor.java
---
@@ -99,7 +99,7 @@ public DualInputPlanNode
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1052#discussion_r37998816
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskExternalITCase.java
---
@@ -0,0 +1,121
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1052#discussion_r37998836
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskExternalITCase.java
---
@@ -0,0 +1,121
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1052#discussion_r37999044
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskExternalITCase.java
---
@@ -0,0 +1,121
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1052#discussion_r37999081
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskExternalITCase.java
---
@@ -0,0 +1,121
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1052#discussion_r37999088
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskExternalITCase.java
---
@@ -0,0 +1,121
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-135084756
Thanks @r-pogalz and @jkovacs for contribution!
I found some code style issues.
* Please add spaces around operator and after comma.
* Please don&#
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1062#discussion_r38056846
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/yarn/AbstractFlinkYarnCluster.java
---
@@ -43,10 +68,24 @@
*/
public
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1065#issuecomment-135351546
Nice catch, +1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1033#issuecomment-135360987
I'm inclined to the @tillrohrmann 's comment. I think that it is okay to
call GraphAlgorithm based on Scala API in Java API and the user has the
respons
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38077650
--- Diff: flink-staging/flink-hcatalog/pom.xml ---
@@ -34,17 +34,64 @@ under the License.
jar
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38077697
--- Diff: flink-staging/flink-hcatalog/pom.xml ---
@@ -34,17 +34,64 @@ under the License.
jar
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38077826
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38077909
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078242
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,433
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078278
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,433
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078266
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,433
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078289
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,433
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078293
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,433
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078282
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,433
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078462
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078475
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078523
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078508
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078553
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078601
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1064#discussion_r38078885
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,215
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1064#issuecomment-135369221
Hi @jamescao, Thanks for your pull request!
I reviewed roughly and will review more detail in few days.
About the version of hcatalog release, it would be
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1062#issuecomment-135370510
I pulled this request into my local machine (OS X 10.9, JDK 1.8, Scala
2.10) and tested. I got an exception while running test four times:
```
12:32
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1062#issuecomment-135374495
Here is `jobmanager-main.log` in `application_1440646275804_0005`:
```
19:07:45,732 WARN org.apache.hadoop.util.NativeCodeLoader
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1062#issuecomment-135378762
I got `java.lang.AssertionError: Unable to find expected string 'The Flink
YARN client has been started in detached mode' in log messages` also. I'
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1062#issuecomment-135386783
Still failing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1062#issuecomment-135401201
@rmetzger Oh, after I clean my local maven repository and rebuild all
projects, then the test works. Sorry for wrong reporting.
---
If your project is set up for it
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1080#issuecomment-136276551
Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-136284408
From [this JIRA](https://issues.apache.org/jira/browse/HIVE-4460), It seems
that HCatalog are deployed with Hadoop 2. Is it sure that the vanila version of
HCatalog
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-136790993
Ah, Sorry for late. Currently, I'm busy. Maybe I need 1-2 days to review.
I'll try to review asap.
---
If your project is set up for it, you can reply to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38616759
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38619828
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -248,6 +251,58 @@ public void mapPartition(Iterable values
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38619843
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -248,6 +251,58 @@ public void mapPartition(Iterable values
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137376194
Hi, I just reviewed the updated PR. Sorry for late.
Your implementation is nice. It seems acting like I expected. But I have to
check the following
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137379709
+1 for adding a class for `Double` values.
From my curiosity, Could `DiscreteHistogram` be used for decision tree? In
the given paper, they used histogram
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137381508
I'm inclined to preventing base class for the histogram. Decision Tree will
be implemented in Scala and we can use pattern matching (case-match statement)
for so
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1074#issuecomment-137396215
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137690196
Looks good to merge except some minor issues. If there is no objection for
this PR, I'll merge this in tomorrow.
---
If your project is set up for it, you can
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38735464
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38735611
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-137691399
Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38735587
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137912454
I object to break API in this PR. I think that this PR should cover
histogram for `DataSet` only. That's why we split this PR from #1032.
About documentation, a
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/943#issuecomment-137922910
After merging this, we should update `CsvInputFormat`. Currently, we create
`Field` objects in `open` method of `CsvInputFormat`. With this PR, we don't
ne
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137923702
+1
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1103
[FLINK-2619] [tests] Fix for some unexecuted Scala tests
This PR includes to resolve FLINK-2619. The changes are following:
* Add JUnitRunner(`@RunWith(classOf[JUnitRunner])`) for
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1104#issuecomment-138449459
+1 for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138483365
Is this merged? I cannot find this commit in ASF Git repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1104#issuecomment-138483880
+1 for making `hashCode()`, `equals()`, and `toString()` abstract.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
1 - 100 of 624 matches
Mail list logo
