Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137376194
Hi, I just reviewed the updated PR. Sorry for late.
Your implementation is nice. It seems acting like I expected. But I have to
check the following:
I'm concerned about changing `Histogram` class. It causes API breaking. I'm
not sure that this breaking is necessary. Reverting the changes of `Histogram`
would be better. Because there are many differences between
`ContinuousHistogram` and `DiscreteHistogram`, we don't need to create base
class for them.
I'm sorry about consuming time to merge this PR. It seems almost arrived
the goal. Cheer up!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
