GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2389
Jira FLINK-4348
this pull request aims to implement communication from ResourceManager to
TaskManager which is jira 4348.
There are mainly 3 logics initiated from RM to TM:
1. Heartbeat
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75789222
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -94,26 +130,218 @@ public
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75789238
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -94,26 +130,218 @@ public
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75789279
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -52,18 +61,45 @@
public class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75789293
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -52,18 +61,45 @@
public class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75789477
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -52,18 +61,45 @@
public class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75789610
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -52,18 +61,45 @@
public class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75790043
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -94,26 +130,218 @@ public
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75790203
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerToTaskExecutorHeartbeatScheduler.java
---
@@ -0,0
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75792341
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerToTaskExecutorHeartbeatScheduler.java
---
@@ -0,0
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75792397
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerToTaskExecutorHeartbeatScheduler.java
---
@@ -0,0
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75793072
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -94,26 +130,218 @@ public
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75793093
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -94,26 +130,218 @@ public
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75793520
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -94,26 +130,218 @@ public
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2410
[FLINK-4449] [cluster management] Heartbeat Manager between ResourceManager
and TaskExecutor
The PR is focus on Heartbeat Manager between ResourceManager and
TaskExecutor.
HeartbeatManager
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2389
Hi, till. I submit a new PR #2410 which is focus on heartbeat. Please
review that PR, thanks very much.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2410#discussion_r76168206
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/heartbeat/HeartbeatSchedulerTest.java
---
@@ -0,0 +1,248 @@
+/*
+ * Licensed
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2410
Hi, till. Thanks for reviewing and good advices so much. I agree we should
define how should it look like first. And I try to give my opinions for your
question.
1. exponential backoff
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2410#discussion_r76176200
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerHATest.java
---
@@ -0,0 +1,102
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2410#discussion_r76176210
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/heartbeat/HeartbeatSchedulerTest.java
---
@@ -0,0 +1,248 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2410#discussion_r76176673
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerHATest.java
---
@@ -0,0 +1,102
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2410#discussion_r76176826
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/heartbeat/HeartbeatScheduler.java
---
@@ -0,0 +1,286 @@
+/*
+ * Licensed to
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2410
@tillrohrmann , I modify the code based on your advice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2417
[FLINK-4449] [cluster management] heartbeat receiveing endpoint monitor the
heartbeat from sender
receiving end monitor the sender so that if the heartbeat request is not
delivered, then
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2410
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2417
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2427
[FLINK-4516] [cluster management]leader election of resourcemanager
This pull request is to implement resourceManager leader Election, which
including:
1. When a resourceManager is started
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2427#discussion_r76738145
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerHATest.java
---
@@ -0,0 +1,86
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2427#discussion_r76779266
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerHATest.java
---
@@ -0,0 +1,86
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2427#discussion_r76909528
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingSerialRpcService.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2427#discussion_r76909719
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingSerialRpcService.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2427#discussion_r76910556
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingSerialRpcService.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2427#discussion_r76912353
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -116,4 +142,78 @@ public SlotAssignment
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2427
@mxm , thanks for your review. I had change the code based on your advice,
the changes are following:
1. move all code in the methods handleGrantLeadership, revokeLeadership
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r76929812
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatListener.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r76938462
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatListener.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2427
@mxm , Thanks for your review. And I change the ResourceManagerHATest to
use a mocked RpcService instead of TestingSerialRpcService.
---
If your project is set up for it, you can reply to this
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2427
Hi @mxm , thanks so much. I already close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2451
[FLINK-4535] [cluster management] resourceManager process the registration
from TaskExecutor
This pull request is to implement ResourceManager registration with
TaskExecutor, which including
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2455
[FLINK-4547] [cluster management] Return same object when call connect
method in AkkaRpcService using same address and same rpc gateway class
The pull request is to add equals and hashCode
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2455#discussion_r77753174
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -189,7 +191,49 @@ public void stop
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2455#discussion_r77754084
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -189,7 +191,49 @@ public void stop
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2451#discussion_r77757943
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -138,22 +150,46 @@ public SlotAssignment
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2451
@tillrohrmann , thanks for your review. I changed the pr based on your
advice, including ï¼
1. Modify UnmatchedLeaderSessionIDException to LeaderSessionIDException,
format code style and
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77768256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public SlotManager
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77769044
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public SlotManager
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2455
@tillrohrmann @StephanEwen , thanks for your review. I changed the code
based on your comment, including two points:
1. Change the JIRA and the PR subject line to better reflect the actual
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2479
[FLINK-4537] [cluster management] ResourceManager registration with
JobManager
This pull request is to implement ResourceManager registration with
JobManager, which including:
1. Check
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77943543
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
public
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2524
[FLINK-4653] [Client] Refactor JobClientActor to adapt to new Rpc framework
and new cluster managerment
There are following main changes:
1. Create a RpcEndpoint(temporary named
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2524
@mxm , I rebase the PR already. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2455
@tillrohrmann , I rebase the PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2540
[FLINK-4606] [Client] Integrate the new ResourceManager with the existed
FlinkResourceManager
This pr aims to integrate the new ResourceManager with the existed
FlinkResourceManager, the main
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2543
[FLINK-4606] [cluster management] Add watch mechanism on current RPC
framework
This pr aims at adding watch mechanism on current RPC framework, so RPC
gateway could be watched to make sure the
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2543
Hi, till. Thanks for your review.
First sorry to bind to the wrong jira link, already correct it.
About heartbeatManager, i thought we could separate HeartbeatManager into
two part, each
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105316858
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105362292
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105362031
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105363598
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105363822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105384191
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@fhueske , thanks for your review. I updated the pr based on your comments.
Your suggestion about moving the annotation from TableSource to
TableSourceConverter is good, I changed the pr in
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@fhueske , thanks for your review. I already updated the pr based on your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368344
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -99,6 +101,9 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368614
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368629
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r10636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -353,19 +388,48 @@ abstract class
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3409
@fhueske , thanks for the review. I have updated the pr based on your
suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106394128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
---
@@ -0,0 +1,110
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106395005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106395036
--- Diff:
flink-libraries/flink-table/src/main/resources/tableSourceConverter.properties
---
@@ -0,0 +1,19
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106403723
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -0,0 +1,153
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106404460
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala
---
@@ -0,0 +1,73
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@twalthr , thanks for the review. I have updated the pr based on your
suggestion. I would add documents later in the pr #3409. About the name of
ExternalCatalog, I notice that there are three
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3559
[flink-6037] [Table API & SQL]hotfix: metadata provider didn't work in SQL
This pr aims to fix a bug referenced by
https://issues.apache.org/jira/browse/FLINK-6037.
After using
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106648264
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3559#discussion_r106797445
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala
---
@@ -100,6 +101,7 @@ class
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3559
@KurtYoung , thanks for the review. I've updated the pr based on your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3569
[flink-6036]Let catalog support partition
This pr aims to let catalog support partition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107059962
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107060990
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -165,3 +165,31 @@ case class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107061507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107636115
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107636567
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3409
@fhueske @twalthr , thanks for the reviews. I've updated the pr based on
your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2791
[FLINK-4449] [cluster management] add Heartbeat manager in ResourceManager
with TaskExecutor
This pr aims to add Heartbeat manager in ResourceManager with TaskExecutor.
This pr focused on
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2921
[FLINK-5185] [Table API & SQL] Decouple BatchTableSourceScan with
TableSourceTable
The pr aims to decouple BatchTableSourceScan with TableSourceTable for
further optimization, e.g, projec
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2921#discussion_r90577312
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -32,18 +31,20
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2923
[FLINK-5220] [Table API & SQL] Flink SQL projection pushdown
This pr aims to do projection pushdown optimization.
There are two commits here, first one is linked to
[h
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2923
@fhueske , thanks for your review. I have already modified the pr based on
your advice, including following main changes:
1. Adapt the cost model for the BatchTableSourceScan
2. Modify
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91429660
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchScan.scala
---
@@ -45,7 +45,8 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2926#discussion_r91455098
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -73,7 +75,11 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91847985
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/plan/rules/util/RexProgramProjectExtractorTest.scala
---
@@ -0,0 +1,121
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91847990
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/ProjectableTableSourceITCase.scala
---
@@ -0,0 +1,154
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2923
@fhueske , thanks for your review, I already modify code based on your
advices.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
1 - 100 of 136 matches
Mail list logo
