Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@fhueske , thanks for your review. I updated the pr based on your comments.
Your suggestion about moving the annotation from TableSource to
TableSourceConverter is good, I changed the pr in this way.
About not use scanning at all but exactly specify the Converter classes. It
can work, too. However, if somebody adds new tableSourceConverters , such as
parquetTableSourceConverter or else, users need to change the code or config
file to register new added Converters, right? However scanning method can finds
all converters automatically.
Let me know what's your opinion, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
