Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2355
I have rearranged the code. It is really hard for me to add space after
every comma,do you have any code style preset for IDEs so that I can reformat
my new code automatically without change those of
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2355
@aljoscha It's fine.I'll try to write well formatted code manually from now
on, and I hope the code in the last commit is well formatted enough.
---
If your project is set up for it, you
Github user Renkai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2729#discussion_r87350332
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -181,7 +181,17 @@ protected void fillInType(TypeInformation typeInfo
Github user Renkai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2729#discussion_r87743796
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ScalaObjectChecker.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user Renkai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2729#discussion_r87792198
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ScalaObjectChecker.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2729
I'm not very understand why some function need to be cleaned while others
are not in the last version of scala API, but I think all of them need to be
checked, so I add some checks where h
GitHub user Renkai opened a pull request:
https://github.com/apache/flink/pull/2847
[FLINK-5031]Consecutive DataStream.split() ignored
I think this is a way to solve this issue, but might not be the best
one.Since I'm knowing the code base enough, I hope someone may review i
GitHub user Renkai opened a pull request:
https://github.com/apache/flink/pull/2893
[FLINK-5128]Get Kafka partitions in FlinkKafkaProducer only if a
partitioner is set
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Renkai
GitHub user Renkai opened a pull request:
https://github.com/apache/flink/pull/2928
[FLINK-5108] Remove ClientShutdownHook during job execution
This patch simply removed ClientShutdownHook related code. The changes may
cause `org.apache.flink.yarn.YarnClusterClient#pollingRunner
Github user Renkai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2729#discussion_r90775528
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ScalaObjectChecker.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2729
Hi, @StefanRRichter , I optimized the code with your advice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2729
Hi, @aljoscha I think the case make sense not only when parallelsim is
1,but also users knows the code would be execute in parallel and the code is
thread safe and they may want to reduce some
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2729
Hi, @aljoscha keep a balance in freedom and safety is really a hardwork. I
think we could just give a warning to users, but fail and exit directly.
---
If your project is set up for it, you can
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2928
That is ok to close this issue.
Max äº2016å¹´12æ14æ¥å¨ä¸ 02:31åéï¼
> There is one problem we overlooked. In detached mode we ensure cluster
> shutdown through a m
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2729
Hi, @aljoscha I'm wondering about how could the warning be "big", should it
have a different color in the console or pop out an alert window when people
submit apps from web?
---
If
Github user Renkai closed the pull request at:
https://github.com/apache/flink/pull/2928
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Renkai opened a pull request:
https://github.com/apache/flink/pull/2355
[FLINK-4282]Add Offset Parameter to WindowAssigners
Although there is already a merge request for this issue,I think this
implementation is more sensible.
You can merge this pull request into a Git
GitHub user Renkai opened a pull request:
https://github.com/apache/flink/pull/2726
Flink 4883
Ideas and code structure are basically copied from
`org.apache.flink.api.java.ClosureCleaner`
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2726
Not prepared yet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user Renkai closed the pull request at:
https://github.com/apache/flink/pull/2726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Renkai opened a pull request:
https://github.com/apache/flink/pull/2729
[FLINK-4883]Prevent UDFs implementations through Scala singleton objects
The code changes should be work, but I was quite a lot confused for these
reasons
1. The Scala wrapper for
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420137#comment-15420137
]
Renkai Ge commented on FLINK-4282:
--
[~aljoscha]I use two mod just want to pre
Renkai Ge created FLINK-4409:
Summary: class conflict between jsr305-1.3.9.jar and
flink-shaded-hadoop2-1.1.1.jar
Key: FLINK-4409
URL: https://issues.apache.org/jira/browse/FLINK-4409
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge updated FLINK-4409:
-
Description:
It seems all classes in jsr305-1.3.9.jar can be found in
flink-shaded-hadoop2-1.1.1.jar,too
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425768#comment-15425768
]
Renkai Ge commented on FLINK-4282:
--
Hi, [~aljoscha]. I changed the code as your
Renkai Ge created FLINK-4428:
Summary: Method map/flatMapWithState may need a eviction policy
Key: FLINK-4428
URL: https://issues.apache.org/jira/browse/FLINK-4428
Project: Flink
Issue Type: New
[
https://issues.apache.org/jira/browse/FLINK-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427893#comment-15427893
]
Renkai Ge commented on FLINK-2118:
--
[~sahitya.pavurala] ! have a higher precedence
[
https://issues.apache.org/jira/browse/FLINK-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427903#comment-15427903
]
Renkai Ge commented on FLINK-2118:
--
I want to help solving this issue but I'm
[
https://issues.apache.org/jira/browse/FLINK-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430310#comment-15430310
]
Renkai Ge commented on FLINK-2118:
--
[~fhueske][~aljoscha]
operations end with
[
https://issues.apache.org/jira/browse/FLINK-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430310#comment-15430310
]
Renkai Ge edited comment on FLINK-2118 at 8/22/16 8:4
Renkai Ge created FLINK-4532:
Summary: Allow independent metrics reporter for tasks
Key: FLINK-4532
URL: https://issues.apache.org/jira/browse/FLINK-4532
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450946#comment-15450946
]
Renkai Ge commented on FLINK-4532:
--
[~StephanEwen]
Yes, I think your proposa
[
https://issues.apache.org/jira/browse/FLINK-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450946#comment-15450946
]
Renkai Ge edited comment on FLINK-4532 at 8/31/16 3:3
[
https://issues.apache.org/jira/browse/FLINK-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452069#comment-15452069
]
Renkai Ge commented on FLINK-4532:
--
[~StephanEwen] So should I close this issue
Renkai Ge created FLINK-4587:
Summary: Yet another java.lang.NoSuchFieldError: INSTANCE
Key: FLINK-4587
URL: https://issues.apache.org/jira/browse/FLINK-4587
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge updated FLINK-4587:
-
Attachment: flink-explore-src.zip
> Yet another java.lang.NoSuchFieldError: INSTA
[
https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500799#comment-15500799
]
Renkai Ge commented on FLINK-3373:
--
[~StephanEwen]
This issue seems reproduced in F
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502120#comment-15502120
]
Renkai Ge commented on FLINK-4587:
--
the
{code}lib/flink-dist_2.10-1.2-SNAPSHOT.jar{
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502373#comment-15502373
]
Renkai Ge commented on FLINK-4587:
--
When I execute {code}mvn clean install -DskipT
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge updated FLINK-4587:
-
Attachment: diff in mvn clean package.png
logs when execute mvn between root directory and flink-dist
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502715#comment-15502715
]
Renkai Ge commented on FLINK-4587:
--
The released binary at https://flink.apache
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502441#comment-15502441
]
Renkai Ge edited comment on FLINK-4587 at 9/19/16 9:1
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge updated FLINK-4587:
-
Component/s: Build System
> Yet another java.lang.NoSuchFieldError: INSTA
[
https://issues.apache.org/jira/browse/FLINK-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509539#comment-15509539
]
Renkai Ge commented on FLINK-1605:
--
Hi [~rmetzger],
Could you help take a view at
[
https://issues.apache.org/jira/browse/FLINK-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge reassigned FLINK-5031:
Assignee: Renkai Ge
> Consecutive DataStream.split() igno
[
https://issues.apache.org/jira/browse/FLINK-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666015#comment-15666015
]
Renkai Ge commented on FLINK-5031:
--
I want to work on this issue
> Cons
[
https://issues.apache.org/jira/browse/FLINK-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675265#comment-15675265
]
Renkai Ge commented on FLINK-4587:
--
Yes,solved in the way described
Stephan Ewen (
[
https://issues.apache.org/jira/browse/FLINK-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678716#comment-15678716
]
Renkai Ge commented on FLINK-5031:
--
[~fhueske]The second split was not ignored, it
[
https://issues.apache.org/jira/browse/FLINK-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678716#comment-15678716
]
Renkai Ge edited comment on FLINK-5031 at 11/19/16 6:2
[
https://issues.apache.org/jira/browse/FLINK-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge reassigned FLINK-5128:
Assignee: Renkai Ge
> Get Kafka partitions in FlinkKafkaProducer only if a partitioner is
[
https://issues.apache.org/jira/browse/FLINK-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692944#comment-15692944
]
Renkai Ge commented on FLINK-5128:
--
I want to work for this.
> Get Kafka partit
[
https://issues.apache.org/jira/browse/FLINK-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge reassigned FLINK-5108:
Assignee: Renkai Ge
> Remove ClientShutdownHook during job execut
[
https://issues.apache.org/jira/browse/FLINK-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704795#comment-15704795
]
Renkai Ge commented on FLINK-5108:
--
I want to work for this.
>
[
https://issues.apache.org/jira/browse/FLINK-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714849#comment-15714849
]
Renkai Ge commented on FLINK-5108:
--
I think it could be ready in this weekend,sorry
[
https://issues.apache.org/jira/browse/FLINK-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge updated FLINK-4252:
-
Attachment: TestMain.scala
> Table program cannot be compi
Renkai Ge created FLINK-4252:
Summary: Table program cannot be compiled
Key: FLINK-4252
URL: https://issues.apache.org/jira/browse/FLINK-4252
Project: Flink
Issue Type: Bug
Components
[
https://issues.apache.org/jira/browse/FLINK-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge updated FLINK-4252:
-
Description:
I'm trying the table apis.
I got some errors like this
My code is in the attach
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416556#comment-15416556
]
Renkai Ge commented on FLINK-4282:
--
If there is no proper solution to this issue n
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416602#comment-15416602
]
Renkai Ge commented on FLINK-4282:
--
I have the same opinion with [~aljoscha],the of
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419763#comment-15419763
]
Renkai Ge commented on FLINK-4282:
--
Thanks,[~aljoscha].It's a brilliant ide
[
https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600886#comment-15600886
]
Renkai Ge commented on FLINK-4883:
--
I want to work on this issue.
> Preve
[
https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604147#comment-15604147
]
Renkai Ge commented on FLINK-4883:
--
I tried to use object to extend UDF, but I hav
[
https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607635#comment-15607635
]
Renkai Ge commented on FLINK-4883:
--
I found a way to distinguish normal scala insta
[
https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611756#comment-15611756
]
Renkai Ge commented on FLINK-4883:
--
How about to extend the me
[
https://issues.apache.org/jira/browse/FLINK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15619663#comment-15619663
]
Renkai Ge commented on FLINK-4883:
--
I tried to implement it in module flink-scala
[
https://issues.apache.org/jira/browse/FLINK-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453599#comment-16453599
]
Renkai Ge commented on FLINK-7851:
--
[~till.rohrmann] Is there an alternative way
[
https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renkai Ge reopened FLINK-2540:
--
It seems that this issue was not fixed at all.It is closed since some
github/Jira sync bugs occured.
I
[
https://issues.apache.org/jira/browse/FLINK-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417058#comment-16417058
]
Renkai Ge commented on FLINK-2540:
--
[~uce] As far as I can see,there is no reason
68 matches
Mail list logo
