[ 
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416602#comment-15416602
 ] 

Renkai Ge commented on FLINK-4282:
----------------------------------

I have the same opinion with [~aljoscha],the offset property for TimeWindow is 
redundant,the offset value should just effect the point which to devide the 
stream into windows,not effect the window it self.If we want a window with 
offset,we only need to change lines like 
<https://github.com/apache/flink/blob/90cfe0a7b499832cebc2a53f7b066f83dde17de5/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingProcessingTimeWindows.java#L61>
 ,and since SessionWindows decide where to devide stream into windows by the 
timestamp of first message comes,files like 
ProcessingTimeSessionWindows.java,SlidingProcessingTimeWindows.java
and TumblingProcessingTimeWindows.java do not need to be changed for this issue.

> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days 
> are aligned with GMT. This is somewhat problematic for people living in 
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to