[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141388702 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java --- @@ -211,10 +210,15 @@ public void

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141392162 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -313,6 +320,49 @@ public int

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141392529 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -87,6 +88,12 @@ /** The

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141387553 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -313,6 +320,49 @@ public int

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141393650 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -87,6 +88,12 @@ /** The

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141396023 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141396295 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141396863 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed

[GitHub] flink issue #4591: [FLINK-7514][tests] fix BackPressureStatsTrackerITCase re...

2017-09-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4591 ok, that last rebase was missing an import - fixed now ---

[GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4358#discussion_r141570317 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/PermanentBlobCache.java --- @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #4698: [FLINK-7661][network] Add credit field in PartitionReques...

2017-09-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4698 ok, cool, then we can merge this PR as anticipated ---

[GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...

2017-09-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4447 oh, yes - maybe I should rebase this one and exclude #4445 commits since there, we may actually investigate further ---

[GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...

2017-09-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4447 PR updated by rebasing onto master and dropping the FLINK-7310 commits from #4445. ---

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141657809 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -87,6 +88,12 @@ /** The

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141660623 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java --- @@ -400,6 +399,23 @@ private int

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141660332 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java --- @@ -209,31 +209,30 @@ public void

[GitHub] flink pull request #4735: [FLINK-7699][core] Define the BufferListener inter...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4735#discussion_r141659141 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java --- @@ -209,31 +209,30 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141664479 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -176,6 +176,8 @@ protected void decode

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141665866 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141665789 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141673902 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141667517 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141890343 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141896488 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -412,23 +468,35 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141890051 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141865630 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141908388 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -374,6 +376,64 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141902956 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -70,6 +79,21

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141865540 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141890624 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141896356 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -412,23 +468,35 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141901569 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -209,6 +276,95 @@ public String

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141886467 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141906648 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -374,6 +376,64 @@ public void

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r141911428 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -37,20 +43,31 @@ import

[GitHub] flink pull request #4758: [FLINK-7745][tests] add tests for ensuring Network...

2017-10-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4758 [FLINK-7745][tests] add tests for ensuring NetworkBufferPool overprovisioning behaviour ## What is the purpose of the change Currently, there are no unit tests verifying `NetworkBufferPool

[GitHub] flink pull request #4759: [FLINK-7746][network] move ResultPartitionWriter#w...

2017-10-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4759 [FLINK-7746][network] move ResultPartitionWriter#writeBufferToAllChannels implementation up into ResultPartition ## What is the purpose of the change As a step towards removing the (unneeded

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-10-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4761 [FLINK-7748][network] properly use the TaskEventDispatcher for subscribing to events ## What is the purpose of the change `ResultPartitionWriter` currently implements the `EventListener

[GitHub] flink pull request #4762: [FLINK-7749][network] remove the ResultPartitionWr...

2017-10-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4762 [FLINK-7749][network] remove the ResultPartitionWriter wrapper ## What is the purpose of the change After changing task event notification to the `TaskEventDispatcher` (#4759) and buffer

[GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...

2017-10-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4358#discussion_r142635118 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobKey.java --- @@ -83,30 +113,34 @@ public boolean equals(final Object obj

[GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...

2017-10-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4358#discussion_r142637006 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java --- @@ -252,6 +280,36 @@ public void testJobDeferredCleanup

[GitHub] flink issue #4762: [FLINK-7749][network] remove the ResultPartitionWriter wr...

2017-10-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4762 thanks, fixed that in the description of the PR ---

[GitHub] flink issue #4358: [FLINK-7068][blob] change BlobService sub-classes for per...

2017-10-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4358 Rebased and extended the PR as requested - the last two commits contain the changes compared to the last review. I tried to clean up some of the commits for a better merge but please note

[GitHub] flink issue #4568: [FLINK-7483][blob] prevent cleanup of re-registered jobs

2017-10-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4568 will be fixed by #4358 ---

[GitHub] flink pull request #4568: [FLINK-7483][blob] prevent cleanup of re-registere...

2017-10-04 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/4568 ---

[GitHub] flink pull request #4402: [FLINK-7261][blob] extend BlobStore#get/put with b...

2017-10-04 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/4402 ---

[GitHub] flink issue #4402: [FLINK-7261][blob] extend BlobStore#get/put with boolean ...

2017-10-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4402 will be fixed by #4358 ---

[GitHub] flink issue #4359: [FLINK-7140][blob] add an additional random component int...

2017-10-05 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4359 rebased onto the latest #4358 ---

[GitHub] flink issue #4403: [FLINK-7262][blob] remove the unused FallbackLibraryCache...

2017-10-05 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4403 rebased onto the latest #4381 ---

[GitHub] flink issue #4381: [FLINK-7196][blob] add a TTL to all transient BLOBs

2017-10-05 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4381 rebased onto the latest #4359 ---

[GitHub] flink pull request #4782: [FLINK-7772][blob] fix test instability in BlobCac...

2017-10-06 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4782 [FLINK-7772][blob] fix test instability in BlobCacheDeleteTest ## What is the purpose of the change `BlobCacheDeleteTest` did not account for the server executing the delete call of a

[GitHub] flink pull request #4783: [FLINK-7774][network] fix not clearing deserialize...

2017-10-06 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4783 [FLINK-7774][network] fix not clearing deserializers on closing an input ## What is the purpose of the change On cleanup of the `AbstractRecordReader`, `StreamInputProcessor`, and

[GitHub] flink pull request #4447: [FLINK-7312][checkstyle] activate checkstyle for f...

2017-10-09 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/4447 ---

[GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...

2017-10-09 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4447 closed via c3235c395f7bb69b482b85c6832d427100130ca3 ---

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143425927 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -434,6 +435,52 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143233556 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -331,37 +353,41 @@ public int

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143225914 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -306,10 +311,27 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143230905 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -306,10 +311,27 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143424259 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -306,10 +311,27 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143232200 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -331,37 +353,41 @@ public int

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-09 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r143422899 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -374,6 +376,64 @@ public void

[GitHub] flink pull request #3959: [FLINK-6654] let 'flink-dist' properly depend on '...

2017-05-22 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3959 [FLINK-6654] let 'flink-dist' properly depend on 'flink-shaded-hadoop2-uber' Since applying FLINK-6514, flink-dist includes `flink-shaded-hadoop2-uber-*.jar` but without giving th

[GitHub] flink pull request #3959: [FLINK-6654] let 'flink-dist' properly depend on '...

2017-05-22 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/3959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3959: [FLINK-6654] let 'flink-dist' properly depend on 'flink-s...

2017-05-22 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3959 sorry, wrong branch to submit to --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request #3960: [FLINK-6654][build] let 'flink-dist' properly depe...

2017-05-22 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3960 [FLINK-6654][build] let 'flink-dist' properly depend on 'flink-shaded… Since applying FLINK-6514, flink-dist includes `flink-shaded-hadoop2-uber-*.jar` but without giving this de

[GitHub] flink pull request #3962: [FLINK-6659] fix (some) unit tests leaving tempora...

2017-05-22 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3962 [FLINK-6659] fix (some) unit tests leaving temporary data behind Both, `RocksDBMergeIteratorTest` as well as `SavepointITCase` were using `CommonTestUtils.createTempDirectory()` to create a temporary

[GitHub] flink pull request #3966: [FLINK-6320] fix unit test failing sometimes when ...

2017-05-22 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3966 [FLINK-6320] fix unit test failing sometimes when deleting a temp dir use a JUnit rule with a `TemporaryFolder` instead which should fix this (alternatively, catching the exception may have fixed

[GitHub] flink issue #3960: [FLINK-6654][build] let 'flink-dist' properly depend on '...

2017-05-23 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3960 I wasn't quite sure and went the safe way - can remove the exclusion though... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #3960: [FLINK-6654][build] let 'flink-dist' properly depend on '...

2017-05-23 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3960 you probably need to clean up your whole source with `mvn clean` and try from there - I'm not quite sure, my initial command will clean up everything that is not in the dependencies of the flink

[GitHub] flink pull request #3978: [FLINK-6689] fix SIGABRT during GC in the CEP unit...

2017-05-24 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3978 [FLINK-6689] fix SIGABRT during GC in the CEP unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-6689 Alternatively

[GitHub] flink pull request #3978: [FLINK-6702] fix SIGABRT during GC in the CEP unit...

2017-05-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3978#discussion_r118260352 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java --- @@ -654,6 +654,7 @@ public boolean filter(Event

[GitHub] flink pull request #3980: [FLINK-6706] remove outdated/unused ChaosMonkeyITC...

2017-05-24 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3980 [FLINK-6706] remove outdated/unused ChaosMonkeyITCase This test was disabled in Dec 2015 due to its instability and never made it back again. It is probably outdated and may not even work anymore

[GitHub] flink pull request #4017: [FLINK-6774][build] set missing build-helper-maven...

2017-05-30 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4017 [FLINK-6774][build] set missing build-helper-maven-plugin version this PR sets the version number on those sub-modules which did not set it yet You can merge this pull request into a Git repository

[GitHub] flink pull request #4024: [FLINK-6782][docs] update snapshot documentation t...

2017-05-31 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4024 [FLINK-6782][docs] update snapshot documentation to reflect flink 1.3 please also apply to master after accepting You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request #4028: [FLINK-6570] update queryable state documentation

2017-05-31 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4028 [FLINK-6570] update queryable state documentation * adapt a left-over `QueryableStateClient client = new QueryableStateClient(config);` * remove use of `TestingUtils` as it is only available to

[GitHub] flink pull request #4033: [FLINK-6784][docs] update externalized checkpoints...

2017-05-31 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4033 [FLINK-6784][docs] update externalized checkpoints documentation please also merge into `master` You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink issue #4033: [FLINK-6784][docs] update externalized checkpoints docume...

2017-05-31 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4033 playing around with this some more, I'd like to add some more text about the directory structure and restore --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #4033: [FLINK-6784][docs] update externalized checkpoints docume...

2017-05-31 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4033 Thanks, I addressed your comments and added some new sections which make the documentation more complete --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #4032: [Proposal] Gradually introduce checkstyle into flink-runt...

2017-06-01 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4032 nice - on the way to finally getting a more consistent codebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #4024: [FLINK-6782][docs] update snapshot documentation to refle...

2017-06-01 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4024 Deleting a savepoint will not affect other savepoints in case you are worried about this. Other than that it depends on you and what you want to do with it, e.g. keeping it in case you want to

[GitHub] flink issue #4024: [FLINK-6782][docs] update snapshot documentation to refle...

2017-06-01 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4024 Personally, I would wait at least for another completed checkpoint before deleting a savepoint but from what I read, I would probably also always keep a savepoint around to recover from. I guess that

[GitHub] flink pull request #4080: [FLINK-6798][docs] update old network buffer notic...

2017-06-06 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4080 [FLINK-6798][docs] update old network buffer notices please also apply to `master` when accepting this PR You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request #4146: [FLINK-6008] collection of BlobServer improvements

2017-06-20 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4146 [FLINK-6008] collection of BlobServer improvements This PR is a light-weight version of #3512 that only includes the improvements and can serve as a base for FLIP-19. It improves the following

[GitHub] flink issue #3512: [FLINK-6008] collection of BlobServer improvements

2017-06-20 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3512 let's include the improvements in a separate PR #4146 and drop the feature additions for a re-work in FLIP-19 --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #3512: [FLINK-6008] collection of BlobServer improvements

2017-06-20 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/3512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4146: [FLINK-6008] collection of BlobServer improvements

2017-06-21 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4146 please note that there are four unrelated test failures: * 2x Kafka010ITCase * 2x YARNSessionCapacitySchedulerITCase --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #4158: [FLINK-6916][blob] remove (unused) NAME_ADDRESSABL...

2017-06-21 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4158 [FLINK-6916][blob] remove (unused) NAME_ADDRESSABLE mode This is based upon #4146 and in addition removes the currently unused `NAME_ADDRESSABLE` BLOB addressing mode. There are currently no plans to

[GitHub] flink issue #4416: [FLINK-7279][minicluster] fix a deadlock between TM and c...

2017-07-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4416 ok, I think, I understood the intention of `TaskExecutor#onFatalErrorAsync` wrong - it is meant for outside `TaskExecutor` thread calls to run the error handler inside the `TaskExecutor` thread

[GitHub] flink pull request #4334: [FLINK-7191] Activate checkstyle flink-java/operat...

2017-07-31 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4334#discussion_r130292761 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/translation/PlanProjectOperator.java --- @@ -27,30 +27,32 @@ import

[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...

2017-07-31 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4309 did the rebase and it looks good :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #4445: [FLINK-7310][core] always use the HybridMemorySegm...

2017-08-01 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4445 [FLINK-7310][core] always use the HybridMemorySegment ## What is the purpose of the change Since we'd like to use our own off-heap buffers for network communication, we canno

[GitHub] flink pull request #4446: [FLINK-7311][tests] refrain from using `fail(Excep...

2017-08-01 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4446 [FLINK-7311][tests] refrain from using `fail(Exception#getMessage())` ## What is the purpose of the change Refrain from using `fail(Exception#getMessage())` because it hides the exception&#

[GitHub] flink pull request #4447: [FLINK-7312][checkstyle] activate checkstyle for f...

2017-08-01 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4447 [FLINK-7312][checkstyle] activate checkstyle for flink/core/memory/* ## What is the purpose of the change Activate checkstyle for `flink/core/memory/*`. This PR is based on #4446

[GitHub] flink pull request #4451: [hotfix][tests] increase timeout in ExecutionGraph...

2017-08-01 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4451 [hotfix][tests] increase timeout in ExecutionGraphRestartTest ## What is the purpose of the change On rare occasions, TravisCI hit the default timeout waiting for job status changes in

[GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...

2017-08-01 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4447 FYI: the `final` keyword on methods in `final` classes is something that is actually forbidden by the checkstyle, hence the change Regarding the try-catch in tests (actually part of #4446

[GitHub] flink issue #4456: [FLINK-7343][kafka] Increase Xmx for tests

2017-08-02 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4456 yes, seems like it was changed from `-Xmx800m` to `-Xmx1536m` by FLINK-6128 and again to `-Xmx2048m` by FLINK-7004 without changing it here. The question should rather be whether we need the

[GitHub] flink issue #4446: [FLINK-7311][tests] refrain from using fail(Exception#get...

2017-08-02 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4446 actually, the FLINK-7311 commit also cleanly applies to master (without FLINK-7310 that this PR is based on). Should I rebase? --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #4451: [hotfix][tests] increase timeout in ExecutionGraphRestart...

2017-08-02 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4451 good question - but I encounter this test failure in 1.3.2 RC2, too - let me create a JIRA for this nonetheless to investigate further --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #4451: [hotfix][tests] increase timeout in ExecutionGraph...

2017-08-02 Thread NicoK
Github user NicoK closed the pull request at: https://github.com/apache/flink/pull/4451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4451: [hotfix][tests] increase timeout in ExecutionGraphRestart...

2017-08-02 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4451 Please see https://issues.apache.org/jira/browse/FLINK-7352 and it seems you are right - increased timeouts do not solve this issue. --- If your project is set up for it, you can reply to this email

<    1   2   3   4   5   6   7   8   9   10   >