Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4735#discussion_r141660623
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java
 ---
    @@ -400,6 +399,23 @@ private int getNumRequestedFromMemorySegmentPool() {
                return networkBufferPool.getTotalNumberOfMemorySegments() - 
networkBufferPool.getNumberOfAvailableMemorySegments();
        }
     
    +   private BufferListener createBufferListener(int notificationTimes) {
    +           return spy(new BufferListener() {
    +                   int times = 0;
    +
    +                   @Override
    +                   public boolean notifyBufferAvailable(Buffer buffer) {
    +                           times++;
    +                           buffer.recycle();
    --- End diff --
    
    nice trick with the `recycle()` call here leading to another invocation or 
the release of the buffer


---

Reply via email to