Re: [PR] [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
afedulov commented on PR #25794: URL: https://github.com/apache/flink/pull/25794#issuecomment-2575271473 @mehdid93 after the new CI images has been merged, this PR's CI is green. Could you please rebase the rest of the PRs you lister [here](https://issues.apache.org/jira/browse/FLINK-36716?

Re: [PR] [FLINK-35137][Connectors/JDBC] Update website data for 3.2.0 [flink-connector-jdbc]

2025-01-07 Thread via GitHub
JohnMa123 commented on PR #152: URL: https://github.com/apache/flink-connector-jdbc/pull/152#issuecomment-2575042911 An incorrect pull request was submitted, please close it. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r190186 ## flink-python/pyflink/table/expressions.py: ## @@ -306,19 +306,38 @@ def to_timestamp(timestamp_str: Union[str, Expression[str]], return _binary_op("toTim

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r190186 ## flink-python/pyflink/table/expressions.py: ## @@ -306,19 +306,38 @@ def to_timestamp(timestamp_str: Union[str, Expression[str]], return _binary_op("toTim

Re: [PR] [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
mehdid93 commented on PR #25794: URL: https://github.com/apache/flink/pull/25794#issuecomment-2575497633 @afedulov Thank a lot! I've rebased this PR should be fine now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Assigned] (FLINK-37025) Periodic SQL watermarks can travel back in time

2025-01-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-37025: Assignee: Dawid Wysakowicz > Periodic SQL watermarks can travel back in time > --

Re: [PR] [FLINK-36647][transform] Support Timestampdiff and Timestampadd function in cdc pipeline transform [flink-cdc]

2025-01-07 Thread via GitHub
aiwenmo commented on PR #3698: URL: https://github.com/apache/flink-cdc/pull/3698#issuecomment-2575405739 PTAL @yuxiqian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-36610] MySQL CDC supports parsing gh-ost / pt-osc generated schema changes [flink-cdc]

2025-01-07 Thread via GitHub
GOODBOY008 commented on code in PR #3668: URL: https://github.com/apache/flink-cdc/pull/3668#discussion_r1905613729 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/RecordUtils.java: ## @@

[PR] [FLINK-37024][task] Make cancel watchdog cover tasks stuck in DEPLOYING state [flink]

2025-01-07 Thread via GitHub
X-czh opened a new pull request, #25915: URL: https://github.com/apache/flink/pull/25915 ## What is the purpose of the change Fix the issue that task can be stuck in deploying state forever when canceling job/failover. ## Brief change log Make cancel watchdog cov

[jira] [Updated] (FLINK-37024) Task can be stuck in deploying state forever when canceling job/failover

2025-01-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37024: --- Labels: pull-request-available (was: ) > Task can be stuck in deploying state forever when

[jira] [Created] (FLINK-37024) Task can be stuck in deploying state forever when canceling job/failover

2025-01-07 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-37024: - Summary: Task can be stuck in deploying state forever when canceling job/failover Key: FLINK-37024 URL: https://issues.apache.org/jira/browse/FLINK-37024 Project: F

Re: [PR] [FLINK-36576][runtime] Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider [flink]

2025-01-07 Thread via GitHub
noorall commented on PR #25552: URL: https://github.com/apache/flink/pull/25552#issuecomment-2575121705 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36610] MySQL CDC supports parsing gh-ost / pt-osc generated schema changes [flink-cdc]

2025-01-07 Thread via GitHub
lvyanquan commented on code in PR #3668: URL: https://github.com/apache/flink-cdc/pull/3668#discussion_r1905359170 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/RecordUtils.java: ## @@

Re: [PR] [FLINK-36610] MySQL CDC supports parsing gh-ost / pt-osc generated schema changes [flink-cdc]

2025-01-07 Thread via GitHub
lvyanquan commented on code in PR #3668: URL: https://github.com/apache/flink-cdc/pull/3668#discussion_r1905378005 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/RecordUtils.java: ## @@

Re: [PR] [FLINK-36701][cdc-runtime] Add steps to get and emit schemaManager's latest evolvedSchema when SinkDataWriterOperator handles FlushEvent [flink-cdc]

2025-01-07 Thread via GitHub
yuxiqian commented on code in PR #3802: URL: https://github.com/apache/flink-cdc/pull/3802#discussion_r1905043255 ## flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/OceanBaseE2eITCase.java: ## Review Comment: Maybe this cha

Re: [PR] [FLINK-35737] Prevent Memory Leak by Closing MemoryExecutionGraphInfoStore on MiniCluster Shutdown [flink]

2025-01-07 Thread via GitHub
fengjiajie closed pull request #25009: [FLINK-35737] Prevent Memory Leak by Closing MemoryExecutionGraphInfoStore on MiniCluster Shutdown URL: https://github.com/apache/flink/pull/25009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36610] MySQL CDC supports parsing gh-ost / pt-osc generated schema changes [flink-cdc]

2025-01-07 Thread via GitHub
lvyanquan commented on code in PR #3668: URL: https://github.com/apache/flink-cdc/pull/3668#discussion_r1905385783 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java

Re: [PR] [FLINK-36282][pipeline-connector][cdc-connector][mysql]fix incorrect data type of TINYINT(1) in mysql pipeline connector [flink-cdc]

2025-01-07 Thread via GitHub
GOODBOY008 commented on PR #3608: URL: https://github.com/apache/flink-cdc/pull/3608#issuecomment-2575253151 @qg-lin Can you rebase your branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2025-01-07 Thread via GitHub
afedulov commented on PR #25830: URL: https://github.com/apache/flink/pull/25830#issuecomment-2575270221 @mehdid93 after the new CI images has been merged, this PR's CI is green. Could you please rebase the rest of the PRs you lister [here](https://issues.apache.org/jira/browse/FLINK-36716?

[jira] [Created] (FLINK-37025) Periodic SQL watermarks can travel back in time

2025-01-07 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-37025: Summary: Periodic SQL watermarks can travel back in time Key: FLINK-37025 URL: https://issues.apache.org/jira/browse/FLINK-37025 Project: Flink Issue

[jira] [Updated] (FLINK-37025) Periodic SQL watermarks can travel back in time

2025-01-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-37025: - Description: If watermarks are generated through SQL, e.g. using {{WATERMARK FOR ts AS t

[jira] [Updated] (FLINK-37025) Periodic SQL watermarks can travel back in time

2025-01-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-37025: - Description: If watermarks are generated through SQL, e.g. using `WATERMARK FOR ts AS ts

Re: [PR] [FLINK-36608][table-runtime] Support dynamic StreamGraph optimization for AdaptiveBroadcastJoinOperator [flink]

2025-01-07 Thread via GitHub
SinBex commented on code in PR #25822: URL: https://github.com/apache/flink/pull/25822#discussion_r1905533782 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/DefaultStreamGraphContext.java: ## @@ -140,6 +152,33 @@ public boolean modifyStreamEdge(List request

Re: [PR] [FLINK-37010][Runtime] Unify KeyedProcessFunction and the async one [flink]

2025-01-07 Thread via GitHub
Zakelly commented on PR #25901: URL: https://github.com/apache/flink/pull/25901#issuecomment-2575644980 I'm merging this since the #25717 is waiting on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
afedulov commented on PR #25794: URL: https://github.com/apache/flink/pull/25794#issuecomment-2575610818 Well, I actually already took the liberty to rebase your remote branch hence the CI for this particular PR is already green: `30b7551 Azure: SUCCESS` My ask is more for the remainin

Re: [PR] [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
mehdid93 commented on PR #25794: URL: https://github.com/apache/flink/pull/25794#issuecomment-2575617240 @afedulov Ah sorry I've misunderstand you, yes once this PR is merged I'll rebase both of PRs since this is a must for the next step -- This is an automated message from the Apache Git

[PR] [BP-1.19][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
mehdid93 opened a new pull request, #25912: URL: https://github.com/apache/flink/pull/25912 Contribute-to: https://issues.apache.org/jira/browse/FLINK-36901 ## What is the purpose of the change This pull request raises the version of the NodeJS module which is a pre-req

[PR] [BP-1.19][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-07 Thread via GitHub
mehdid93 opened a new pull request, #25911: URL: https://github.com/apache/flink/pull/25911 ## What is the purpose of the change This PR backport the changes done of the PR made by @zentol (https://github.com/apache/flink/pull/25708) in master for version 1.19.X to be used in depende

[jira] [Updated] (FLINK-37023) Rest API returns 500 error with CancellationException

2025-01-07 Thread amjidc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] amjidc updated FLINK-37023: --- Description: We have probes that call JobManager rest API regularly, and these API calls are failing interm

Re: [PR] [FLINK-36898][Table] Support SQL FLOOR and CEIL functions with NanoSecond and MicroSecond for TIMESTAMP_TLZ [flink]

2025-01-07 Thread via GitHub
snuyanzin commented on PR #25897: URL: https://github.com/apache/flink/pull/25897#issuecomment-2575312634 @hanyuzheng7 thanks for the PR would be also great if you fill the PR form -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905566167 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905760221 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java: ## @@ -366,6 +366,61 @@ public static ApiExpression toTimestampLtz(Obje

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905775954 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzTypeStrategy.java: ## @@ -20,22 +20,79 @@ import or

[jira] [Updated] (FLINK-37025) Periodic SQL watermarks can travel back in time

2025-01-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-37025: - Description: If watermarks are generated through SQL, e.g. using `WATERMARK FOR ts AS ts

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905549176 ## docs/data/sql_functions_zh.yml: ## @@ -805,11 +805,12 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: 将

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905566167 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905775954 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzTypeStrategy.java: ## @@ -20,22 +20,79 @@ import or

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2025-01-07 Thread via GitHub
gyfora commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1905783988 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -89,21 +89,41 @@ private static ConfigOptions.OptionB

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2025-01-07 Thread via GitHub
gyfora commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1905782327 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -89,21 +89,41 @@ private static ConfigOptions.OptionB

Re: [PR] [FLINK-36486] [TABLE SQL/API] Remove deprecated methods StreamTableEnvironment.registerDataStream from flink-table-api-java-bridge module [flink]

2025-01-07 Thread via GitHub
sn-12-3 commented on PR #25527: URL: https://github.com/apache/flink/pull/25527#issuecomment-2575797787 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-36486) Remove deprecated method `StreamTableEnvironment#registerDataStream`

2025-01-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36486: --- Labels: pull-request-available (was: ) > Remove deprecated method `StreamTableEnvironment#r

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905775954 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzTypeStrategy.java: ## @@ -20,22 +20,79 @@ import or

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
davidradl commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905775954 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzTypeStrategy.java: ## @@ -20,22 +20,79 @@ import or

Re: [PR] [FLINK-36610] MySQL CDC supports parsing gh-ost / pt-osc generated schema changes [flink-cdc]

2025-01-07 Thread via GitHub
lvyanquan commented on PR #3668: URL: https://github.com/apache/flink-cdc/pull/3668#issuecomment-2575213081 Hi @leonardBang, @ruanhang1993 could you please help to trigger CI check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Updated] (FLINK-37024) Task can be stuck in deploying state forever when canceling job/failover

2025-01-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-37024: -- Description: We observed that task can be stuck in deploying state forever when the task loadi

Re: [PR] [FLINK-36898][Table] Support SQL FLOOR and CEIL functions with NanoSecond and MicroSecond for TIMESTAMP_TLZ [flink]

2025-01-07 Thread via GitHub
snuyanzin commented on code in PR #25897: URL: https://github.com/apache/flink/pull/25897#discussion_r1905510096 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -588,34 +588,50 @@ private Stream ceilTestCa

[PR] [BP-1.19][FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2025-01-07 Thread via GitHub
mehdid93 opened a new pull request, #25913: URL: https://github.com/apache/flink/pull/25913 ## What is the purpose of the change This PR backport the changes done of the PR made by @simplejason (https://github.com/apache/flink/pull/25713) in master for version 1.19.X to be used in de

Re: [PR] [BP-1.19][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-07 Thread via GitHub
flinkbot commented on PR #25911: URL: https://github.com/apache/flink/pull/25911#issuecomment-2575635100 ## CI report: * b40da18b765c3307b3d0ee7aa39f072aedc7a4ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.19][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
flinkbot commented on PR #25912: URL: https://github.com/apache/flink/pull/25912#issuecomment-2575635372 ## CI report: * c95dfa1d057017df4226527dea675db6d2d69445 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.19][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2025-01-07 Thread via GitHub
mehdid93 opened a new pull request, #25914: URL: https://github.com/apache/flink/pull/25914 ## What is the purpose of the change This PR backport the changes done of the PR made by me in (https://github.com/apache/flink/pull/25718) in master for version 1.20.X to be used in dependenc

Re: [PR] [BP-1.19][FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2025-01-07 Thread via GitHub
flinkbot commented on PR #25913: URL: https://github.com/apache/flink/pull/25913#issuecomment-2575660028 ## CI report: * 6b81d20ec3c688cee63816cfb48a98f4a89cbf3e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-37026) Enable Stale PR Github Action

2025-01-07 Thread Thomas Cooper (Jira)
Thomas Cooper created FLINK-37026: - Summary: Enable Stale PR Github Action Key: FLINK-37026 URL: https://issues.apache.org/jira/browse/FLINK-37026 Project: Flink Issue Type: Improvement

Re: [PR] [BP-1.19][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2025-01-07 Thread via GitHub
flinkbot commented on PR #25914: URL: https://github.com/apache/flink/pull/25914#issuecomment-2575673473 ## CI report: * e0cbfe6ff83e452be18527edbbaf3812686f0174 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37024][task] Make cancel watchdog cover tasks stuck in DEPLOYING state [flink]

2025-01-07 Thread via GitHub
flinkbot commented on PR #25915: URL: https://github.com/apache/flink/pull/25915#issuecomment-2575864735 ## CI report: * 787e6aa43e7dd3f591169b979b4df181613e30d9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-37018) Adaptive scheduler triggers multiple internal restarts for a single rescale event

2025-01-07 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910724#comment-17910724 ] Sai Sharath Dandi commented on FLINK-37018: --- Hi [~heigebupahei] , thanks a lot

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905955530 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzTypeStrategy.java: ## @@ -20,22 +20,79 @@ import or

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905956028 ## docs/data/sql_functions_zh.yml: ## @@ -805,11 +805,12 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: 将

Re: [PR] [FLINK-36181] Use Java 17 by default [flink]

2025-01-07 Thread via GitHub
MartijnVisser commented on code in PR #25898: URL: https://github.com/apache/flink/pull/25898#discussion_r1906000962 ## pom.xml: ## @@ -124,7 +124,7 @@ under the License. 2.15.3 2.7.0 true - 11 + 17 R

Re: [PR] [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
afedulov merged PR #25794: URL: https://github.com/apache/flink/pull/25794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905915205 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905915205 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

[jira] [Commented] (FLINK-3154) Update Kryo version from 2.24.0 to latest Kryo LTS version

2025-01-07 Thread Kurt Ostfeld (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910793#comment-17910793 ] Kurt Ostfeld commented on FLINK-3154: - The PR is ready: [https://github.com/apache/fl

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 [flink]

2025-01-07 Thread via GitHub
piotrp commented on code in PR #25813: URL: https://github.com/apache/flink/pull/25813#discussion_r1906122497 ## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ## @@ -45,7 +45,13 @@ public class MdcUtils { public static MdcCloseable withContext(Map context) {

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 [flink]

2025-01-07 Thread via GitHub
piotrp commented on code in PR #25813: URL: https://github.com/apache/flink/pull/25813#discussion_r1906123080 ## flink-core/pom.xml: ## @@ -180,6 +180,13 @@ under the License. test + Review Comment: Thanks for checkin

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 [flink]

2025-01-07 Thread via GitHub
piotrp commented on code in PR #25813: URL: https://github.com/apache/flink/pull/25813#discussion_r1906118440 ## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ## @@ -45,7 +45,13 @@ public class MdcUtils { public static MdcCloseable withContext(Map context) {

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 [flink]

2025-01-07 Thread via GitHub
afedulov commented on code in PR #25813: URL: https://github.com/apache/flink/pull/25813#discussion_r1906119278 ## flink-core/src/main/java/org/apache/flink/util/MdcUtils.java: ## @@ -45,7 +45,13 @@ public class MdcUtils { public static MdcCloseable withContext(Map context)

Re: [PR] [FLINK-36976] Upgrade jackson from 2.15.3 to 2.18.2 [flink]

2025-01-07 Thread via GitHub
snuyanzin merged PR #25865: URL: https://github.com/apache/flink/pull/25865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36181] Use Java 17 by default [flink]

2025-01-07 Thread via GitHub
snuyanzin commented on code in PR #25898: URL: https://github.com/apache/flink/pull/25898#discussion_r1906139229 ## pom.xml: ## @@ -124,7 +124,7 @@ under the License. 2.15.3 2.7.0 true - 11 + 17 Revie

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1906146745 ## flink-python/pyflink/table/expressions.py: ## @@ -306,19 +306,38 @@ def to_timestamp(timestamp_str: Union[str, Expression[str]], return _binary_op("toTim

Re: [PR] [FLINK-36181] Use Java 17 by default [flink]

2025-01-07 Thread via GitHub
snuyanzin commented on code in PR #25898: URL: https://github.com/apache/flink/pull/25898#discussion_r1906152062 ## pom.xml: ## @@ -124,7 +124,7 @@ under the License. 2.15.3 2.7.0 true - 11 + 17 Revie

Re: [PR] [FLINK-36181] Use Java 17 by default [flink]

2025-01-07 Thread via GitHub
snuyanzin commented on code in PR #25898: URL: https://github.com/apache/flink/pull/25898#discussion_r1906152062 ## pom.xml: ## @@ -124,7 +124,7 @@ under the License. 2.15.3 2.7.0 true - 11 + 17 Revie

Re: [PR] [FLINK-36181] Use Java 17 by default [flink]

2025-01-07 Thread via GitHub
snuyanzin commented on code in PR #25898: URL: https://github.com/apache/flink/pull/25898#discussion_r1906153824 ## pom.xml: ## @@ -124,7 +124,7 @@ under the License. 2.15.3 2.7.0 true - 11 + 17 Revie

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905915205 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905915205 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905915205 ## flink-python/pyflink/table/tests/test_expression.py: ## @@ -285,7 +285,14 @@ def test_expressions(self): self.assertEqual("toDate('2018-03-18')", str(to_d

[jira] [Created] (FLINK-37027) Chinese document translation for additional TO_TIMESTAMP_LTZ() functions

2025-01-07 Thread Yiyu Tian (Jira)
Yiyu Tian created FLINK-37027: - Summary: Chinese document translation for additional TO_TIMESTAMP_LTZ() functions Key: FLINK-37027 URL: https://issues.apache.org/jira/browse/FLINK-37027 Project: Flink

[jira] [Updated] (FLINK-35721) I found out that in the Flink SQL documentation it says that Double type cannot be converted to Boolean type, but in reality, it can.

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35721: -- Component/s: Documentation > I found out that in the Flink SQL documentation it says t

Re: [PR] [FLINK-37007][table] Add missing createView methods to TableEnvironment [flink]

2025-01-07 Thread via GitHub
snuyanzin closed pull request #25907: [FLINK-37007][table] Add missing createView methods to TableEnvironment URL: https://github.com/apache/flink/pull/25907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (FLINK-36113) Condition 'transform instanceof PhysicalTransformation' is always 'false'

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910816#comment-17910816 ] Alexander Fedulov edited comment on FLINK-36113 at 1/7/25 9:48 PM: ---

[jira] [Commented] (FLINK-36113) Condition 'transform instanceof PhysicalTransformation' is always 'false'

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910816#comment-17910816 ] Alexander Fedulov commented on FLINK-36113: --- [~tiancx] please provide some add

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905971151 ## docs/data/sql_functions_zh.yml: ## @@ -805,11 +805,12 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: 将

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-07 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1905956028 ## docs/data/sql_functions_zh.yml: ## @@ -805,11 +805,12 @@ temporal: - sql: TO_DATE(string1[, string2]) table: toDate(STRING1[, STRING2]) description: 将

[jira] [Commented] (FLINK-35453) StreamReader Charset fix with UTF8 in core files

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910818#comment-17910818 ] Alexander Fedulov commented on FLINK-35453: --- [~xuzifu] is this still relevant?

Re: [PR] [FLINK-36835][flink-s3-fs-hadoop] Fix memory lease in flink-s3-fs-hadoop [flink]

2025-01-07 Thread via GitHub
afedulov commented on PR #25725: URL: https://github.com/apache/flink/pull/25725#issuecomment-2576308940 This seems like something that needs to be fixed in upstream Hadoop. Closing unless there are further details provided why Flink has to contain this class. -- This is an automated mess

Re: [PR] [FLINK-36835][flink-s3-fs-hadoop] Fix memory lease in flink-s3-fs-hadoop [flink]

2025-01-07 Thread via GitHub
afedulov closed pull request #25725: [FLINK-36835][flink-s3-fs-hadoop] Fix memory lease in flink-s3-fs-hadoop URL: https://github.com/apache/flink/pull/25725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Closed] (FLINK-36835) Memory lease in flink-s3-fs module due to hadoop aws version 3.x

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov closed FLINK-36835. - Fix Version/s: (was: 1.20.1) Resolution: Won't Fix > Memory lease in flink-s3

[jira] [Commented] (FLINK-36835) Memory lease in flink-s3-fs module due to hadoop aws version 3.x

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910825#comment-17910825 ] Alexander Fedulov commented on FLINK-36835: --- This looks like something that ne

[jira] [Commented] (FLINK-36735) SupportsRowLevelUpdate gives sink only the values of required columns when specifying RowLevelUpdateInfo#requiredColumns

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910827#comment-17910827 ] Alexander Fedulov commented on FLINK-36735: --- [~jark] [~luoyuxia] since there a

Re: [PR] [BP-1.20][FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2025-01-07 Thread via GitHub
afedulov commented on PR #25829: URL: https://github.com/apache/flink/pull/25829#issuecomment-2576206371 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2025-01-07 Thread via GitHub
afedulov commented on PR #25830: URL: https://github.com/apache/flink/pull/25830#issuecomment-2576210755 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-36739) Update NodeJS to v22 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910799#comment-17910799 ] Alexander Fedulov edited comment on FLINK-36739 at 1/7/25 8:45 PM: ---

[jira] [Updated] (FLINK-36739) Update NodeJS to v22 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-36739: -- Fix Version/s: 1.20.1 > Update NodeJS to v22 (LTS) > -- > >

[jira] [Commented] (FLINK-36739) Update NodeJS to v22 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910799#comment-17910799 ] Alexander Fedulov commented on FLINK-36739: --- *Backported* {*}to release-1.20{*

[jira] [Commented] (FLINK-36901) [Backport] Update the NodeJS to v22.11.0 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910801#comment-17910801 ] Alexander Fedulov commented on FLINK-36901: --- [~mehdidb1993] fyi, we usually do

[jira] [Comment Edited] (FLINK-36739) Update NodeJS to v22 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910799#comment-17910799 ] Alexander Fedulov edited comment on FLINK-36739 at 1/7/25 8:48 PM: ---

[jira] [Closed] (FLINK-36901) [Backport] Update the NodeJS to v22.11.0 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov closed FLINK-36901. - Assignee: Mehdi Resolution: Fixed > [Backport] Update the NodeJS to v22.11.0 (LTS)

[jira] [Commented] (FLINK-36901) [Backport] Update the NodeJS to v22.11.0 (LTS)

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910800#comment-17910800 ] Alexander Fedulov commented on FLINK-36901: --- Backport tracked in https://issue

Re: [PR] [BP-1.19][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-07 Thread via GitHub
davidradl commented on PR #25912: URL: https://github.com/apache/flink/pull/25912#issuecomment-2576238743 @mehdid93 CI is failing in the web ui , I assume the pipeline change is not there for 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2025-01-07 Thread via GitHub
davidradl commented on PR #25830: URL: https://github.com/apache/flink/pull/25830#issuecomment-2576241527 waiting for a clean CI then will approve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (FLINK-36835) Memory lease in flink-s3-fs module due to hadoop aws version 3.x

2025-01-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910825#comment-17910825 ] Alexander Fedulov edited comment on FLINK-36835 at 1/7/25 10:11 PM: --

  1   2   3   4   >