Re: [PR] Enable async profiler [flink-benchmarks]

2024-06-11 Thread via GitHub
Zakelly merged PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-32091][checkpoint] Add file size metrics for file-merging [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24922: URL: https://github.com/apache/flink/pull/24922#issuecomment-2162053937 ## CI report: * 3405d0cc2c400c9c2d3a596b600b2ebda07af2f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] MailboxProcessor#processMailsWhenDefaultActionUnavailable avoids allocating Optional [flink]

2024-06-11 Thread via GitHub
schlosna opened a new pull request, #24923: URL: https://github.com/apache/flink/pull/24923 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[jira] [Created] (FLINK-35570) Consider PlaceholderStreamStateHandle in checkpoint file merging

2024-06-11 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-35570: --- Summary: Consider PlaceholderStreamStateHandle in checkpoint file merging Key: FLINK-35570 URL: https://issues.apache.org/jira/browse/FLINK-35570 Project: Flink

[PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-11 Thread via GitHub
Zakelly opened a new pull request, #24924: URL: https://github.com/apache/flink/pull/24924 ## What is the purpose of the change In checkpoint file merging, we should take `PlaceholderStreamStateHandle` into account during lifecycle, since it can be a file merged one. ## Brief c

[jira] [Updated] (FLINK-35570) Consider PlaceholderStreamStateHandle in checkpoint file merging

2024-06-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35570: --- Labels: pull-request-available (was: ) > Consider PlaceholderStreamStateHandle in checkpoin

[jira] [Commented] (FLINK-34123) Introduce built-in serialization support for Map and List

2024-06-11 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854242#comment-17854242 ] Zhanghao Chen commented on FLINK-34123: --- Will revert it as it breaks state-compati

[PR] Revert FLINK-34123&35068: Add built-in dedicated serialization support for Maps, Lists, Sets, and Collections [flink]

2024-06-11 Thread via GitHub
X-czh opened a new pull request, #24925: URL: https://github.com/apache/flink/pull/24925 ## What is the purpose of the change Reverting previous changes that break state compatibility. [FLINK-34123](https://issues.apache.org/jira/browse/FLINK-34123) & [FLINK-35068](https://issu

[jira] [Commented] (FLINK-35068) Introduce built-in serialization support for Set

2024-06-11 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854247#comment-17854247 ] Zhanghao Chen commented on FLINK-35068: --- Will revert it as it breaks state-compati

Re: [PR] MailboxProcessor#processMailsWhenDefaultActionUnavailable avoids allocating Optional [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24923: URL: https://github.com/apache/flink/pull/24923#issuecomment-2162103603 ## CI report: * 88f9a4cf7a8e79d861755262f84f91a4b1b0d026 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24924: URL: https://github.com/apache/flink/pull/24924#issuecomment-2162103785 ## CI report: * 9ce0a6f2bb299224ed170ce0944de94703253b81 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Revert [FLINK-34123][FLINK-35068]: Add built-in dedicated serialization support for Maps, Lists, Sets, and Collections [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24925: URL: https://github.com/apache/flink/pull/24925#issuecomment-2162103966 ## CI report: * e5d84501e6a2781205494bf429c29e1afe0d4031 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-06-11 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854253#comment-17854253 ] Hongshun Wang commented on FLINK-35121: --- [~kwafor] , Sorry, I have done it > CDC

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-11 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158609 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-11 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158973 @gaborgsomogyi I have addressed the comment, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-11 Thread via GitHub
fredia commented on code in PR #24924: URL: https://github.com/apache/flink/pull/24924#discussion_r1635853720 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -167,22 +166,25 @@ private void verifyStateHandleType

Re: [PR] [fix][cdc-connector][mysql] Fix NoClassDefFoundError when create new table in mysql cdc source [flink-cdc]

2024-06-11 Thread via GitHub
yuxiqian commented on PR #3036: URL: https://github.com/apache/flink-cdc/pull/3036#issuecomment-2162171729 Hi @pengmide, could you please rebase this PR with latest `master` branch before it could be merged? Thanks! -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn [flink]

2024-06-11 Thread via GitHub
TanYuxin-tyx commented on code in PR #24900: URL: https://github.com/apache/flink/pull/24900#discussion_r1635860182 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/NettyShuffleDescriptorBuilder.java: ## @@ -80,8 +83,14 @@ public NettyShuffleDescriptor buildRemote()

[PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-11 Thread via GitHub
loserwang1024 opened a new pull request, #3412: URL: https://github.com/apache/flink-cdc/pull/3412 CDC pipeline connector provide ability to verify requiredOptions and optionalOptions, nor will be hard to handle compatibility later。 -- This is an automated message from the Apache Git Ser

Re: [PR] [FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn [flink]

2024-06-11 Thread via GitHub
TanYuxin-tyx commented on code in PR #24900: URL: https://github.com/apache/flink/pull/24900#discussion_r1635866275 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -490,6 +490,24 @@ public enum CompressionCodec {

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-11 Thread via GitHub
joyCurry30 commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635870700 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related configuratio

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-11 Thread via GitHub
yuxiqian commented on PR #3412: URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2162196171 Seems there's some overlap between this PR and #3382, @loserwang1024 mind if I cherry pick your commit? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-35571) ProfilingServiceTest.testRollingDeletion intermittently fails due to improper test isolation

2024-06-11 Thread Grace Grimwood (Jira)
Grace Grimwood created FLINK-35571: -- Summary: ProfilingServiceTest.testRollingDeletion intermittently fails due to improper test isolation Key: FLINK-35571 URL: https://issues.apache.org/jira/browse/FLINK-35571

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-11 Thread via GitHub
yuxiqian commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635883374 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related configurations

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-11 Thread via GitHub
yuxiqian commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635883374 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related configurations

[jira] [Updated] (FLINK-35571) ProfilingServiceTest.testRollingDeletion intermittently fails due to improper test isolation

2024-06-11 Thread Grace Grimwood (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grace Grimwood updated FLINK-35571: --- Attachment: (was: 20240612_181148_mvn-clean-package_flink-runtime_also-make.log) > Prof

[jira] [Updated] (FLINK-35571) ProfilingServiceTest.testRollingDeletion intermittently fails due to improper test isolation

2024-06-11 Thread Grace Grimwood (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grace Grimwood updated FLINK-35571: --- Attachment: 20240612_181148_mvn-clean-package_flink-runtime.log > ProfilingServiceTest.testR

[jira] [Created] (FLINK-35572) flink db2 cdc default value error

2024-06-11 Thread junxin lai (Jira)
junxin lai created FLINK-35572: --- Summary: flink db2 cdc default value error Key: FLINK-35572 URL: https://issues.apache.org/jira/browse/FLINK-35572 Project: Flink Issue Type: Bug Co

<    1   2