Re: [PR] [BP-3.1.1][FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink (#3233) [flink-cdc]

2024-06-04 Thread via GitHub
loserwang1024 commented on PR #3387: URL: https://github.com/apache/flink-cdc/pull/3387#issuecomment-2148735709 @PatrickRen , CC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35200][table] Support the execution of suspend, resume materialized table in full refresh mode [flink]

2024-06-04 Thread via GitHub
lsyldliu closed pull request #24877: [FLINK-35200][table] Support the execution of suspend, resume materialized table in full refresh mode URL: https://github.com/apache/flink/pull/24877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (FLINK-35201) Support the execution of drop materialized table in full refresh mode

2024-06-04 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35201: - Assignee: Feng Jin > Support the execution of drop materialized table in full refresh mode > --

[jira] [Resolved] (FLINK-35200) Support the execution of suspend, resume materialized table in full refresh mode

2024-06-04 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-35200. --- Resolution: Fixed > Support the execution of suspend, resume materialized table in full refresh > m

[jira] [Commented] (FLINK-35200) Support the execution of suspend, resume materialized table in full refresh mode

2024-06-04 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852245#comment-17852245 ] dalongliu commented on FLINK-35200: --- Merged in master: 8d1e043b0c4277582b8862c2bc33146

Re: [PR] [FLINK-35325][cdc-connector][paimon]Support for specifying column order. [flink-cdc]

2024-06-04 Thread via GitHub
leonardBang merged PR #3323: URL: https://github.com/apache/flink-cdc/pull/3323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-04 Thread via GitHub
Jiabao-Sun commented on code in PR #24881: URL: https://github.com/apache/flink/pull/24881#discussion_r1626824660 ## flink-core/src/test/java/org/apache/flink/core/fs/AutoCloseableRegistryTest.java: ## @@ -66,9 +64,9 @@ public void testSuppressedExceptions() throws Exception {

[jira] [Assigned] (FLINK-35325) Paimon connector miss the position of AddColumnEvent

2024-06-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35325: -- Assignee: tianzhu.wen > Paimon connector miss the position of AddColumnEvent > --

[jira] [Resolved] (FLINK-35325) Paimon connector miss the position of AddColumnEvent

2024-06-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35325. Resolution: Implemented via flink-cdc master: 02141660490855b033583e711152059c7652410f > Paimon c

Re: [PR] [FLINK-35522][runtime] Fix the issue that the source task may get stuck in speculative execution mode. [flink]

2024-06-04 Thread via GitHub
flinkbot commented on PR #24887: URL: https://github.com/apache/flink/pull/24887#issuecomment-2148750895 ## CI report: * 40cb30f959a9a400f76b7e8b535d54d9594b4e5b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34482][checkpoint] Rename checkpointing options [flink]

2024-06-04 Thread via GitHub
Zakelly commented on code in PR #24878: URL: https://github.com/apache/flink/pull/24878#discussion_r1626851630 ## flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java: ## @@ -210,11 +209,11 @@ public class CheckpointingOptions { * Local recover

Re: [PR] [FLINK-35522][runtime] Fix the issue that the source task may get stuck in speculative execution mode. [flink]

2024-06-04 Thread via GitHub
zhuzhurk commented on code in PR #24887: URL: https://github.com/apache/flink/pull/24887#discussion_r1626862364 ## flink-tests/src/test/java/org/apache/flink/test/scheduling/SpeculativeExecutionITCase.java: ## @@ -105,6 +109,8 @@ class SpeculativeExecutionITCase { private

Re: [PR] [FLINK-35504] Improve Elasticsearch 8 connector observability [flink-connector-elasticsearch]

2024-06-04 Thread via GitHub
reswqa commented on code in PR #106: URL: https://github.com/apache/flink-connector-elasticsearch/pull/106#discussion_r1626868230 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriter.java: ## @@ -102,13 +103,15

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-06-04 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2148784514 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [build] fix jackson conflicts among cdc connectors [flink-cdc]

2024-06-04 Thread via GitHub
leonardBang merged PR #2987: URL: https://github.com/apache/flink-cdc/pull/2987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-35423][table] ARRAY_EXCEPT should follow set semantics [flink]

2024-06-04 Thread via GitHub
xuyangzhong commented on code in PR #24828: URL: https://github.com/apache/flink/pull/24828#discussion_r1626871428 ## docs/data/sql_functions.yml: ## @@ -687,7 +687,7 @@ collection: description: Returns a map created from an arrays of keys and values. Note that the lengths

Re: [PR] [FLINK-32081][checkpoint] Compatibility between file-merging on and off across job runs [flink]

2024-06-04 Thread via GitHub
Zakelly commented on code in PR #24873: URL: https://github.com/apache/flink/pull/24873#discussion_r1626876357 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Softwa

[PR] [FLINK-35201][table] Support the execution of drop materialized table in full refresh mode [flink]

2024-06-04 Thread via GitHub
hackergin opened a new pull request, #24888: URL: https://github.com/apache/flink/pull/24888 ## What is the purpose of the change *Support the execution of drop materialized table in full refresh mode* ## Brief change log * Support the execution of drop materialized t

[jira] [Updated] (FLINK-35201) Support the execution of drop materialized table in full refresh mode

2024-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35201: --- Labels: pull-request-available (was: ) > Support the execution of drop materialized table i

Re: [PR] [FLINK-35415][base] Fix compatibility with Flink 1.19 [flink-cdc]

2024-06-04 Thread via GitHub
leonardBang commented on code in PR #3348: URL: https://github.com/apache/flink-cdc/pull/3348#discussion_r1626875255 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java: ## @@ -152,4 +152,37 @@ private String generateSinkNam

Re: [PR] [FLINK-35201][table] Support the execution of drop materialized table in full refresh mode [flink]

2024-06-04 Thread via GitHub
flinkbot commented on PR #24888: URL: https://github.com/apache/flink/pull/24888#issuecomment-2148801220 ## CI report: * f0ab631e7d9fea91593ec7550454fb926b265a60 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-26050] Manually compact small SST files [flink]

2024-06-04 Thread via GitHub
Myasuka commented on PR #24880: URL: https://github.com/apache/flink/pull/24880#issuecomment-2148803082 @rkhachatryan since the manual compaction would introduce extra CPU & IO, and it would impact the block-cache with the change of level structure. I think we could also add a doc to tell u

[jira] [Commented] (FLINK-35485) JobMaster failed with "the job xx has not been finished"

2024-06-04 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852267#comment-17852267 ] Xingcan Cui commented on FLINK-35485: - Hi [~mapohl], unfortunately, I failed to fetc

[PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-04 Thread via GitHub
LadyForest opened a new pull request, #24889: URL: https://github.com/apache/flink/pull/24889 ## What is the purpose of the change This pull request implements [FLIP-457](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=307136992&src=jira). ## Brief change log

Re: [PR] [FLINK-35504] Improve Elasticsearch 8 connector observability [flink-connector-elasticsearch]

2024-06-04 Thread via GitHub
liuml07 commented on code in PR #106: URL: https://github.com/apache/flink-connector-elasticsearch/pull/106#discussion_r1626901218 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriter.java: ## @@ -102,13 +103,15

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-04 Thread via GitHub
flinkbot commented on PR #24889: URL: https://github.com/apache/flink/pull/24889#issuecomment-2148823508 ## CI report: * dbc98f28e5eaa59a323807132c17d909fcc6133a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35504] Improve Elasticsearch 8 connector observability [flink-connector-elasticsearch]

2024-06-04 Thread via GitHub
liuml07 commented on code in PR #106: URL: https://github.com/apache/flink-connector-elasticsearch/pull/106#discussion_r1626913771 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriter.java: ## @@ -102,13 +103,15

Re: [PR] [FLINK-35415][base] Fix compatibility with Flink 1.19 [flink-cdc]

2024-06-04 Thread via GitHub
yuxiqian commented on PR #3348: URL: https://github.com/apache/flink-cdc/pull/3348#issuecomment-2148866328 Done, seems I messed up the commit history during last rebase... Fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-04 Thread via GitHub
elon-X commented on PR #24757: URL: https://github.com/apache/flink/pull/24757#issuecomment-2148906495 @1996fanrui I've made some changes based on your suggestions. Please review the changes when you have a chance and let me know if there are any further improvements needed. Thanks! -- T

[jira] [Commented] (FLINK-9043) Introduce a friendly way to resume the job from externalized checkpoints automatically

2024-06-04 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852289#comment-17852289 ] Yun Tang commented on FLINK-9043: - [~mszacillo] After six years of launching this discuss

[jira] [Created] (FLINK-35523) When using the Hive connector to read a Hive table in Parquet format, a null pointer exception is thrown.

2024-06-04 Thread Jichao Wang (Jira)
Jichao Wang created FLINK-35523: --- Summary: When using the Hive connector to read a Hive table in Parquet format, a null pointer exception is thrown. Key: FLINK-35523 URL: https://issues.apache.org/jira/browse/FLINK-

Re: [PR] [FLINK-35423][table] ARRAY_EXCEPT should follow set semantics [flink]

2024-06-04 Thread via GitHub
snuyanzin commented on code in PR #24828: URL: https://github.com/apache/flink/pull/24828#discussion_r1627027077 ## docs/data/sql_functions.yml: ## @@ -687,7 +687,7 @@ collection: description: Returns a map created from an arrays of keys and values. Note that the lengths o

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-04 Thread via GitHub
1996fanrui commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1626888044 ## flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/WatermarkAlignmentITCase.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-04 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1627068765 ## flink-connector-aws/flink-connector-sqs/src/main/java/org.apache.flink.connector.sqs/sink/SqsSinkElementConverter.java: ## @@ -0,0 +1,105 @@ +/* +

[jira] [Commented] (FLINK-35291) Improve the ROW data deserialization performance of DebeziumEventDeserializationScheme

2024-06-04 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852300#comment-17852300 ] Yun Tang commented on FLINK-35291: -- I think this is a useful observation. Since {{Strin

Re: [PR] [FLINK-35291] Improve the ROW data deserialization performance of DebeziumEventDeserializationScheme [flink-cdc]

2024-06-04 Thread via GitHub
Myasuka commented on PR #3289: URL: https://github.com/apache/flink-cdc/pull/3289#issuecomment-2149001433 @lzshlzsh What's the performance gain (or throughput improve) with this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-35138) Release flink-connector-kafka v3.2.0 for Flink 1.19

2024-06-04 Thread yazgoo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852301#comment-17852301 ] yazgoo commented on FLINK-35138: Hi, Looks like there are still 2 binding votes missing

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-04 Thread via GitHub
19priyadhingra commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2149019054 > We seem to be having quite a few `.` in the class folders. Can we change them to `/` instead? e.g. `[flink-connector-aws](https://issues.apache.org/jira/browse/FLINK-c

<    1   2