reswqa commented on code in PR #106:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/106#discussion_r1626868230
##########
flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncWriter.java:
##########
@@ -102,13 +103,15 @@ public Elasticsearch8AsyncWriter(
final SinkWriterMetricGroup metricGroup = context.metricGroup();
checkNotNull(metricGroup);
+ this.numRecordsSendCounter = metricGroup.getNumRecordsSendCounter();
this.numRecordsOutErrorsCounter =
metricGroup.getNumRecordsOutErrorsCounter();
}
@Override
protected void submitRequestEntries(
List<Operation> requestEntries, Consumer<List<Operation>>
requestResult) {
- LOG.debug("submitRequestEntries with {} items", requestEntries.size());
+ LOG.info("submitRequestEntries with {} items", requestEntries.size());
Review Comment:
I'm in favor of boosting log level when an exception occurs, but I don't
really want to print things like submitRequest and successful requests. I'm
afraid they fill up the entire log file and don't make much sense. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
