Re: [PR] [FLINK-34956][doc] Fix the config type wrong of Duration [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24583: URL: https://github.com/apache/flink/pull/24583#issuecomment-2024535345 ## CI report: * 7c766a4396a249885229b4c5924d1b9e043a54bf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34548][API] Introduce DataStream, Partitioning and ProcessFunction [flink]

2024-03-28 Thread via GitHub
Sxnan commented on code in PR #24422: URL: https://github.com/apache/flink/pull/24422#discussion_r1540748320 ## flink-datastream-api/src/main/java/org/apache/flink/datastream/api/ExecutionEnvironment.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (FLINK-34551) Align retry mechanisms of FutureUtils

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831657#comment-17831657 ] Matthias Pohl commented on FLINK-34551: --- The intention of this ticket came from FL

[jira] [Assigned] (FLINK-34551) Align retry mechanisms of FutureUtils

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34551: - Assignee: Matthias Pohl (was: Kumar Mallikarjuna) > Align retry mechanisms of FutureUt

Re: [PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
zentol commented on code in PR #24562: URL: https://github.com/apache/flink/pull/24562#discussion_r1542463838 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -499,11 +499,33 @@ void testResultFutureCompletionOfO

[jira] [Commented] (FLINK-34937) Apache Infra GHA policy update

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831659#comment-17831659 ] Matthias Pohl commented on FLINK-34937: --- let's check https://github.com/assignUser

Re: [PR] [FLINK-34548][API] Introduce DataStream, Partitioning and ProcessFunction [flink]

2024-03-28 Thread via GitHub
reswqa commented on code in PR #24422: URL: https://github.com/apache/flink/pull/24422#discussion_r1542471491 ## flink-datastream-api/src/main/java/org/apache/flink/datastream/api/ExecutionEnvironment.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [FLINK-34548][API] Introduce DataStream, Partitioning and ProcessFunction [flink]

2024-03-28 Thread via GitHub
reswqa commented on code in PR #24422: URL: https://github.com/apache/flink/pull/24422#discussion_r1542471491 ## flink-datastream-api/src/main/java/org/apache/flink/datastream/api/ExecutionEnvironment.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [FLINK-34548][API] Introduce DataStream, Partitioning and ProcessFunction [flink]

2024-03-28 Thread via GitHub
reswqa commented on code in PR #24422: URL: https://github.com/apache/flink/pull/24422#discussion_r1542480801 ## flink-core/src/main/java/org/apache/flink/api/connector/dsv2/DataStreamV2SourceUtils.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
XComp opened a new pull request, #24584: URL: https://github.com/apache/flink/pull/24584 1.19 backport PR for parent PR #24562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
XComp opened a new pull request, #24585: URL: https://github.com/apache/flink/pull/24585 1.18 backport PR for parent PR #24562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [BP-1.19][FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24584: URL: https://github.com/apache/flink/pull/24584#issuecomment-2024638695 ## CI report: * 7d9a3a31f248613df9145dbf735dce2bddc55294 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24585: URL: https://github.com/apache/flink/pull/24585#issuecomment-2024638900 ## CI report: * 04d4618a9eb38470e4edf69a0054e13e83aab700 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831665#comment-17831665 ] Matthias Pohl commented on FLINK-34953: --- I guess we could do it. The [GitHub Actio

Re: [PR] [FLINK-34957][autoscaler] Event handler records the exception stack trace when exception message is null [flink-kubernetes-operator]

2024-03-28 Thread via GitHub
gyfora commented on code in PR #808: URL: https://github.com/apache/flink-kubernetes-operator/pull/808#discussion_r1542518890 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -63,6 +65,19 @@ void handleEvent( @N

Re: [PR] [FLINK-34957][autoscaler] Event handler records the exception stack trace when exception message is null [flink-kubernetes-operator]

2024-03-28 Thread via GitHub
gyfora commented on code in PR #808: URL: https://github.com/apache/flink-kubernetes-operator/pull/808#discussion_r1542520539 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -63,6 +65,19 @@ void handleEvent( @N

Re: [PR] [hotfix] Change old com.ververica dependency to flink [flink-cdc]

2024-03-28 Thread via GitHub
xleoken commented on PR #3110: URL: https://github.com/apache/flink-cdc/pull/3110#issuecomment-2024715251 Thanks @PatrickRen. > Could you open another PR to backport the patch to release-3.0 branch? Thanks We can not chang the pom.xml files in release-3.0 branch directly.

Re: [PR] [FLINK-34957][autoscaler] Event handler records the exception stack trace when exception message is null [flink-kubernetes-operator]

2024-03-28 Thread via GitHub
1996fanrui commented on code in PR #808: URL: https://github.com/apache/flink-kubernetes-operator/pull/808#discussion_r1542554907 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -63,6 +65,19 @@ void handleEvent(

[jira] [Created] (FLINK-34959) Update old flink-cdc-connectors artifactId

2024-03-28 Thread xleoken (Jira)
xleoken created FLINK-34959: --- Summary: Update old flink-cdc-connectors artifactId Key: FLINK-34959 URL: https://issues.apache.org/jira/browse/FLINK-34959 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-03-28 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831682#comment-17831682 ] Zhongqiang Gong commented on FLINK-34953: - I have a stupid question:Can we use R

[jira] [Updated] (FLINK-34959) Update old flink-cdc-connectors artifactId

2024-03-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34959: --- Labels: pull-request-available (was: ) > Update old flink-cdc-connectors artifactId > -

Re: [PR] Document address update [flink-cdc]

2024-03-28 Thread via GitHub
bright-zy closed pull request #3154: Document address update URL: https://github.com/apache/flink-cdc/pull/3154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Comment Edited] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-03-28 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831682#comment-17831682 ] Zhongqiang Gong edited comment on FLINK-34953 at 3/28/24 9:30 AM:

Re: [PR] [hotfix] Change old com.ververica dependency to flink [flink-cdc]

2024-03-28 Thread via GitHub
PatrickRen commented on PR #3110: URL: https://github.com/apache/flink-cdc/pull/3110#issuecomment-2024766688 @xleoken Ah my mistake. We don't need to backport this one to release-3.0 as 3.1 will be the first version after the donation. Thanks anyway! -- This is an automated message from t

[jira] [Commented] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-03-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831693#comment-17831693 ] Martijn Visser commented on FLINK-34953: [~mapohl] I guess our project-website i

[PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-03-28 Thread via GitHub
qinghui-xu opened a new pull request, #24586: URL: https://github.com/apache/flink/pull/24586 Handle edge case of zero length serialized bytes correctly. ## What is the purpose of the change Bug fix in kryo (NoFetching)Input implementation to handle properly zero length

[jira] [Updated] (FLINK-34954) Kryo input implementation NoFetchingInput fails to handle zero length bytes

2024-03-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34954: --- Labels: pull-request-available (was: ) > Kryo input implementation NoFetchingInput fails to

Re: [PR] [build] fix inconsistent Kafka shading among cdc connectors [flink-cdc]

2024-03-28 Thread via GitHub
PatrickRen merged PR #2988: URL: https://github.com/apache/flink-cdc/pull/2988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-34954][core] Kryo Input bug fix [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24586: URL: https://github.com/apache/flink/pull/24586#issuecomment-2024784567 ## CI report: * a37e562b54ed9ad4b9290f2f999542ea9104c65f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [cdc-cli]Add support for both new and old Flink config files in Flink… [flink-cdc]

2024-03-28 Thread via GitHub
PatrickRen commented on PR #3194: URL: https://github.com/apache/flink-cdc/pull/3194#issuecomment-2024785477 @skymilong Welcome to the community! Feel free to ask any questions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [pipeline-connector][paimon] add paimon pipeline data sink connector. [flink-cdc]

2024-03-28 Thread via GitHub
PatrickRen commented on PR #2916: URL: https://github.com/apache/flink-cdc/pull/2916#issuecomment-2024788681 > paimon latest version is 0.7,we should update paimon version from 0.6 to 0.7 @lvyanquan Could you take a look at this one? I prefer to catch up with the latest version as we

[jira] [Comment Edited] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831665#comment-17831665 ] Matthias Pohl edited comment on FLINK-34953 at 3/28/24 9:52 AM: --

[jira] [Reopened] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-34953: --- > Add github ci for flink-web to auto commit build files > -

Re: [PR] [FLINK-33376][coordination] Extend ZooKeeper Curator configurations [flink]

2024-03-28 Thread via GitHub
XComp merged PR #24563: URL: https://github.com/apache/flink/pull/24563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Updated] (FLINK-33376) Extend Curator config option for Zookeeper configuration

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33376: -- Release Note: Adds support for the following curator parameters: high-availability.zookeeper.c

[jira] [Resolved] (FLINK-33376) Extend Curator config option for Zookeeper configuration

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33376. --- Fix Version/s: 1.20.0 Release Note: Adds support for the following curator parameters:

Re: [PR] [FLINK-34957][autoscaler] Event handler records the exception stack trace when exception message is null [flink-kubernetes-operator]

2024-03-28 Thread via GitHub
1996fanrui merged PR #808: URL: https://github.com/apache/flink-kubernetes-operator/pull/808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Resolved] (FLINK-34957) JDBC Autoscaler event handler throws Column 'message' cannot be null

2024-03-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34957. - Resolution: Fixed > JDBC Autoscaler event handler throws Column 'message' cannot be null >

[jira] [Commented] (FLINK-34957) JDBC Autoscaler event handler throws Column 'message' cannot be null

2024-03-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831712#comment-17831712 ] Rui Fan commented on FLINK-34957: - Merged master(1.9.0) via: 9119d73a904bc5a5eb675c2edff

[jira] [Commented] (FLINK-34551) Align retry mechanisms of FutureUtils

2024-03-28 Thread Kumar Mallikarjuna (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831728#comment-17831728 ] Kumar Mallikarjuna commented on FLINK-34551: I see, makes sense. Thank you.

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-03-28 Thread via GitHub
X-czh commented on code in PR #24544: URL: https://github.com/apache/flink/pull/24544#discussion_r1542824003 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DataTypeFactoryImpl.java: ## @@ -132,49 +131,12 @@ public LogicalType createLogicalType(U

[jira] [Created] (FLINK-34960) NullPointerException while applying parallelism overrides for session jobs

2024-03-28 Thread Kunal Rohitas (Jira)
Kunal Rohitas created FLINK-34960: - Summary: NullPointerException while applying parallelism overrides for session jobs Key: FLINK-34960 URL: https://issues.apache.org/jira/browse/FLINK-34960 Project:

Re: [PR] [FLINK-32711][planner] Fix the type mismatch when proctime() used as … [flink]

2024-03-28 Thread via GitHub
vahmed-hamdy commented on PR #23107: URL: https://github.com/apache/flink/pull/23107#issuecomment-2025033887 Thanks for the contribution! I have tested it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-34922][rest] Support concurrent global failure [flink]

2024-03-28 Thread via GitHub
zentol merged PR #24573: URL: https://github.com/apache/flink/pull/24573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831767#comment-17831767 ] Chesnay Schepler commented on FLINK-34922: -- master: dc957bfdc3aa6a8e3bce603cfc6

[jira] [Updated] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-34922: - Fix Version/s: 1.18.2 1.20.0 1.19.1 > Exception Hi

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-03-28 Thread via GitHub
X-czh commented on code in PR #24544: URL: https://github.com/apache/flink/pull/24544#discussion_r1542914373 ## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java: ## @@ -574,4 +575,31 @@ private void registerTypeWithTypeInfoFactory(

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-03-28 Thread via GitHub
X-czh commented on PR #24544: URL: https://github.com/apache/flink/pull/24544#issuecomment-2025118034 @kumar-mallikarjuna Thanks for the contribution. LGTM except for two minor comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [BP-1.18][FLINK-34922][rest] Support concurrent global failure [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24587: URL: https://github.com/apache/flink/pull/24587#issuecomment-2025120982 ## CI report: * 98fb74b2d101b6ea373b139edc26893be14f2c39 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.19][FLINK-34922][rest] Support concurrent global failure [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24588: URL: https://github.com/apache/flink/pull/24588#issuecomment-2025121174 ## CI report: * 2736d3c01669ba65150b82a7d758b5e50c8f3cc4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
XComp merged PR #24562: URL: https://github.com/apache/flink/pull/24562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [BP-1.19][FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
XComp merged PR #24584: URL: https://github.com/apache/flink/pull/24584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [BP-1.18][FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]

2024-03-28 Thread via GitHub
XComp merged PR #24585: URL: https://github.com/apache/flink/pull/24585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Resolved] (FLINK-34933) JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored isn't implemented properly

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34933. --- Fix Version/s: 1.18.2 1.20.0 1.19.1 Resolution:

Re: [PR] [FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-03-28 Thread via GitHub
XComp commented on code in PR #24465: URL: https://github.com/apache/flink/pull/24465#discussion_r1542963271 ## flink-end-to-end-tests/test-scripts/test_file_sink.sh: ## @@ -79,30 +42,69 @@ TEST_PROGRAM_JAR="${END_TO_END_DIR}/flink-file-sink-test/target/FileSinkProgram. # so

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-03-28 Thread via GitHub
MartijnVisser commented on PR #24526: URL: https://github.com/apache/flink/pull/24526#issuecomment-2025213724 @liuyongvs I disagree: I think that we're looking at what the definition of INTERSECT in general is, not from a functional or implementation perspective, but more if there's a defin

[jira] [Commented] (FLINK-34911) ChangelogRecoveryRescaleITCase failed fatally with 127 exit code

2024-03-28 Thread Rui Xia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831795#comment-17831795 ] Rui Xia commented on FLINK-34911: - Hello Skraba I see the system error in the log file:

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2024-03-28 Thread via GitHub
dawidwys commented on code in PR #23886: URL: https://github.com/apache/flink/pull/23886#discussion_r1543024707 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/WindowAggregateTestPrograms.java: ## @@ -0,0 +1,528 @@ +/* + * L

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2024-03-28 Thread via GitHub
dawidwys commented on code in PR #23886: URL: https://github.com/apache/flink/pull/23886#discussion_r1543024707 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/WindowAggregateTestPrograms.java: ## @@ -0,0 +1,528 @@ +/* + * L

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2024-03-28 Thread via GitHub
dawidwys commented on code in PR #23886: URL: https://github.com/apache/flink/pull/23886#discussion_r1543023465 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/WindowAggregateJsonPlanTest.java: ## @@ -1,528 +0,0 @@ -/* - * L

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2024-03-28 Thread via GitHub
dawidwys commented on code in PR #23886: URL: https://github.com/apache/flink/pull/23886#discussion_r1543029050 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/WindowAggregateTestPrograms.java: ## @@ -0,0 +1,528 @@ +/* + * L

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2024-03-28 Thread via GitHub
dawidwys commented on code in PR #23886: URL: https://github.com/apache/flink/pull/23886#discussion_r1543024707 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/WindowAggregateTestPrograms.java: ## @@ -0,0 +1,528 @@ +/* + * L

Re: [PR] [FLINK-34517][table]fix environment configs ignored when calling procedure operation [flink]

2024-03-28 Thread via GitHub
JustinLeesin commented on PR #24397: URL: https://github.com/apache/flink/pull/24397#issuecomment-2025255577 > @JustinLeesin Could you please cherry pick it to release-1.19 branch? And if ci passed, please let me know Sorry to reply so late, I will work on it recently. -- This is

[jira] [Resolved] (FLINK-34950) Disable spotless on Java 21 for connector-shared-utils

2024-03-28 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-34950. - Fix Version/s: connector-parent-1.2.0 Resolution: Fixed > Disable spotless on Jav

[jira] [Closed] (FLINK-34950) Disable spotless on Java 21 for connector-shared-utils

2024-03-28 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-34950. --- > Disable spotless on Java 21 for connector-shared-utils > -

Re: [PR] [FLINK-33805] Implement restore tests for OverAggregate node [flink]

2024-03-28 Thread via GitHub
dawidwys closed pull request #24565: [FLINK-33805] Implement restore tests for OverAggregate node URL: https://github.com/apache/flink/pull/24565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Closed] (FLINK-33805) Implement restore tests for OverAggregate node

2024-03-28 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33805. Fix Version/s: 1.20.0 Resolution: Fixed Implemented in b3334d1527aab6c196752b63c31

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

2024-03-28 Thread via GitHub
snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543058071 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDown.java: ## @@ -0,0 +1,67 @@ +/* +

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

2024-03-28 Thread via GitHub
snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543059276 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDownFactory.java: ## @@ -0,0 +1,53 @@

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

2024-03-28 Thread via GitHub
snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543065577 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDown.java: ## @@ -0,0 +1,67 @@ +/* +

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

2024-03-28 Thread via GitHub
snuyanzin commented on code in PR #24280: URL: https://github.com/apache/flink/pull/24280#discussion_r1543058071 ## flink-end-to-end-tests/flink-sql-client-test/src/main/java/org/apache/flink/table/toolbox/TestScanTableSourceWithWatermarkPushDown.java: ## @@ -0,0 +1,67 @@ +/* +

Re: [PR] [FLINK-28693][table] Fix janino compile failed because the code generated refers the class in table-planner [flink]

2024-03-28 Thread via GitHub
snuyanzin commented on PR #24280: URL: https://github.com/apache/flink/pull/24280#issuecomment-2025314263 @xuyangzhong thanks for the update it looks good from my side I put a couple of minor comments Could you also please create backports for other branches? -- This is an aut

[jira] [Commented] (FLINK-34937) Apache Infra GHA policy update

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831844#comment-17831844 ] Matthias Pohl commented on FLINK-34937: --- Looks like Flink is on rank 19 in terms o

[jira] [Updated] (FLINK-34961) GitHub Actions runner statistcs can be monitored per workflow name

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34961: -- Summary: GitHub Actions runner statistcs can be monitored per workflow name (was: GitHub Acti

[jira] [Created] (FLINK-34961) GitHub Actions statistcs can be monitored per workflow name

2024-03-28 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34961: - Summary: GitHub Actions statistcs can be monitored per workflow name Key: FLINK-34961 URL: https://issues.apache.org/jira/browse/FLINK-34961 Project: Flink

[jira] [Updated] (FLINK-34961) GitHub Actions runner statistcs can be monitored per workflow name

2024-03-28 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34961: -- Labels: starter (was: ) > GitHub Actions runner statistcs can be monitored per workflow name

[PR] Bump express from 4.18.2 to 4.19.2 in /flink-runtime-web/web-dashboard [flink]

2024-03-28 Thread via GitHub
dependabot[bot] opened a new pull request, #24589: URL: https://github.com/apache/flink/pull/24589 Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. Release notes Sourced from https://github.com/expressjs/express/releases";>express's releases. 4.19

Re: [PR] Bump express from 4.18.2 to 4.19.2 in /flink-runtime-web/web-dashboard [flink]

2024-03-28 Thread via GitHub
flinkbot commented on PR #24589: URL: https://github.com/apache/flink/pull/24589#issuecomment-2025455793 ## CI report: * c914de50878ed91a0f9997d148509e1fda770e66 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis closed FLINK-34922. -- Fix Version/s: (was: 1.18.2) (was: 1.20.0)

[jira] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922 ] Panagiotis Garefalakis deleted comment on FLINK-34922: was (Author: pgaref): Closing in favor of https://issues.apache.org/jira/browse/FLINK-34922 > Exception History should supp

[jira] [Updated] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-34922: --- Fix Version/s: 1.20.0 > Exception History should support multiple Global fai

[jira] [Updated] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-34922: --- Fix Version/s: 1.19.1 > Exception History should support multiple Global fai

[jira] [Updated] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-34922: --- Fix Version/s: 1.18.2 > Exception History should support multiple Global fai

[jira] [Reopened] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis reopened FLINK-34922: > Exception History should support multiple Global failures >

[jira] [Closed] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis closed FLINK-34922. -- Resolution: Fixed > Exception History should support multiple Global failures

Re: [PR] [FLINK-33121] Failed precondition in JobExceptionsHandler due to concurrent global failures [flink]

2024-03-28 Thread via GitHub
pgaref closed pull request #23440: [FLINK-33121] Failed precondition in JobExceptionsHandler due to concurrent global failures URL: https://github.com/apache/flink/pull/23440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Closed] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis closed FLINK-33121. -- Release Note: Closing in favor of https://issues.apache.org/jira/browse/FLINK-

Re: [PR] [FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-03-28 Thread via GitHub
XComp commented on code in PR #24465: URL: https://github.com/apache/flink/pull/24465#discussion_r1543160518 ## flink-end-to-end-tests/test-scripts/test_file_sink.sh: ## @@ -79,30 +42,69 @@ TEST_PROGRAM_JAR="${END_TO_END_DIR}/flink-file-sink-test/target/FileSinkProgram. # so

[jira] [Updated] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-33121: --- Release Note: (was: Closing in favor of https://issues.apache.org/jira/bro

[jira] [Commented] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2024-03-28 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831863#comment-17831863 ] Panagiotis Garefalakis commented on FLINK-33121:  Closing in favor of ht

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-03-28 Thread via GitHub
affo commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1543172250 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/BatchSQLTest.java: ## @@ -34,66 +35,105 @@ import org.apache.flink.table.sinks.Csv

[PR] [FLINK-34930] Externalize existing code from bahir-flink [flink-connector-kudu]

2024-03-28 Thread via GitHub
ferenc-csaky opened a new pull request, #1: URL: https://github.com/apache/flink-connector-kudu/pull/1 TODO: Explicitly state in the repo that the code was forked from [bahir-flink](https://github.com/apache/bahir-flink). For this step, I tried to not introduce changes in the ported l

[jira] [Updated] (FLINK-34930) Move existing Kudu connector code from Bahir repo to dedicated repo

2024-03-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34930: --- Labels: pull-request-available (was: ) > Move existing Kudu connector code from Bahir repo

Re: [PR] [FLINK-34161][table] Migration of RewriteMinusAllRule to java [flink]

2024-03-28 Thread via GitHub
RyanSkraba commented on code in PR #24143: URL: https://github.com/apache/flink/pull/24143#discussion_r1543209301 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/RewriteMinusAllRule.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-32673) Migrage Google PubSub connector to V2

2024-03-28 Thread Claire McCarthy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831873#comment-17831873 ] Claire McCarthy commented on FLINK-32673: - Hey all! What's the status on this [

Re: [PR] [BP-1.19][FLINK-34922][rest] Support concurrent global failure [flink]

2024-03-28 Thread via GitHub
zentol merged PR #24588: URL: https://github.com/apache/flink/pull/24588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Comment Edited] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831767#comment-17831767 ] Chesnay Schepler edited comment on FLINK-34922 at 3/28/24 4:01 PM: ---

[jira] [Reopened] (FLINK-34922) Exception History should support multiple Global failures

2024-03-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-34922: -- > Exception History should support multiple Global failures >

Re: [PR] [FLINK-34161][table] Migration of RewriteMinusAllRule to java [flink]

2024-03-28 Thread via GitHub
RyanSkraba commented on code in PR #24143: URL: https://github.com/apache/flink/pull/24143#discussion_r1543215856 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/RewriteMinusAllRule.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-20625) Refactor Google Cloud PubSub Source in accordance with FLIP-27

2024-03-28 Thread Claire McCarthy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831880#comment-17831880 ] Claire McCarthy commented on FLINK-20625: - I can contribute here. Just left a co

  1   2   >