X-czh commented on code in PR #24544:
URL: https://github.com/apache/flink/pull/24544#discussion_r1542914373
##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java:
##########
@@ -574,4 +575,31 @@ private void registerTypeWithTypeInfoFactory(
public ExecutionConfig getExecutionConfig() {
return executionConfig;
}
+
+ @Override
+ public SerializerConfigImpl copy() {
+ final SerializerConfigImpl newSerializerConfig = new
SerializerConfigImpl();
+ newSerializerConfig.configure(configuration,
this.getClass().getClassLoader());
+
+ getRegisteredTypesWithKryoSerializers()
+ .forEach(
+ (c, s) ->
+
newSerializerConfig.registerTypeWithKryoSerializer(
+ c, s.getSerializer()));
+ getRegisteredTypesWithKryoSerializerClasses()
+ .forEach(newSerializerConfig::registerTypeWithKryoSerializer);
+ getDefaultKryoSerializers()
+ .forEach(
+ (c, s) ->
+
newSerializerConfig.addDefaultKryoSerializer(c, s.getSerializer()));
+ Optional.ofNullable(isForceKryoAvroEnabled().getAsBoolean())
Review Comment:
If I understand it correctly, it is not needed as we've already configured
it in `newSerializerConfig#configure`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
