zhengzhili333 commented on PR #23866:
URL: https://github.com/apache/flink/pull/23866#issuecomment-1840210958
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Sucran commented on PR #23872:
URL: https://github.com/apache/flink/pull/23872#issuecomment-1840275371
> -1 from my side based on previous community discussion:
>
> Please see the discussion in
https://lists.apache.org/thread/6p5tk6obmk1qxf169so498z4vk8cg969 and the
ticket: https://i
[
https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793189#comment-17793189
]
Hangxiang Yu commented on FLINK-27681:
--
Sorry for the late reply.
{quote}However,
dawidwys merged PR #23811:
URL: https://github.com/apache/flink/pull/23811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
gyfora commented on PR #23872:
URL: https://github.com/apache/flink/pull/23872#issuecomment-1840282229
I understand that this may be confusing for you but unfortunately we cannot
merge this PR in this form. Let's work on the operator side to solve this
properly as seen in the linked lira
[
https://issues.apache.org/jira/browse/FLINK-33663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz closed FLINK-33663.
Resolution: Implemented
Implemented in bc6c2cec37c45f021ae22a2a7b5ab9537b8506cd
> Seriali
jeyhunkarimov commented on PR #23586:
URL: https://github.com/apache/flink/pull/23586#issuecomment-1840305544
Does it make any difference? yes and no IMHO.
Yes, because imagine `test1()` executes the statement
`createTemporarySystemFunction("add", new TestAddWithOpen)` (also
`createTemp
JingGe commented on PR #23859:
URL: https://github.com/apache/flink/pull/23859#issuecomment-1840309252
@PatrickRen Thanks for the review. I have address your suggestion and add
1.16.x column back. Would you please check it again?
--
This is an automated message from the Apache Git Service
masteryhx commented on code in PR #23253:
URL: https://github.com/apache/flink/pull/23253#discussion_r1415176143
##
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java:
##
@@ -157,6 +157,14 @@ public class CliFrontendParser {
[
https://issues.apache.org/jira/browse/FLINK-33730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Ge updated FLINK-33730:
Summary: Update the compatibility table to only include last three released
versions (was: Update the com
masteryhx commented on code in PR #23253:
URL: https://github.com/apache/flink/pull/23253#discussion_r1415217180
##
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java:
##
@@ -157,6 +157,14 @@ public class CliFrontendParser {
zentol merged PR #23558:
URL: https://github.com/apache/flink/pull/23558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
[
https://issues.apache.org/jira/browse/FLINK-28229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-28229.
Fix Version/s: 1.19.0
Resolution: Fixed
master:
e44efbff8070dca3489550fdeadc5e1ce31
Zakelly commented on code in PR #23253:
URL: https://github.com/apache/flink/pull/23253#discussion_r1415245692
##
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java:
##
@@ -157,6 +157,14 @@ public class CliFrontendParser {
[
https://issues.apache.org/jira/browse/FLINK-33603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33603:
---
Labels: pull-request-available (was: )
> Fix guava shading for GCS connector
>
Zakelly commented on PR #23253:
URL: https://github.com/apache/flink/pull/23253#issuecomment-1840388226
Hi @xiangforever2014 @masteryhx sorry for jumping in... And I'm wondering if
we could use the capital '-D' for short option? Or I suggest we do not leave
any short option for this, only u
singhravidutt commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1840388220
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
masteryhx commented on code in PR #23253:
URL: https://github.com/apache/flink/pull/23253#discussion_r1415222035
##
docs/content.zh/docs/deployment/cli.md:
##
@@ -125,6 +125,43 @@ Lastly, you can optionally provide what should be the
[binary format]({{< ref "d
The path to th
Zakelly commented on code in PR #23514:
URL: https://github.com/apache/flink/pull/23514#discussion_r1415294769
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileMergingCheckpointStateOutputStream.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apach
Zakelly commented on PR #23514:
URL: https://github.com/apache/flink/pull/23514#issuecomment-1840444858
> Thanks @fredia and @Zakelly for your comments. Sorry for the late reply. I
have addressed your comments. Would you please take another look?
Thanks for your effort. I have no comm
gaborgsomogyi commented on PR #23865:
URL: https://github.com/apache/flink/pull/23865#issuecomment-1840452321
Thanks for the explanation!
> In terms of the source / binary compatibility, the main reason we do not
provide binary compatibility in minor releases for any API stability lev
libenchao commented on PR #23779:
URL: https://github.com/apache/flink/pull/23779#issuecomment-1840508653
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/FLINK-33670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793232#comment-17793232
]
Jeyhun Karimov commented on FLINK-33670:
Hi [~zicat] I tried with Flink master b
shuaiqi.guo created FLINK-33751:
---
Summary: use modules correctly when deserializing json plan
Key: FLINK-33751
URL: https://issues.apache.org/jira/browse/FLINK-33751
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-33751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shuaiqi.guo updated FLINK-33751:
Attachment: FLINK-33751.patch
> use modules correctly when deserializing json plan
> -
Rui Fan created FLINK-33752:
---
Summary: When Duration is greater than or equal to 1 day, the
display unit is ms.
Key: FLINK-33752
URL: https://issues.apache.org/jira/browse/FLINK-33752
Project: Flink
Prabhu Joseph created FLINK-33753:
-
Summary: ContinuousFileReaderOperator consume records as mini batch
Key: FLINK-33753
URL: https://issues.apache.org/jira/browse/FLINK-33753
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan updated FLINK-33752:
Description:
When the default value of Duration is 24 hours or 1 day, the display unit is
ms. (8640 m
[
https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan updated FLINK-33752:
Attachment: image-2023-12-05-19-58-07-737.png
> When Duration is greater than or equal to 1 day, the displ
Dawid Wysakowicz created FLINK-33754:
Summary: Serialize QueryOperations into SQL
Key: FLINK-33754
URL: https://issues.apache.org/jira/browse/FLINK-33754
Project: Flink
Issue Type: Sub-ta
1996fanrui opened a new pull request, #23873:
URL: https://github.com/apache/flink/pull/23873
## What is the purpose of the change
When the default value of Duration is 24 hours or 1 day, the display unit is
ms. (8640 ms). For example, the [kubernetes operator
doc](https://nightl
[
https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33752:
---
Labels: pull-request-available (was: )
> When Duration is greater than or equal to 1 day, t
zoudan commented on code in PR #23849:
URL: https://github.com/apache/flink/pull/23849#discussion_r1415242114
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java:
##
@@ -59,4 +59,7 @@ public interface ResultProvider {
*
zoudan commented on code in PR #23849:
URL: https://github.com/apache/flink/pull/23849#discussion_r1415242114
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java:
##
@@ -59,4 +59,7 @@ public interface ResultProvider {
*
WencongLiu commented on code in PR #23863:
URL: https://github.com/apache/flink/pull/23863#discussion_r1415495161
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java:
##
@@ -223,9 +228,16 @@ private void
flinkbot commented on PR #23873:
URL: https://github.com/apache/flink/pull/23873#issuecomment-1840670193
## CI report:
* 3bbbddd74077c28f009567d49f99e6277223c03b UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793246#comment-17793246
]
Yanfei Lei commented on FLINK-8:
[~mayuehappy]/[~pnowojski] Some updates:
I fi
WencongLiu commented on code in PR #23863:
URL: https://github.com/apache/flink/pull/23863#discussion_r1415504026
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java:
##
@@ -223,9 +228,16 @@ private void
[
https://issues.apache.org/jira/browse/FLINK-33232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793249#comment-17793249
]
chaoran.su commented on FLINK-33232:
I think this can be done by change the jobSpec.
zhuzhurk closed pull request #23847: [FLINK-33669][doc] Update the
documentation for RestartStrategy, Checkpoint Storage, and State Backend.
URL: https://github.com/apache/flink/pull/23847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-33669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhu Zhu closed FLINK-33669.
---
Fix Version/s: 1.19.0
Resolution: Done
master:
e27f8a3a0783d551457a2f424b01267bd1c8c2c2
d9bcb3b40ed5c
WencongLiu commented on code in PR #23863:
URL: https://github.com/apache/flink/pull/23863#discussion_r1415504026
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java:
##
@@ -223,9 +228,16 @@ private void
shuaiqig opened a new pull request, #23874:
URL: https://github.com/apache/flink/pull/23874
## What is the purpose of the change
use modules correctly when deserializing json plan
## Brief change log
fix 2 bug in deserializing json plan:
1. if 2 Operators were foun
[
https://issues.apache.org/jira/browse/FLINK-33751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33751:
---
Labels: pull-request-available (was: )
> use modules correctly when deserializing json plan
flinkbot commented on PR #23874:
URL: https://github.com/apache/flink/pull/23874#issuecomment-1840731716
## CI report:
* 65142b1c17f91f24aeb126db32c89268a5d1b14a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
zhuzhurk commented on code in PR #23848:
URL: https://github.com/apache/flink/pull/23848#discussion_r1415539068
##
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java:
##
@@ -83,10 +86,27 @@ public AbstractRuntimeUDFContext(
}
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415600246
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet
pvary commented on PR #23865:
URL: https://github.com/apache/flink/pull/23865#issuecomment-1840787769
I would suggest to change the
[previous](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/upgrading/#api-compatibility-guarantees)
paragraph, like the following (remove the API
echauchot commented on PR #20:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1840799581
@snuyanzin as you already started, do you want to take this review ?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
mxm commented on PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#issuecomment-1840802299
PTAL @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
mxm commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415619399
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##
@@ -180,13 +
dawidwys commented on code in PR #23821:
URL: https://github.com/apache/flink/pull/23821#discussion_r1415623981
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MatchRecognizeTestPrograms.java:
##
@@ -0,0 +1,300 @@
+/*
+ * Li
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415628238
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,450 @@
+/*
+ * Licensed
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415631030
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet
Sergey Nuyanzin created FLINK-33755:
---
Summary: Cleanup usage of deprecated
StreamExecutionEnvironment#generateSequence
Key: FLINK-33755
URL: https://issues.apache.org/jira/browse/FLINK-33755
Project
snuyanzin opened a new pull request, #23875:
URL: https://github.com/apache/flink/pull/23875
## What is the purpose of the change
The PR to replace usages of `StreamExecutionEnvironment#generateSequence`
with `StreamExecutionEnvironment#fromSequence` as mentioned in javadoc
[
https://issues.apache.org/jira/browse/FLINK-33755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33755:
---
Labels: pull-request-available (was: )
> Cleanup usage of deprecated StreamExecutionEnviron
RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1415650282
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/FLINK-33755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated FLINK-33755:
Component/s: (was: Table SQL / Planner)
> Cleanup usage of deprecated StreamExecutionE
1996fanrui commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415657657
##
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##
@@ -30,12 +31,23 @
flinkbot commented on PR #23875:
URL: https://github.com/apache/flink/pull/23875#issuecomment-1840847783
## CI report:
* 4acb9f182b43cf89786baa73e7ee1407a12cf58c UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
1996fanrui commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415657657
##
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##
@@ -30,12 +31,23 @
RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1415663600
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apa
jnh5y commented on code in PR #23821:
URL: https://github.com/apache/flink/pull/23821#discussion_r1415662216
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MatchRecognizeTestPrograms.java:
##
@@ -0,0 +1,300 @@
+/*
+ * Licen
gyfora commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415668748
##
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##
@@ -30,12 +31,23 @@
p
RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1415668887
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apa
1996fanrui commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415657657
##
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##
@@ -30,12 +31,23 @
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415682052
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet sup
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415680690
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet sup
1996fanrui commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1415688264
##
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java:
##
@@ -30,12 +31,23 @
gyfora commented on code in PR #712:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1415689682
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##
@@ -1075,4 +1106,59 @@ protected v
jnh5y commented on PR #23821:
URL: https://github.com/apache/flink/pull/23821#issuecomment-1840893823
> LGTM % the ids issue, I'll merge the PR after #23869 which is necessary
for the cleanup.
FWIW, MR observes the changelog not final results. I *think* it should be
ok to merge befo
RocMarshal commented on PR #23635:
URL: https://github.com/apache/flink/pull/23635#issuecomment-1840891716
Thank you @1996fanrui @KarmaGYZ very much for the review
I have re evaluated the implementation location of the waiting mechanisms
based on @KarmaGYZ offline suggestions.
gaborgsomogyi commented on code in PR #712:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1415671557
##
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##
@@ -130,6 +141,10 @@ spec:
- name: flink-artifacts-volume
jnh5y commented on code in PR #23653:
URL: https://github.com/apache/flink/pull/23653#discussion_r1415705636
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -91,7 +91,8 @@ public EnumSet suppor
pvary opened a new pull request, #23876:
URL: https://github.com/apache/flink/pull/23876
## What is the purpose of the change
This is the a revisited non-breaking implementation of [FLIP-371: Provide
initialization context for Committer creation in
TwoPhaseCommittingSink](https://cwi
gaborgsomogyi commented on PR #712:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/712#issuecomment-1840907216
Sorry for the late response we've quite some tasks to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jnh5y commented on PR #23681:
URL: https://github.com/apache/flink/pull/23681#issuecomment-1840907198
The CI failure is from spotless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dawidwys commented on PR #23821:
URL: https://github.com/apache/flink/pull/23821#issuecomment-1840912550
> FWIW, MR observes the changelog not final results. I think it should be ok
to merge before or after the Join PR.
I don't think it makes a difference. Both access static variables
gyfora commented on PR #668:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/668#issuecomment-1840917676
Any update on this @sbrother ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
flinkbot commented on PR #23876:
URL: https://github.com/apache/flink/pull/23876#issuecomment-1840919846
## CI report:
* 99ec936966af527598ca49712c1263bc4aa03c15 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
snuyanzin commented on PR #20:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1840937326
yep sure
@PatrickRen would you mind to bump it to 3.5.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
pvary commented on code in PR #23865:
URL: https://github.com/apache/flink/pull/23865#discussion_r1415756044
##
docs/content/docs/ops/upgrading.md:
##
@@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will
continue to run in 1.
That same code would have
pvary commented on code in PR #23865:
URL: https://github.com/apache/flink/pull/23865#discussion_r1415756044
##
docs/content/docs/ops/upgrading.md:
##
@@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will
continue to run in 1.
That same code would have
tisonkun merged PR #61:
URL: https://github.com/apache/flink-connector-pulsar/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415790788
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -107,7 +107,7 @@ public class Jo
tagarr commented on code in PR #712:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1415815965
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##
@@ -195,8 +199,25 @@ public void s
tagarr commented on code in PR #712:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1415823972
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##
@@ -1075,4 +1106,59 @@ protected v
afedulov commented on PR #83:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1841113426
@schulzp thanks for the contribution. The approach looks solid. I believe
what is missing are some tests that check that the non-default inspector is
actually utilized
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415899730
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -107,7 +107,7 @@ public class JoinT
snuyanzin commented on PR #23875:
URL: https://github.com/apache/flink/pull/23875#issuecomment-1841156149
Thanks for taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
[
https://issues.apache.org/jira/browse/FLINK-33755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin closed FLINK-33755.
---
> Cleanup usage of deprecated StreamExecutionEnvironment#generateSequence
>
snuyanzin merged PR #23875:
URL: https://github.com/apache/flink/pull/23875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
[
https://issues.apache.org/jira/browse/FLINK-33755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin resolved FLINK-33755.
-
Resolution: Fixed
> Cleanup usage of deprecated StreamExecutionEnvironment#generateSeque
[
https://issues.apache.org/jira/browse/FLINK-33755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793352#comment-17793352
]
Sergey Nuyanzin commented on FLINK-33755:
-
Merged to master as
[e74592ca92f4eac
jeyhunkarimov opened a new pull request, #23877:
URL: https://github.com/apache/flink/pull/23877
## What is the purpose of the change
The purpose of this change is to make the constraint generation mechanism
the same in MergeTableLikeUtil and Schema
## Brief change log
[
https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33666:
---
Labels: pull-request-available (was: )
> MergeTableLikeUtil uses different constraint name
flinkbot commented on PR #23877:
URL: https://github.com/apache/flink/pull/23877#issuecomment-1841235550
## CI report:
* 0fc7e4da09365d5a524a68a715f8c7961d522aac UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
tagarr commented on PR #712:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/712#issuecomment-1841240447
So if you prefer not catching the exception I can just add some info in the
example readme about ensuring ssl location and password are consistent or you
may see exception
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1416020844
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,450 @@
+/*
+ * Licensed to
1 - 100 of 185 matches
Mail list logo
