[jira] [Commented] (FLINK-33323) HybridShuffleITCase fails with produced an uncaught exception in FatalExitExceptionHandler

2023-10-26 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779779#comment-17779779 ] Yuxin Tan commented on FLINK-33323: --- [~Wencong Liu] Could you please take a look at th

[jira] [Updated] (FLINK-33354) Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33354: Summary: Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects (was: Reus

[PR] [FLINK-33354][runtime] Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects [flink]

2023-10-26 Thread via GitHub
1996fanrui opened a new pull request, #23599: URL: https://github.com/apache/flink/pull/23599 ## What is the purpose of the change The background is similar to [FLINK-33315](https://issues.apache.org/jira/browse/FLINK-33315). A hive table with a lot of data, and the HiveSource#

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779793#comment-17779793 ] Martijn Visser commented on FLINK-33355: See https://stackoverflow.com/question

[jira] [Updated] (FLINK-33354) Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33354: --- Labels: pull-request-available (was: ) > Cache TaskInformation and JobInformation to avoid

[jira] [Created] (FLINK-33368) Support for SNI in the Flink Client

2023-10-26 Thread Mihai L Lalescu (Jira)
Mihai L Lalescu created FLINK-33368: --- Summary: Support for SNI in the Flink Client Key: FLINK-33368 URL: https://issues.apache.org/jira/browse/FLINK-33368 Project: Flink Issue Type: New Fea

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-10-26 Thread via GitHub
MartijnVisser commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1780621457 @ferenc-csaky can you also help with this one? I'll also ping you on some of the other HBase PRs 😅 -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [FLINK-33206] Verify the existence of hbase table before read/write [flink-connector-hbase]

2023-10-26 Thread via GitHub
MartijnVisser commented on PR #22: URL: https://github.com/apache/flink-connector-hbase/pull/22#issuecomment-1780622003 @ferenc-csaky can you also help with this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-33207] Return empty split when the hbase table is empty [flink-connector-hbase]

2023-10-26 Thread via GitHub
MartijnVisser commented on PR #23: URL: https://github.com/apache/flink-connector-hbase/pull/23#issuecomment-1780621767 @ferenc-csaky can you also help with this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [hotfix] Add support for Flink 1.18-SNAPSHOT to the CI/CD workflows [flink-connector-hbase]

2023-10-26 Thread via GitHub
MartijnVisser closed pull request #16: [hotfix] Add support for Flink 1.18-SNAPSHOT to the CI/CD workflows URL: https://github.com/apache/flink-connector-hbase/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-33354][runtime] Cache TaskInformation and JobInformation to avoid deserializing duplicate big objects [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23599: URL: https://github.com/apache/flink/pull/23599#issuecomment-1780625586 ## CI report: * 2cd1a297d97a52d9778a430d1f9d887aff9bab63 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33367) Invalid Check in DefaultFileFilter

2023-10-26 Thread Chirag Dewan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chirag Dewan updated FLINK-33367: - Description: There is a null check in DefaultFileFilter:   if (fileName == null || fileName.le

Re: [PR] [FLINK-25809][table-api-java] Add table test program infrastructure [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23584: URL: https://github.com/apache/flink/pull/23584#discussion_r1372787466 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Created] (FLINK-33369) Wordcount is failing on AZP with jdk17

2023-10-26 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33369: --- Summary: Wordcount is failing on AZP with jdk17 Key: FLINK-33369 URL: https://issues.apache.org/jira/browse/FLINK-33369 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-10-26 Thread via GitHub
Tan-JiaLiang commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1780656291 @MartijnVisser Thanks for all the reviewer request, @ferenc-csaky you can review when you are free, I'll always keep an eye on all my PRs until it finish, thank you master

[jira] [Updated] (FLINK-33369) Wordcount is failing on AZP with jdk17

2023-10-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33369: Affects Version/s: 1.19.0 1.18.1 > Wordcount is failing on AZP with

[jira] [Commented] (FLINK-33369) Wordcount is failing on AZP with jdk17

2023-10-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779797#comment-17779797 ] Sergey Nuyanzin commented on FLINK-33369: - 1.18 branch starts failing after this

[jira] [Comment Edited] (FLINK-33369) Wordcount is failing on AZP with jdk17

2023-10-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779797#comment-17779797 ] Sergey Nuyanzin edited comment on FLINK-33369 at 10/26/23 8:34 AM: ---

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-26 Thread zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779800#comment-17779800 ] zhang commented on FLINK-33355: --- [~martijnvisser]  I found that the {{.with()}} method is

Re: [PR] test [flink]

2023-10-26 Thread via GitHub
reswqa commented on PR #23598: URL: https://github.com/apache/flink/pull/23598#issuecomment-1780670713 🉑 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Created] (FLINK-33370) Simplify validateAndParseHostsString in Elasticsearch connecter's configuration

2023-10-26 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33370: - Summary: Simplify validateAndParseHostsString in Elasticsearch connecter's configuration Key: FLINK-33370 URL: https://issues.apache.org/jira/browse/FLINK-33370 Project: Fl

Re: [PR] [FLINK-33316][runtime] Avoid unnecessary heavy getStreamOperatorFactory [flink]

2023-10-26 Thread via GitHub
pnowojski commented on code in PR #23550: URL: https://github.com/apache/flink/pull/23550#discussion_r1372805309 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java: ## @@ -368,7 +373,8 @@ public void setStreamOperator(StreamOperator oper

Re: [PR] [FLINK-33316][runtime] Using SERIALIZED_UDF_CLASS instead of SERIALIZED_UDF_CLASS_NAME [flink]

2023-10-26 Thread via GitHub
pnowojski commented on PR #23597: URL: https://github.com/apache/flink/pull/23597#issuecomment-1780678346 Thanks for the update! Have you finally decided to go with the solution 3 instead of solution 1? -- This is an automated message from the Apache Git Service. To respond to the message

[PR] [FLINK-33370][connectors/elasticsearch] Simplify validateAndParseHostsString in Elasticsearch connector's configuration [flink-connector-elasticsearch]

2023-10-26 Thread via GitHub
TanYuxin-tyx opened a new pull request, #77: URL: https://github.com/apache/flink-connector-elasticsearch/pull/77 Currently, the validateAndParseHostsString method exists in each configuration file(repeated for 3 times), but the method logic is exactly the same. We can simplify it by introd

[jira] [Updated] (FLINK-33370) Simplify validateAndParseHostsString in Elasticsearch connecter's configuration

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33370: --- Labels: pull-request-available (was: ) > Simplify validateAndParseHostsString in Elasticsea

Re: [PR] [FLINK-32931][docker] Update Dockerfiles for 1.18.0 release [flink-docker]

2023-10-26 Thread via GitHub
JingGe merged PR #162: URL: https://github.com/apache/flink-docker/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-26 Thread via GitHub
xuyangzhong commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1780697786 Hi, @snuyanzin . Thanks for your review. The bug happens only when using the SQL API. The table API will not throw this exception actually. The quick explanation is: -

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-26 Thread via GitHub
xuyangzhong commented on code in PR #23519: URL: https://github.com/apache/flink/pull/23519#discussion_r1372829433 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java: ## @@ -66,12 +70,17 @@ * * * - * Once Flink applies s

Re: [PR] [FLINK-33316][runtime] Using SERIALIZED_UDF_CLASS instead of SERIALIZED_UDF_CLASS_NAME [flink]

2023-10-26 Thread via GitHub
1996fanrui commented on code in PR #23597: URL: https://github.com/apache/flink/pull/23597#discussion_r1372830355 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java: ## @@ -641,16 +641,26 @@ private Map createChainedSources( @N

Re: [PR] [FLINK-33316][runtime] Using SERIALIZED_UDF_CLASS instead of SERIALIZED_UDF_CLASS_NAME [flink]

2023-10-26 Thread via GitHub
1996fanrui commented on code in PR #23597: URL: https://github.com/apache/flink/pull/23597#discussion_r1372830355 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java: ## @@ -641,16 +641,26 @@ private Map createChainedSources( @N

[PR] Feature/expand sql cep [flink]

2023-10-26 Thread via GitHub
ValjeanShaw opened a new pull request, #23600: URL: https://github.com/apache/flink/pull/23600 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

Re: [PR] [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis [flink]

2023-10-26 Thread via GitHub
Jiabao-Sun commented on PR #23564: URL: https://github.com/apache/flink/pull/23564#issuecomment-1780717657 Hi @fsk119, could you help review it when you have time? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Feature/expand sql cep [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23600: URL: https://github.com/apache/flink/pull/23600#issuecomment-1780720090 ## CI report: * f31d155e29da9a84dad00a5340119f2060d79376 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-27432][runtime] Replace Time with Duration in TaskSlotTable [flink]

2023-10-26 Thread via GitHub
Jiabao-Sun commented on PR #23574: URL: https://github.com/apache/flink/pull/23574#issuecomment-1780722528 Hi @leonardBang, do you have time to help review it? Many thanks for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#issuecomment-1780765438 @snuyanzin can you please merge your PRs related to Java 17 compatibility into one? It's not good to have many small commits that are related to the same jira -- This i

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#issuecomment-1780766294 It would be great to have a single PR after which we have java 17 compatibility -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #693: URL: https://github.com/apache/flink-kubernetes-operator/pull/693#issuecomment-1780767534 Please add the contents of this PR to https://github.com/apache/flink-kubernetes-operator/pull/691 to avoid fragmentation -- This is an automated message from the Apach

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on PR #693: URL: https://github.com/apache/flink-kubernetes-operator/pull/693#issuecomment-1780770605 @gyfora this is not related to jdk17 this is a separate issue which i just noticed while comiling locally -- This is an automated message from the Apache Git Servi

Re: [PR] [FLINK-33033][olap][haservice] Add haservice micro benchmark for olap [flink-benchmarks]

2023-10-26 Thread via GitHub
KarmaGYZ commented on code in PR #78: URL: https://github.com/apache/flink-benchmarks/pull/78#discussion_r1372887014 ## src/main/java/org/apache/flink/olap/benchmark/HighAvailabilityServiceBenchmark.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [FLINK-33033][olap][haservice] Add haservice micro benchmark for olap [flink-benchmarks]

2023-10-26 Thread via GitHub
KarmaGYZ commented on code in PR #78: URL: https://github.com/apache/flink-benchmarks/pull/78#discussion_r1372887688 ## src/main/java/org/apache/flink/olap/benchmark/HighAvailabilityServiceBenchmark.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #693: URL: https://github.com/apache/flink-kubernetes-operator/pull/693#issuecomment-1780785201 ok, I am just not a big fan of these tiny PRs/commits. It could have been simply part of the other PR as you noticed and fixed it while you worked on it. -- This is an a

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #693: URL: https://github.com/apache/flink-kubernetes-operator/pull/693#issuecomment-1780786070 Opening one-liner PRs puts a strain on CI and also takes up everyone's time. Simply not worth it. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on PR #693: URL: https://github.com/apache/flink-kubernetes-operator/pull/693#issuecomment-1780790227 ok, i see, i will put them together -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1372917043 ## flink-autoscaler/pom.xml: ## @@ -31,6 +31,13 @@ under the License. Flink Autoscaler jar + + --add-opens=java.base/java.lan

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on PR #693: URL: https://github.com/apache/flink-kubernetes-operator/pull/693#issuecomment-1780812543 closing since now it is a part of https://github.com/apache/flink-kubernetes-operator/pull/691 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-31859] Update CycloneDX to 2.7.9 [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin closed pull request #693: [FLINK-31859] Update CycloneDX to 2.7.9 URL: https://github.com/apache/flink-kubernetes-operator/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] test [flink]

2023-10-26 Thread via GitHub
JunRuiLee commented on PR #23598: URL: https://github.com/apache/flink/pull/23598#issuecomment-1780844780 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33350] Update website for release 1.18.0 [flink-web]

2023-10-26 Thread via GitHub
JingGe merged PR #691: URL: https://github.com/apache/flink-web/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-33368) Support for SNI in the Flink Client

2023-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33368: --- Fix Version/s: (was: 1.16.3) > Support for SNI in the Flink Client > ---

[jira] [Updated] (FLINK-28520) RestClient doesn't use SNI TLS extension

2023-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28520: --- Issue Type: Improvement (was: Bug) > RestClient doesn't use SNI TLS extension > ---

[jira] [Commented] (FLINK-33368) Support for SNI in the Flink Client

2023-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779834#comment-17779834 ] Martijn Visser commented on FLINK-33368: [~mihai.l.lalescu] Is this a duplicate

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-10-26 Thread via GitHub
dannycranmer commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1372938391 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java: ## @@ -1

[jira] [Updated] (FLINK-33341) Use available local keyed state for rescaling

2023-10-26 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-33341: --- Summary: Use available local keyed state for rescaling (was: Use available local state for

[jira] [Created] (FLINK-33371) Make TestValues sinks return results as Rows

2023-10-26 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33371: Summary: Make TestValues sinks return results as Rows Key: FLINK-33371 URL: https://issues.apache.org/jira/browse/FLINK-33371 Project: Flink Issue Ty

[PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys opened a new pull request, #23601: URL: https://github.com/apache/flink/pull/23601 ## What is the purpose of the change If we want to use the predicates from https://github.com/apache/flink/pull/23584 in restore tests we need to make testing sinks return Rows instead of Stri

[jira] [Updated] (FLINK-33371) Make TestValues sinks return results as Rows

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33371: --- Labels: pull-request-available (was: ) > Make TestValues sinks return results as Rows > ---

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module [flink]

2023-10-26 Thread via GitHub
Jiabao-Sun commented on PR #23572: URL: https://github.com/apache/flink/pull/23572#issuecomment-1780891431 @1996fanrui, please help review it when you have time. Many thanks for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23601: URL: https://github.com/apache/flink/pull/23601#issuecomment-1780891737 ## CI report: * f553f6e0756c1d1251e368c75216b809f8b00c10 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32806]EmbeddedJobResultStore set ttly for non dirty job [flink]

2023-10-26 Thread via GitHub
Samrat002 commented on PR #23531: URL: https://github.com/apache/flink/pull/23531#issuecomment-1780893257 @XComp please review whenever time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module [flink]

2023-10-26 Thread via GitHub
1996fanrui merged PR #23572: URL: https://github.com/apache/flink/pull/23572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779841#comment-17779841 ] Rui Fan commented on FLINK-32850: - Merged via: 0ccd95ef48bcd7246f8c88c9aa7b69ffa268c865

[jira] [Comment Edited] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779841#comment-17779841 ] Rui Fan edited comment on FLINK-32850 at 10/26/23 11:05 AM:

Re: [PR] [FLINK-33089] Drop support for Flink 1.13 and 1.14 and clean up related codepaths [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #692: URL: https://github.com/apache/flink-kubernetes-operator/pull/692#issuecomment-1780902179 I will wait until the 1.18.0 release is finalised for Flink before merging as I also included the respective updates from snapshot to 1.18 images for CI -- This is an au

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-10-26 Thread via GitHub
iemre commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1372984660 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ExceptionConfig.java: ## @@ -0,0 +1,17 @@ +pa

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#issuecomment-1780905589 @gyfora i added here #693 please have a look once you have time -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-33360] HybridSourceSplitEnumerator clear finishedReaders when … [flink]

2023-10-26 Thread via GitHub
fengjiajie commented on code in PR #23593: URL: https://github.com/apache/flink/pull/23593#discussion_r1372988296 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java: ## @@ -252,6 +252,41 @@ pu

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1372996355 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1372989815 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract sta

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1372999282 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1373005879 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373006392 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract st

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-26 Thread via GitHub
JingGe commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1373016512 ## docs/content/docs/connectors/table/formats/avro.md: ## @@ -80,6 +80,14 @@ Format Options String Specify what format to use, here should be 'avro'.

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373020057 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract sta

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373031168 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract st

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373034259 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract st

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373034259 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract st

Re: [PR] [FLINK-33304] Introduce mutationBuffer to resolve the mutation write conflicts problem [flink-connector-hbase]

2023-10-26 Thread via GitHub
ferenc-csaky commented on PR #30: URL: https://github.com/apache/flink-connector-hbase/pull/30#issuecomment-1780977002 @Tan-JiaLiang that's even better 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-29549) Add Aws Glue Catalog support in Flink

2023-10-26 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779870#comment-17779870 ] Samrat Deb commented on FLINK-29549: please help reviewing the PR [https://github.c

Re: [PR] [FLINK-33164] Support write option sink.ignore-null-value [flink-connector-hbase]

2023-10-26 Thread via GitHub
ferenc-csaky commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781023023 > @ferenc-csaky I rebase the main branch and squash all my changes. > > And one more question master. there will be multiple commits during code reviews, Should I sq

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2023-10-26 Thread via GitHub
Samrat002 commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-1781024903 [gentle ping] @dannycranmer, i have addressed to all the review comments . Please review the PR whenever time -- This is an automated message from the Apache Git Service

Re: [PR] [FLINK-33164] Support write option sink.ignore-null-value [flink-connector-hbase]

2023-10-26 Thread via GitHub
MartijnVisser commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781047396 It's recommended to have multiple commits in a lot of situations, see https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/ - We can squash bef

Re: [PR] [FLINK-25809][table-api-java] Add table test program infrastructure [flink]

2023-10-26 Thread via GitHub
twalthr merged PR #23584: URL: https://github.com/apache/flink/pull/23584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373034259 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract st

[jira] [Closed] (FLINK-25809) Introduce test infra for building FLIP-190 tests

2023-10-26 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-25809. Fix Version/s: 1.19.0 Resolution: Fixed Fixed in master: 347e4ca6c265334a35969d1c8358ff5a9f

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373121357 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract sta

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1373126000 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

[jira] [Created] (FLINK-33372) Cryptic exception for a sub query in a CompiledPlan

2023-10-26 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33372: Summary: Cryptic exception for a sub query in a CompiledPlan Key: FLINK-33372 URL: https://issues.apache.org/jira/browse/FLINK-33372 Project: Flink I

[jira] [Created] (FLINK-33373) Capture build scans on ge.apache.org to benefit from deep build insights

2023-10-26 Thread Clay Johnson (Jira)
Clay Johnson created FLINK-33373: Summary: Capture build scans on ge.apache.org to benefit from deep build insights Key: FLINK-33373 URL: https://issues.apache.org/jira/browse/FLINK-33373 Project: Fli

[PR] [docs] Add a README to the flink-autoscaler module [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
mxm opened a new pull request, #694: URL: https://github.com/apache/flink-kubernetes-operator/pull/694 This adds a README to the flink-autoscaler module, to clarify its purpose and usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] [FLINK-33373][build] Capture build scans on ge.apache.org to benefit from deep build insights [flink]

2023-10-26 Thread via GitHub
clayburn opened a new pull request, #23602: URL: https://github.com/apache/flink/pull/23602 It was nice meeting some of you at the Gradle booth at Community over Code. We discussed Develocity with some of you, and this would be the PR that enables it. ## What is the purpose o

[jira] [Updated] (FLINK-33373) Capture build scans on ge.apache.org to benefit from deep build insights

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33373: --- Labels: pull-request-available (was: ) > Capture build scans on ge.apache.org to benefit fr

Re: [PR] [FLINK-33373][build] Capture build scans on ge.apache.org to benefit from deep build insights [flink]

2023-10-26 Thread via GitHub
clayburn commented on code in PR #23602: URL: https://github.com/apache/flink/pull/23602#discussion_r1373154854 ## tools/azure-pipelines/build-apache-repo.yml: ## @@ -55,6 +55,7 @@ variables: SECRET_S3_BUCKET: $[variables.IT_CASE_S3_BUCKET] SECRET_S3_ACCESS_KEY: $[variable

Re: [PR] [FLINK-33373][build] Capture build scans on ge.apache.org to benefit from deep build insights [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23602: URL: https://github.com/apache/flink/pull/23602#issuecomment-1781113268 ## CI report: * 416aec02e4876e743df8c76656ad4cf71214cf69 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] test [flink]

2023-10-26 Thread via GitHub
JunRuiLee commented on PR #23598: URL: https://github.com/apache/flink/pull/23598#issuecomment-1781116611 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33164] Support write option sink.ignore-null-value [flink-connector-hbase]

2023-10-26 Thread via GitHub
Tan-JiaLiang commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781118161 @ferenc-csaky @MartijnVisser Thanks for the patience guide. Making sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-33316][runtime] Using SERIALIZED_UDF_CLASS instead of SERIALIZED_UDF_CLASS_NAME [flink]

2023-10-26 Thread via GitHub
1996fanrui merged PR #23597: URL: https://github.com/apache/flink/pull/23597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Comment Edited] (FLINK-33316) Avoid unnecessary heavy getStreamOperatorFactory

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778510#comment-17778510 ] Rui Fan edited comment on FLINK-33316 at 10/26/23 1:31 PM: --- Th

[jira] [Created] (FLINK-33374) Execute REMOVE JAR command failed via SQL gateway

2023-10-26 Thread Xianxun Ye (Jira)
Xianxun Ye created FLINK-33374: -- Summary: Execute REMOVE JAR command failed via SQL gateway Key: FLINK-33374 URL: https://issues.apache.org/jira/browse/FLINK-33374 Project: Flink Issue Type: Im

Re: [PR] test [flink]

2023-10-26 Thread via GitHub
JunRuiLee commented on PR #23598: URL: https://github.com/apache/flink/pull/23598#issuecomment-1781151972 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-33375) Add a RestoreTestBase

2023-10-26 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33375: Summary: Add a RestoreTestBase Key: FLINK-33375 URL: https://issues.apache.org/jira/browse/FLINK-33375 Project: Flink Issue Type: Sub-task

  1   2   >