xuyangzhong commented on code in PR #23519: URL: https://github.com/apache/flink/pull/23519#discussion_r1372829433
########## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java: ########## @@ -66,12 +70,17 @@ * </ul> * </ul> * - * Once Flink applies same logic for both table api and sql, this class should be removed. + * <p>Once Flink applies same logic for both table api and sql, this first changes should be + * removed. + * + * <p>2. It uses PEEK_FIELDS_NO_EXPAND with a nested struct type (Flink [[RowType]]). + * + * <p>See more at {@code LogicalRelDataTypeConverter} and {@code FlinkTypeFactory}. Review Comment: Agree with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org