[GitHub] [flink-kubernetes-operator] ashangit commented on pull request #680: [FLINK-33125] Bump JOSDK to 4.4.4

2023-09-21 Thread via GitHub
ashangit commented on PR #680: URL: https://github.com/apache/flink-kubernetes-operator/pull/680#issuecomment-1729001237 How do you manage to update/generate this NOTICE file, should I do it manually? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-33125) Upgrade JOSDK to 4.4.4

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33125: --- Labels: pull-request-available (was: ) > Upgrade JOSDK to 4.4.4 > -- >

[GitHub] [flink] jiaoqingbo commented on pull request #23127: [FLINK-32223][runtime][security] Add Hive delegation token support And Add HiveServer2DelegationTokenIdentifier to fix compile failed in h

2023-09-21 Thread via GitHub
jiaoqingbo commented on PR #23127: URL: https://github.com/apache/flink/pull/23127#issuecomment-1729060548 > Just arrived back here, was busy lately. Please add the original PR description to this PR + the change what solved the hadoop_313 issue. updated,please take a look,thanks @gab

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23449: [FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-21 Thread via GitHub
Jiabao-Sun opened a new pull request, #23449: URL: https://github.com/apache/flink/pull/23449 ## What is the purpose of the change [FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory ## Brief change lo

[jira] [Updated] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33000: --- Labels: pull-request-available starter (was: starter) > SqlGatewayServiceITCase should util

[GitHub] [flink] flinkbot commented on pull request #23449: [FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-21 Thread via GitHub
flinkbot commented on PR #23449: URL: https://github.com/apache/flink/pull/23449#issuecomment-1729076569 ## CI report: * 51f70ad4520ec6255aef04caccc258968f7f96bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Jiabao-Sun commented on pull request #23449: [FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-21 Thread via GitHub
Jiabao-Sun commented on PR #23449: URL: https://github.com/apache/flink/pull/23449#issuecomment-1729078222 Hi @fsk119, could you help review it when you have time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] mxm commented on pull request #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme

2023-09-21 Thread via GitHub
mxm commented on PR #23406: URL: https://github.com/apache/flink/pull/23406#issuecomment-1729080927 @elkhand Thanks for addressing our comments. We need to squash the commits prior to merging. If I merge using the Github UI it will use elkh...@users.noreply.github.com. This will still the a

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #680: [FLINK-33125] Bump JOSDK to 4.4.4

2023-09-21 Thread via GitHub
gyfora commented on PR #680: URL: https://github.com/apache/flink-kubernetes-operator/pull/680#issuecomment-1729104110 > How do you manage to update/generate this NOTICE file, should I do it manually? In the core Flink project there is some util for this but usually I just run this

[jira] [Commented] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-21 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767488#comment-17767488 ] Jiabao Sun commented on FLINK-33000: I think the OperationManagerTest, ResultFetcher

[GitHub] [flink] Zakelly commented on pull request #23441: [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value

2023-09-21 Thread via GitHub
Zakelly commented on PR #23441: URL: https://github.com/apache/flink/pull/23441#issuecomment-1729445124 @masteryhx Would you please review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Closed] (FLINK-33125) Upgrade JOSDK to 4.4.4

2023-09-21 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33125. -- Resolution: Fixed merged to main fd68924f8db5872092177fc77ab07349d688d0fb > Upgrade JOSDK to 4.4.4 >

[jira] [Commented] (FLINK-30649) Shutting down MiniCluster times out

2023-09-21 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767581#comment-17767581 ] Flaviu Cicio commented on FLINK-30649: -- The issue is not reproducing anymore, thus

[jira] [Commented] (FLINK-33096) Flink on k8s,if one taskmanager pod was crashed,the whole flink job will be failed

2023-09-21 Thread wawa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767595#comment-17767595 ] wawa commented on FLINK-33096: -- So sorry,correct the previous description:   there was an

[GitHub] [flink] tweise merged pull request #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme

2023-09-21 Thread via GitHub
tweise merged PR #23406: URL: https://github.com/apache/flink/pull/23406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-09-21 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise closed FLINK-32884. Resolution: Fixed > PyFlink remote execution should support URLs with paths and https scheme > ---

[GitHub] [flink] hackergin commented on a diff in pull request #23438: [FLINK-33119][table] The pojo result returned be procedure should be Row of fields in the pojo instead of whole pojo object

2023-09-21 Thread via GitHub
hackergin commented on code in PR #23438: URL: https://github.com/apache/flink/pull/23438#discussion_r1333458365 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerCallProcedureOperation.java: ## @@ -277,15 +297,20 @@ static final c

[jira] [Updated] (FLINK-33119) The pojo result returned be procedure should be Row of fields in the pojo instead of the whole pojo object

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33119: --- Labels: pull-request-available (was: ) > The pojo result returned be procedure should be Ro

[jira] [Updated] (FLINK-33107) Update stable-spec upgrade mode on reconciled-spec change

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33107: --- Labels: pull-request-available (was: ) > Update stable-spec upgrade mode on reconciled-spec

[jira] [Updated] (FLINK-31854) Flink connector redshift

2023-09-21 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-31854: --- Description: This is an umbrella Jira for  https://cwiki.apache.org/confluence/display/FLINK/FLIP-30

[GitHub] [flink-kubernetes-operator] Samrat002 commented on a diff in pull request #677: [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces

2023-09-21 Thread via GitHub
Samrat002 commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1333545703 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/state/AutoScalerStateStore.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (FLINK-32995) TPC-DS end-to-end test fails with chmod: cannot access '../target/generator/dsdgen_linux':

2023-09-21 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32995: --- Labels: auto-deprioritized-critical test-stability (was: stale-critical test-stability)

[jira] [Updated] (FLINK-33056) NettyClientServerSslTest#testValidSslConnection fails on AZP

2023-09-21 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-33056: --- Labels: stale-critical test-stability (was: test-stability) I am the [Flink Jira Bot|https:

[jira] [Updated] (FLINK-32851) [JUnit5 Migration] The rest package of flink-runtime module

2023-09-21 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32851: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #23438: [FLINK-33119][table] The pojo result returned be procedure should be Row of fields in the pojo instead of whole pojo object

2023-09-21 Thread via GitHub
luoyuxia commented on code in PR #23438: URL: https://github.com/apache/flink/pull/23438#discussion_r1333768943 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerCallProcedureOperation.java: ## @@ -237,6 +249,14 @@ private TableRes

[GitHub] [flink] luoyuxia commented on pull request #23438: [FLINK-33119][table] The pojo result returned be procedure should be Row of fields in the pojo instead of whole pojo object

2023-09-21 Thread via GitHub
luoyuxia commented on PR #23438: URL: https://github.com/apache/flink/pull/23438#issuecomment-1730617600 @hackergin Thanks for you review. I have addressed your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] luoyuxia closed pull request #23448: [FLINK-33050][table] Atomicity is not supported prompting the user to disable

2023-09-21 Thread via GitHub
luoyuxia closed pull request #23448: [FLINK-33050][table] Atomicity is not supported prompting the user to disable URL: https://github.com/apache/flink/pull/23448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [flink] luoyuxia opened a new pull request, #23450: [FLINK-33119][table] The pojo result returned be procedure should be Row of fields in the pojo instead of whole pojo object

2023-09-21 Thread via GitHub
luoyuxia opened a new pull request, #23450: URL: https://github.com/apache/flink/pull/23450 Backport of #23438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [flink] flinkbot commented on pull request #23450: [FLINK-33119][table] The pojo result returned be procedure should be Row of fields in the pojo instead of whole pojo object

2023-09-21 Thread via GitHub
flinkbot commented on PR #23450: URL: https://github.com/apache/flink/pull/23450#issuecomment-1730695359 ## CI report: * 4106cf094c32a9aad6c88771529e8f1294f67df9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hackergin commented on pull request #23446: [FLINK-32976][runtime] Fix NullPointException when starting flink cluster in standalone mode

2023-09-21 Thread via GitHub
hackergin commented on PR #23446: URL: https://github.com/apache/flink/pull/23446#issuecomment-1730708373 @gaborgsomogyi Should we backport this commit to the 1.17 and 1.18 branches? If so, I'll create the pr. -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (FLINK-30883) Missing JobID caused the k8s e2e test to fail

2023-09-21 Thread Fei Feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767800#comment-17767800 ] Fei Feng commented on FLINK-30883: -- We encountered this problem in our product environm

[jira] [Commented] (FLINK-33051) Unify the GlobalFailureHandler and LabeledGlobalFailureHandler interface

2023-09-21 Thread Matt Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767805#comment-17767805 ] Matt Wang commented on FLINK-33051: --- [~pgaref] I agree with your point of view. Curren

[GitHub] [flink] wangzzu closed pull request #23437: [FLINK-33051] Unify the GlobalFailureHandler and LabeledGlobalFailureHandler interface

2023-09-21 Thread via GitHub
wangzzu closed pull request #23437: [FLINK-33051] Unify the GlobalFailureHandler and LabeledGlobalFailureHandler interface URL: https://github.com/apache/flink/pull/23437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Updated] (FLINK-33051) Unify the GlobalFailureHandler and LabeledGlobalFailureHandler interface

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33051: --- Labels: pull-request-available (was: ) > Unify the GlobalFailureHandler and LabeledGlobalFa

[GitHub] [flink-kubernetes-operator] 1996fanrui commented on a diff in pull request #677: [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces

2023-09-21 Thread via GitHub
1996fanrui commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1333849523 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/state/AutoScalerStateStore.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache So

[GitHub] [flink-benchmarks] masteryhx commented on a diff in pull request #79: [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks

2023-09-21 Thread via GitHub
masteryhx commented on code in PR #79: URL: https://github.com/apache/flink-benchmarks/pull/79#discussion_r1333857024 ## src/main/java/org/apache/flink/state/benchmark/RescalingBenchmarkBase.java: ## @@ -57,6 +63,26 @@ public static void runBenchmark(Class clazz) throws RunnerE

[jira] [Updated] (FLINK-33122) [Benchmark] Null checkpoint directory in rescaling benchmarks

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33122: --- Labels: pull-request-available (was: ) > [Benchmark] Null checkpoint directory in rescaling

[GitHub] [flink-ml] jiangxin369 commented on pull request #256: [FLINK-33118] Remove the PythonBridgeUtils

2023-09-21 Thread via GitHub
jiangxin369 commented on PR #256: URL: https://github.com/apache/flink-ml/pull/256#issuecomment-1730801486 @lindong28 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (FLINK-33118) Remove the PythonBridgeUtils

2023-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33118: --- Labels: pull-request-available (was: ) > Remove the PythonBridgeUtils > ---

[GitHub] [flink] huwh closed pull request #23242: [FLINK-32851][runtime][JUnit5 Migration] The rest package of flink-runtime module

2023-09-21 Thread via GitHub
huwh closed pull request #23242: [FLINK-32851][runtime][JUnit5 Migration] The rest package of flink-runtime module URL: https://github.com/apache/flink/pull/23242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Resolved] (FLINK-32851) [JUnit5 Migration] The rest package of flink-runtime module

2023-09-21 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-32851. --- Fix Version/s: 1.19.0 Resolution: Fixed master: 4817db916889a7701481fb04333a7f8da9f5b583 > [

[jira] [Assigned] (FLINK-33118) Remove the PythonBridgeUtils

2023-09-21 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-33118: Assignee: Jiang Xin > Remove the PythonBridgeUtils > > >