[GitHub] [flink] xintongsong commented on a diff in pull request #23255: [FLINK-32870][network] Tiered storage supports reading multiple small buffers by reading and slicing one large buffer

2023-09-11 Thread via GitHub
xintongsong commented on code in PR #23255: URL: https://github.com/apache/flink/pull/23255#discussion_r1320960943 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/file/PartitionFileReader.java: ## @@ -40,16 +42,22 @@ public interface Pa

[jira] [Commented] (FLINK-33019) Pulsar tests hangs during nightly builds

2023-09-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763587#comment-17763587 ] Zili Chen commented on FLINK-33019: --- It seems we can sometimes pass the test https://

[jira] [Comment Edited] (FLINK-33019) Pulsar tests hangs during nightly builds

2023-09-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763587#comment-17763587 ] Zili Chen edited comment on FLINK-33019 at 9/11/23 7:57 AM:

[jira] [Comment Edited] (FLINK-33019) Pulsar tests hangs during nightly builds

2023-09-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763587#comment-17763587 ] Zili Chen edited comment on FLINK-33019 at 9/11/23 7:57 AM:

[GitHub] [flink] Tartarus0zm opened a new pull request, #23389: [FLINK-33050][table] Atomicity is not supported prompting the user to disable

2023-09-11 Thread via GitHub
Tartarus0zm opened a new pull request, #23389: URL: https://github.com/apache/flink/pull/23389 ## What is the purpose of the change * When atomicity is enabled, an exception may occur when creating a DynamicTableSink, and we need to prompt the user to disable atomicity. * When we u

[jira] [Updated] (FLINK-33050) Prompts user to close when atomicity implementation is not supported

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33050: --- Labels: pull-request-available (was: ) > Prompts user to close when atomicity implementatio

[jira] [Closed] (FLINK-31889) Add documentation for implementing/loading enrichers

2023-09-11 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31889. Fix Version/s: 1.18.0 Resolution: Fixed master: 484da993e22c30b0c9e2bcf747036a79443

[jira] [Updated] (FLINK-31889) Add documentation for implementing/loading enrichers

2023-09-11 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-31889: - Component/s: Documentation > Add documentation for implementing/loading enrichers >

[GitHub] [flink] Tartarus0zm commented on pull request #23389: [FLINK-33050][table] Atomicity is not supported prompting the user to disable

2023-09-11 Thread via GitHub
Tartarus0zm commented on PR #23389: URL: https://github.com/apache/flink/pull/23389#issuecomment-1713410133 @luoyuxia PTAL, if you have time , thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink] hlteoh37 merged pull request #23384: [FLINK-32962][python] Remove pip version check on installing dependencies.

2023-09-11 Thread via GitHub
hlteoh37 merged PR #23384: URL: https://github.com/apache/flink/pull/23384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] flinkbot commented on pull request #23389: [FLINK-33050][table] Atomicity is not supported prompting the user to disable

2023-09-11 Thread via GitHub
flinkbot commented on PR #23389: URL: https://github.com/apache/flink/pull/23389#issuecomment-1713411337 ## CI report: * 0b267db9f245464c2533666832ca75207be4822b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #23255: [FLINK-32870][network] Tiered storage supports reading multiple small buffers by reading and slicing one large buffer

2023-09-11 Thread via GitHub
TanYuxin-tyx commented on code in PR #23255: URL: https://github.com/apache/flink/pull/23255#discussion_r1321213128 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/file/ProducerMergedPartitionFileReader.java: ## @@ -51,101 +60,91 @@ *

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321266685 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java: ## @@ -496,6 +556,8 @@ private final class ExecutingStateBuilder {

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321269048 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -55,7 +63,9 @@ class Executing extends StateWithExecutionGraph implem

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-09-11 Thread via GitHub
1996fanrui commented on code in PR #23218: URL: https://github.com/apache/flink/pull/23218#discussion_r1321290658 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/SnapshotDirectoryTest.java: ## @@ -19,180 +19,167 @@ package org.apache.flink.runtime.state; import

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321300535 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -488,6 +488,23 @@ public enum SchedulerType {

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321325324 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVert

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #23301: [FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/rpc tests to JUnit5

2023-09-11 Thread via GitHub
ferenc-csaky commented on code in PR #23301: URL: https://github.com/apache/flink/pull/23301#discussion_r1321298136 ## flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcEndpointTest.java: ## @@ -91,35 +85,31 @@ public void testSelfGateway() throws Exception { * b

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #23301: [FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/rpc tests to JUnit5

2023-09-11 Thread via GitHub
ferenc-csaky commented on code in PR #23301: URL: https://github.com/apache/flink/pull/23301#discussion_r1307420110 ## flink-runtime/src/test/java/org/apache/flink/runtime/rpc/FencedRpcEndpointTest.java: ## @@ -88,20 +84,20 @@ public void testFencing() throws Exception {

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #23301: [FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/rpc tests to JUnit5

2023-09-11 Thread via GitHub
ferenc-csaky commented on code in PR #23301: URL: https://github.com/apache/flink/pull/23301#discussion_r1307420821 ## flink-runtime/src/test/java/org/apache/flink/runtime/rpc/FencedRpcEndpointTest.java: ## @@ -136,16 +132,15 @@ public void testUnfencedRemoteGateway() throws Exc

[GitHub] [flink] luoyuxia commented on a diff in pull request #23370: [FLINK-32731][e2e] Fix NameNode uses port 9870 in hadoop3

2023-09-11 Thread via GitHub
luoyuxia commented on code in PR #23370: URL: https://github.com/apache/flink/pull/23370#discussion_r1321345703 ## flink-end-to-end-tests/flink-end-to-end-tests-hive/src/test/java/org/apache/flink/tests/hive/containers/HiveContainers.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed t

[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-09-11 Thread via GitHub
Jiabao-Sun commented on PR #23218: URL: https://github.com/apache/flink/pull/23218#issuecomment-1713643735 Test count verified: master passed: 1291, ignored: 98, total: 1389 updated: passed: 1291, ignored: 98, total: 1383, disabled: 7 -- This is an automated messa

[jira] [Commented] (FLINK-24943) SequenceNumber class is not POJO type

2023-09-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763651#comment-17763651 ] Danny Cranmer commented on FLINK-24943: --- Merged commit [{{b996d1d}}|https://githu

[jira] [Resolved] (FLINK-24943) SequenceNumber class is not POJO type

2023-09-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-24943. --- Resolution: Fixed > SequenceNumber class is not POJO type >

[GitHub] [flink] Jiabao-Sun commented on pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-09-11 Thread via GitHub
Jiabao-Sun commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1713675563 Test count verified of `org.apache.flink.runtime.io` package: master passed: 1847, ignored: 5, total: 1852 updated: passed: 1847, ignored: 5, total: 1852 -- This is

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321387884 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -47,6 +51,10 @@ class Executing extends StateWithExecutionGraph impl

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321390908 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -47,6 +51,10 @@ class Executing extends StateWithExecutionGraph impl

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321393999 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph impl

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #666: [FLINK-33067] Expose rate limiter config and enable by default

2023-09-11 Thread via GitHub
mxm commented on code in PR #666: URL: https://github.com/apache/flink-kubernetes-operator/pull/666#discussion_r1321394405 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java: ## @@ -220,8 +227,14 @@ private sta

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #666: [FLINK-33067] Expose rate limiter config and enable by default

2023-09-11 Thread via GitHub
mxm commented on code in PR #666: URL: https://github.com/apache/flink-kubernetes-operator/pull/666#discussion_r1321395107 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java: ## @@ -220,8 +227,14 @@ private sta

[GitHub] [flink] JunRuiLee opened a new pull request, #23390: test

2023-09-11 Thread via GitHub
JunRuiLee opened a new pull request, #23390: URL: https://github.com/apache/flink/pull/23390 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] flinkbot commented on pull request #23390: test

2023-09-11 Thread via GitHub
flinkbot commented on PR #23390: URL: https://github.com/apache/flink/pull/23390#issuecomment-1713696403 ## CI report: * ededd4f96724561d6607668f9762d7860772d4e8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] xintongsong commented on a diff in pull request #23058: [FLINK-32978] Deprecate RichFunction#open(Configuration parameters)

2023-09-11 Thread via GitHub
xintongsong commented on code in PR #23058: URL: https://github.com/apache/flink/pull/23058#discussion_r1321401189 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/RichIterativeCondition.java: ## @@ -67,7 +67,13 @@ public IterationRuntimeContext

[jira] [Updated] (FLINK-32978) Deprecate RichFunction#open(Configuration parameters)

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32978: --- Labels: pull-request-available (was: ) > Deprecate RichFunction#open(Configuration paramete

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #666: [FLINK-33067] Expose rate limiter config and enable by default

2023-09-11 Thread via GitHub
gyfora commented on code in PR #666: URL: https://github.com/apache/flink-kubernetes-operator/pull/666#discussion_r1321408754 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java: ## @@ -220,8 +227,14 @@ private

[GitHub] [flink] xintongsong closed pull request #23073: [FLINK-32979] Deprecate WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env)

2023-09-11 Thread via GitHub
xintongsong closed pull request #23073: [FLINK-32979] Deprecate WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env) URL: https://github.com/apache/flink/pull/23073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-32979) Deprecate WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env)

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32979: --- Labels: pull-request-available (was: ) > Deprecate WindowAssigner#getDefaultTrigger(StreamE

[jira] [Closed] (FLINK-32979) Deprecate WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env)

2023-09-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-32979. Assignee: Wencong Liu Resolution: Done master (1.19): 831cb8eff022db5543052c96716518c862

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321412724 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVer

[jira] [Updated] (FLINK-33070) Add doc for 'unnest'

2023-09-11 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33070: - Description: Row and column transformation is a commonly used approach. In Flink SQL, we can use unnest

[jira] [Created] (FLINK-33070) Add doc for 'unnest'

2023-09-11 Thread Feng Jin (Jira)
Feng Jin created FLINK-33070: Summary: Add doc for 'unnest' Key: FLINK-33070 URL: https://issues.apache.org/jira/browse/FLINK-33070 Project: Flink Issue Type: Improvement Components: T

[GitHub] [flink] FangYongs merged pull request #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

2023-09-11 Thread via GitHub
FangYongs merged PR #22832: URL: https://github.com/apache/flink/pull/22832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Closed] (FLINK-32396) Support timestamp for jdbc driver and gateway

2023-09-11 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong closed FLINK-32396. - Fix Version/s: 1.19.0 Resolution: Fixed Fixed by c33a6527d8383dc571e0b648b8a29322416ab9d6 > Supp

[GitHub] [flink] fsk119 commented on a diff in pull request #23370: [FLINK-32731][e2e] Fix NameNode uses port 9870 in hadoop3

2023-09-11 Thread via GitHub
fsk119 commented on code in PR #23370: URL: https://github.com/apache/flink/pull/23370#discussion_r1321487326 ## flink-end-to-end-tests/flink-end-to-end-tests-hive/src/test/java/org/apache/flink/tests/hive/containers/HiveContainers.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-33070) Add doc for 'unnest'

2023-09-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763700#comment-17763700 ] Benchao Li commented on FLINK-33070: FYI, {{UNNEST}} is documented under the [Joins

[jira] [Commented] (FLINK-33070) Add doc for 'unnest'

2023-09-11 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763704#comment-17763704 ] Feng Jin commented on FLINK-33070: -- Thanks [~libenchao] ,  Sorry, I tried searching bef

[jira] [Closed] (FLINK-33070) Add doc for 'unnest'

2023-09-11 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin closed FLINK-33070. Resolution: Not A Problem > Add doc for 'unnest' > - > > Key: FLINK-3

[jira] [Updated] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33053: --- Affects Version/s: 1.18.0 > Watcher leak in Zookeeper HA mode > - >

[jira] [Updated] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33053: --- Priority: Blocker (was: Critical) > Watcher leak in Zookeeper HA mode > ---

[jira] [Updated] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33053: --- Priority: Critical (was: Blocker) > Watcher leak in Zookeeper HA mode > ---

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763713#comment-17763713 ] Yangze Guo commented on FLINK-33053: I just find that this issue is very easy to rep

[jira] [Updated] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33053: --- Priority: Blocker (was: Critical) > Watcher leak in Zookeeper HA mode > ---

[jira] [Commented] (FLINK-32671) Document Externalized Declarative Resource Management

2023-09-11 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763714#comment-17763714 ] ConradJam commented on FLINK-32671: --- I've added this piece of description because FLIP

[jira] [Updated] (FLINK-33029) Drop python 3.7 support

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33029: --- Labels: pull-request-available (was: ) > Drop python 3.7 support > ---

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321325324 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVert

[GitHub] [flink] RocMarshal commented on a diff in pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched

2023-09-11 Thread via GitHub
RocMarshal commented on code in PR #23379: URL: https://github.com/apache/flink/pull/23379#discussion_r132166 ## flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgramUtils.java: ## @@ -183,7 +183,8 @@ public static Pipeline getPipelineFromProgram(

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321602343 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVert

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321602343 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVert

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321641317 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVer

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-09-11 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321654007 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,17 +154,33 @@ private void handleDeploymentFailure(ExecutionVer

[GitHub] [flink] mxm commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyF

2023-09-11 Thread via GitHub
mxm commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321673233 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to th

[GitHub] [flink] tweise commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
tweise commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321682712 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #23359: [FLINK-33029][python] Drop python 3.7 support

2023-09-11 Thread via GitHub
gaborgsomogyi commented on code in PR #23359: URL: https://github.com/apache/flink/pull/23359#discussion_r1321570938 ## tools/releasing/create_binary_release.sh: ## @@ -129,8 +129,8 @@ make_python_release() { cp ${pyflink_actual_name} "${PYTHON_RELEASE_DIR}/${pyflink_release_

[jira] [Resolved] (FLINK-32854) [JUnit5 Migration] The state package of flink-runtime module

2023-09-11 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32854. - Fix Version/s: 1.19.0 Resolution: Fixed > [JUnit5 Migration] The state package of flink-runtime m

[jira] [Commented] (FLINK-32854) [JUnit5 Migration] The state package of flink-runtime module

2023-09-11 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763765#comment-17763765 ] Rui Fan commented on FLINK-32854: - Merged via 554810abbbd44a656a446d051b3dd199b0df9055

[GitHub] [flink] tweise commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
tweise commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321705462 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java: ## @@ -41,7 +40,7 @@ */ public class UrlPrefixDecorator<

[GitHub] [flink] tweise commented on pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink re

2023-09-11 Thread via GitHub
tweise commented on PR #23383: URL: https://github.com/apache/flink/pull/23383#issuecomment-1714118207 @afedulov PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Created] (FLINK-33071) Log checkpoint statistics

2023-09-11 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33071: -- Summary: Log checkpoint statistics Key: FLINK-33071 URL: https://issues.apache.org/jira/browse/FLINK-33071 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-23411) Expose Flink checkpoint details metrics

2023-09-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763789#comment-17763789 ] Piotr Nowojski commented on FLINK-23411: Hey, I've just upon this ticket as we a

[jira] [Comment Edited] (FLINK-23411) Expose Flink checkpoint details metrics

2023-09-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763789#comment-17763789 ] Piotr Nowojski edited comment on FLINK-23411 at 9/11/23 3:51 PM: -

[GitHub] [flink-connector-gcp-pubsub] RyanSkraba opened a new pull request, #19: [FLINK-33018][Tests] Fix flaky test when cancelling source

2023-09-11 Thread via GitHub
RyanSkraba opened a new pull request, #19: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/19 We sometimes observe the test failure described in FLINK-33018 ``` Expected :["1", "2", "3"] Actual :["1", "2"] ``` This occurs because the thread running the

[jira] [Updated] (FLINK-33018) GCP Pubsub PubSubConsumingTest.testStoppingConnectorWhenDeserializationSchemaIndicatesEndOfStream failed

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33018: --- Labels: pull-request-available (was: ) > GCP Pubsub > PubSubConsumingTest.testStoppingConn

[GitHub] [flink] ferenc-csaky commented on pull request #23343: [BP-1.18][FLINK-32999][connectors/hbase] Remove HBase connector code from main repo

2023-09-11 Thread via GitHub
ferenc-csaky commented on PR #23343: URL: https://github.com/apache/flink/pull/23343#issuecomment-1714173307 @snuyanzin can you merge this one as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (FLINK-33071) Log checkpoint statistics

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33071: --- Labels: pull-request-available (was: ) > Log checkpoint statistics > -

[GitHub] [flink] pnowojski opened a new pull request, #23391: [FLINK-33071][metrics,checkpointing] Log a json dump of checkpoint statistics when checkpoint complets or fails

2023-09-11 Thread via GitHub
pnowojski opened a new pull request, #23391: URL: https://github.com/apache/flink/pull/23391 ## What is the purpose of the change This adds a DEBUG level log message that contains all checkpoint stats on every completed/failed checkpoint. A stop-gap solution until we come up with a p

[GitHub] [flink] flinkbot commented on pull request #23391: [FLINK-33071][metrics,checkpointing] Log a json dump of checkpoint statistics when checkpoint complets or fails

2023-09-11 Thread via GitHub
flinkbot commented on PR #23391: URL: https://github.com/apache/flink/pull/23391#issuecomment-1714278117 ## CI report: * 7571dc3f4381b14c4764a19de346fd4e44bb59dc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] elkhand commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
elkhand commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321865428 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed t

[GitHub] [flink] elkhand commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
elkhand commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321865428 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed t

[GitHub] [flink] elkhand commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
elkhand commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321868038 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/util/SQLGatewayUrlPrefixDecorator.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed t

[GitHub] [flink] elkhand commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
elkhand commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321869568 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/MonitoringApiMessageHeaders.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink] elkhand commented on a diff in pull request #23383: [FLINK-32885 ] [flink-clients] Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for

2023-09-11 Thread via GitHub
elkhand commented on code in PR #23383: URL: https://github.com/apache/flink/pull/23383#discussion_r1321874986 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java: ## @@ -41,7 +40,7 @@ */ public class UrlPrefixDecorator<

[GitHub] [flink] pgaref commented on a diff in pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded

2023-09-11 Thread via GitHub
pgaref commented on code in PR #23386: URL: https://github.com/apache/flink/pull/23386#discussion_r1321976643 ## flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java: ## @@ -106,23 +108,34 @@ static Collection getFailureEnrichers( }

[jira] [Commented] (FLINK-33066) Enable to inject environment variable from secret/configmap to operatorPod

2023-09-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763887#comment-17763887 ] Gyula Fora commented on FLINK-33066: I think this would be a nice improvement :)  >

[jira] [Assigned] (FLINK-33066) Enable to inject environment variable from secret/configmap to operatorPod

2023-09-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33066: -- Assignee: dongwoo.kim > Enable to inject environment variable from secret/configmap to operat

[GitHub] [flink] rkhachatryan commented on a diff in pull request #23391: [FLINK-33071][metrics,checkpointing] Log a json dump of checkpoint statistics when checkpoint complets or fails

2023-09-11 Thread via GitHub
rkhachatryan commented on code in PR #23391: URL: https://github.com/apache/flink/pull/23391#discussion_r1321980461 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -227,11 +257,23 @@ void reportFailedCheckpoint(FailedCheckpoi

[GitHub] [flink] snuyanzin merged pull request #23343: [BP-1.18][FLINK-32999][connectors/hbase] Remove HBase connector code from main repo

2023-09-11 Thread via GitHub
snuyanzin merged PR #23343: URL: https://github.com/apache/flink/pull/23343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Commented] (FLINK-32999) Remove HBase connector from master branch

2023-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763905#comment-17763905 ] Sergey Nuyanzin commented on FLINK-32999: - Merged to 1.18 as [53981d81d378770f8

[jira] [Resolved] (FLINK-32999) Remove HBase connector from master branch

2023-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32999. - Fix Version/s: 1.18.0 1.19.0 Resolution: Fixed > Remove HBase

[GitHub] [flink] flinkbot commented on pull request #23392: [BP-1.17][FLINK-33010][table] GREATEST/LEAST should work with other functions as input

2023-09-11 Thread via GitHub
flinkbot commented on PR #23392: URL: https://github.com/apache/flink/pull/23392#issuecomment-1714518365 ## CI report: * d7e7c703c9a23d18f5c44a0c8b42db7d6afe46a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23393: [BP-1.18][FLINK-33010][table] GREATEST/LEAST should work with other functions as input

2023-09-11 Thread via GitHub
flinkbot commented on PR #23393: URL: https://github.com/apache/flink/pull/23393#issuecomment-1714524505 ## CI report: * e296671f364fdeda71054bc090ad35e3f77ad07b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-elasticsearch] snuyanzin merged pull request #39: [FLINK-29042][Connectors/ElasticSearch] Support lookup join for es connector

2023-09-11 Thread via GitHub
snuyanzin merged PR #39: URL: https://github.com/apache/flink-connector-elasticsearch/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #39: [FLINK-29042][Connectors/ElasticSearch] Support lookup join for es connector

2023-09-11 Thread via GitHub
boring-cyborg[bot] commented on PR #39: URL: https://github.com/apache/flink-connector-elasticsearch/pull/39#issuecomment-1714536181 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Closed] (FLINK-29042) Support lookup join for es connector

2023-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-29042. --- Fix Version/s: elasticsearch-4.0.0 Resolution: Fixed > Support lookup join for es con

[GitHub] [flink] flinkbot commented on pull request #23394: [BP-1.16][FLINK-33010][table] GREATEST/LEAST should work with other functions as input

2023-09-11 Thread via GitHub
flinkbot commented on PR #23394: URL: https://github.com/apache/flink/pull/23394#issuecomment-1714538178 ## CI report: * fa40b4f52627a9b2fc32b48b138310311d211a6e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29042) Support lookup join for es connector

2023-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763915#comment-17763915 ] Sergey Nuyanzin commented on FLINK-29042: - Merged as [fef5c964f4a2fc8b61c482b0b

[GitHub] [flink] dalelane opened a new pull request, #23395: [FLINK-33058][formats] Add encoding option to Avro format

2023-09-11 Thread via GitHub
dalelane opened a new pull request, #23395: URL: https://github.com/apache/flink/pull/23395 ## What is the purpose of the change Initially proposed in https://issues.apache.org/jira/browse/FLINK-33058 Avro supports two serialization encoding methods: binary and JSON (cf. [Avro

[jira] [Updated] (FLINK-33058) Support for JSON-encoded Avro

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33058: --- Labels: avro flink flink-formats pull-request-available (was: avro flink flink-formats) >

[GitHub] [flink] flinkbot commented on pull request #23395: [FLINK-33058][formats] Add encoding option to Avro format

2023-09-11 Thread via GitHub
flinkbot commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1714582332 ## CI report: * 858c3eebae767ea71e1d43fc5e8f4af88f924c4a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-pulsar] nlu90 commented on pull request #59: [FLINK-32938] Replace pulsar admin calls

2023-09-11 Thread via GitHub
nlu90 commented on PR #59: URL: https://github.com/apache/flink-connector-pulsar/pull/59#issuecomment-1714662290 Can someone help rerun the CI? On my local laptop, everything runs fine: ``` -> mvn clean verify ... ... ... [INFO] ---

[jira] [Updated] (FLINK-32938) flink-connector-pulsar should remove all `PulsarAdmin` calls

2023-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32938: --- Labels: pull-request-available (was: ) > flink-connector-pulsar should remove all `PulsarAd

  1   2   >