echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321300535
########## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ########## @@ -488,6 +488,23 @@ public enum SchedulerType { code(SchedulerExecutionMode.REACTIVE.name())) .build()); + @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING) + public static final ConfigOption<Duration> SCHEDULER_SCALING_INTERVAL_MIN = + key("jobmanager.adaptive-scheduler.scaling-interval.min") + .durationType() + .defaultValue(Duration.ofSeconds(30)) + // rescaling and let the user increase the value for high workloads + .withDescription( + "Determines the minimum time (in seconds) between scaling operations in reactive mode."); Review Comment: 1. if the parameter value is passed by CLI as a String, will the duration be parsed correctly with the correct timeUnit? 2. yes but new resources addition call that triggers the rescale (and the cooldown period) only happens in reactive mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org