[GitHub] [flink-connector-redis-streams] eskabetxe commented on pull request #3: [FLINK-15571] Add Redis sink

2022-11-29 Thread GitBox
eskabetxe commented on PR #3: URL: https://github.com/apache/flink-connector-redis-streams/pull/3#issuecomment-1330710004 Hi @MartijnVisser , @sazzad16 I update the code to only have Redis Streams with the format of flink-connectors if you could check this, then we move to other thin

[GitHub] [flink] zentol commented on pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
zentol commented on PR #21416: URL: https://github.com/apache/flink/pull/21416#issuecomment-1330711423 I think we actually found a bug. If a split was already assigned to a reader, then the first call to `SourceReader#pollNext` (which happens _before_ `SourceReader#isAvailable`) circ

[GitHub] [flink] zentol commented on pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
zentol commented on PR #21416: URL: https://github.com/apache/flink/pull/21416#issuecomment-1330713451 Additionally, the RateLimitedSourceReader may reset the checkpoint limit at the wrong time. We don't really that to happen when the checkpoint is complete, but rather when the next checkpo

[jira] [Updated] (FLINK-30202) DataGeneratorSourceITCase.testGatedRateLimiter failed

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30202: - Issue Type: Bug (was: Technical Debt) > DataGeneratorSourceITCase.testGatedRateLimiter

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-29 Thread GitBox
gyfora commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330717183 > Yes, I think it can, in that case, how should we adjust it please? You can look at the CI config to get an idea: https://github.com/apache/flink-kubernetes-oper

[jira] [Updated] (FLINK-30202) RateLimitedSourceReader may emit one more record than permitted

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30202: - Summary: RateLimitedSourceReader may emit one more record than permitted (was: DataGene

[GitHub] [flink-connector-opensearch] zentol commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034824729 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed

[GitHub] [flink-connector-opensearch] zentol commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034832065 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed

[jira] [Commented] (FLINK-30232) shading of netty epoll shared library does not account for ARM64 platform

2022-11-29 Thread Chris Thomson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640745#comment-17640745 ] Chris Thomson commented on FLINK-30232: --- Our team is trying to get approval to con

[GitHub] [flink] MartijnVisser merged pull request #21327: Bump loader-utils from 2.0.2 to 2.0.4 in /flink-runtime-web/web-dashboard

2022-11-29 Thread GitBox
MartijnVisser merged PR #21327: URL: https://github.com/apache/flink/pull/21327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Updated] (FLINK-30228) RateLimitedSourceReaderITCase.testRateLimitingParallelExecution failed

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30228: --- Fix Version/s: 1.17.0 (was: 1.17) > RateLimitedSourceReaderITCase.tes

[GitHub] [flink] MartijnVisser merged pull request #21279: Bump socket.io-parser from 4.0.4 to 4.0.5 in /flink-runtime-web/web-dashboard

2022-11-29 Thread GitBox
MartijnVisser merged PR #21279: URL: https://github.com/apache/flink/pull/21279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Closed] (FLINK-30172) Bump loader-utils from 2.0.2 to 2.0.4

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30172. -- Fix Version/s: 1.17.0 Resolution: Fixed Fixed in master: 45d12dc840a8883af41112dea679d7

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #453: [FLINK-30216] Improve code quality by standardising tab/spaces in pom…

2022-11-29 Thread GitBox
mbalassi merged PR #453: URL: https://github.com/apache/flink-kubernetes-operator/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Closed] (FLINK-30171) Bump socket.io-parser from 4.0.4 to 4.0.5

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30171. -- Fix Version/s: 1.17.0 Resolution: Fixed Fixed in master: d2cf55ca062bcf7e4c13627fd4973d

[GitHub] [flink-connector-jdbc] MartijnVisser merged pull request #1: [FLINK-30060][Connector/JDBC] Move existing JDBC connector code from Flink repo to dedicated JDBC repo

2022-11-29 Thread GitBox
MartijnVisser merged PR #1: URL: https://github.com/apache/flink-connector-jdbc/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #1: [FLINK-30060][Connector/JDBC] Move existing JDBC connector code from Flink repo to dedicated JDBC repo

2022-11-29 Thread GitBox
boring-cyborg[bot] commented on PR #1: URL: https://github.com/apache/flink-connector-jdbc/pull/1#issuecomment-1330764706 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-connector-pulsar] zentol commented on a diff in pull request #1: [FLINK-30054][Connector/Pulsar] Move existing Pulsar connector code

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-pulsar/pull/1#discussion_r1034854387 ## pom.xml: ## @@ -0,0 +1,387 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"; +xmlns="http://maven.apache.org/

[jira] [Closed] (FLINK-30216) Address tabs/spaces in checkstyle/spotless

2022-11-29 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30216. -- Fix Version/s: kubernetes-operator-1.3.0 Resolution: Fixed [{{80e5f3f}}|https://github.

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #453: [FLINK-30216] Improve code quality by standardising tab/spaces in pom…

2022-11-29 Thread GitBox
darenwkt commented on code in PR #453: URL: https://github.com/apache/flink-kubernetes-operator/pull/453#discussion_r1034854664 ## pom.xml: ## @@ -349,6 +349,36 @@ under the License. + + +org.code

[jira] [Closed] (FLINK-30060) Move existing JDBC connector code from Flink repo to dedicated JDBC repo

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30060. -- Fix Version/s: jdbc-3.0.0 Resolution: Fixed Fixed in master: 9559acf3af9773e6c37c5722d0

[jira] [Updated] (FLINK-29871) Upgrade operator Flink version and examples to 1.16

2022-11-29 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi updated FLINK-29871: --- Fix Version/s: kubernetes-operator-1.4.0 (was: kubernetes-operator-1.3

[jira] [Commented] (FLINK-28186) Trigger Operator Events on Configuration Changes

2022-11-29 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640757#comment-17640757 ] Márton Balassi commented on FLINK-28186: [~morhidi] could you give an update on

[jira] [Commented] (FLINK-29906) Address tabs/spaces in checkstyle/spotless

2022-11-29 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640758#comment-17640758 ] Daren Wong commented on FLINK-29906: Thanks Chesnay, just an update that this is app

[GitHub] [flink] MartijnVisser commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

2022-11-29 Thread GitBox
MartijnVisser commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1330775099 We've now moved the code from the JDBC connector; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automated message from the Apache Git Ser

[GitHub] [flink] MartijnVisser commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

2022-11-29 Thread GitBox
MartijnVisser commented on PR #21223: URL: https://github.com/apache/flink/pull/21223#issuecomment-1330775383 We've now moved the code from the JDBC connector; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automated message from the Apache Git Ser

[GitHub] [flink] MartijnVisser commented on pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources

2022-11-29 Thread GitBox
MartijnVisser commented on PR #21146: URL: https://github.com/apache/flink/pull/21146#issuecomment-1330775996 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser commented on pull request #20193: [FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

2022-11-29 Thread GitBox
MartijnVisser commented on PR #20193: URL: https://github.com/apache/flink/pull/20193#issuecomment-1330776493 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser commented on pull request #11973: [FLINK-17488] Now JdbcConnectionOptions supports autoCommit control

2022-11-29 Thread GitBox
MartijnVisser commented on PR #11973: URL: https://github.com/apache/flink/pull/11973#issuecomment-1330777667 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #11973: [FLINK-17488] Now JdbcConnectionOptions supports autoCommit control

2022-11-29 Thread GitBox
MartijnVisser closed pull request #11973: [FLINK-17488] Now JdbcConnectionOptions supports autoCommit control URL: https://github.com/apache/flink/pull/11973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] MartijnVisser commented on pull request #20304: [FLINK-28600][Connector][JDBC] Support FilterPushDown in flink-connector-jdbc

2022-11-29 Thread GitBox
MartijnVisser commented on PR #20304: URL: https://github.com/apache/flink/pull/20304#issuecomment-1330778005 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser commented on pull request #19297: [FLINK-26848][JDBC]Support to write data when disable flush-interval and max-rows

2022-11-29 Thread GitBox
MartijnVisser commented on PR #19297: URL: https://github.com/apache/flink/pull/19297#issuecomment-1330779606 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #19297: [FLINK-26848][JDBC]Support to write data when disable flush-interval and max-rows

2022-11-29 Thread GitBox
MartijnVisser closed pull request #19297: [FLINK-26848][JDBC]Support to write data when disable flush-interval and max-rows URL: https://github.com/apache/flink/pull/19297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] MartijnVisser closed pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector

2022-11-29 Thread GitBox
MartijnVisser closed pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector URL: https://github.com/apache/flink/pull/13245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] MartijnVisser commented on pull request #19829: [FLINK-27807][Connectors/JDBC] The improvement of addBatch is empty w…

2022-11-29 Thread GitBox
MartijnVisser commented on PR #19829: URL: https://github.com/apache/flink/pull/19829#issuecomment-1330780633 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #19829: [FLINK-27807][Connectors/JDBC] The improvement of addBatch is empty w…

2022-11-29 Thread GitBox
MartijnVisser closed pull request #19829: [FLINK-27807][Connectors/JDBC] The improvement of addBatch is empty w… URL: https://github.com/apache/flink/pull/19829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [flink] MartijnVisser commented on pull request #16609: [FLINK-23324][connector/jdbc] Make Postgres case-sensitive.

2022-11-29 Thread GitBox
MartijnVisser commented on PR #16609: URL: https://github.com/apache/flink/pull/16609#issuecomment-1330780927 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #20304: [FLINK-28600][Connector][JDBC] Support FilterPushDown in flink-connector-jdbc

2022-11-29 Thread GitBox
MartijnVisser closed pull request #20304: [FLINK-28600][Connector][JDBC] Support FilterPushDown in flink-connector-jdbc URL: https://github.com/apache/flink/pull/20304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] MartijnVisser commented on pull request #13245: [FLINK-17826][jdbc] Add missing custom query support on new jdbc connector

2022-11-29 Thread GitBox
MartijnVisser commented on PR #13245: URL: https://github.com/apache/flink/pull/13245#issuecomment-1330780149 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #17933: [FLINK-24948][jdbc] Fix bug that special character in column names breaks JDBC statement parsing

2022-11-29 Thread GitBox
MartijnVisser closed pull request #17933: [FLINK-24948][jdbc] Fix bug that special character in column names breaks JDBC statement parsing URL: https://github.com/apache/flink/pull/17933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [flink] MartijnVisser closed pull request #16609: [FLINK-23324][connector/jdbc] Make Postgres case-sensitive.

2022-11-29 Thread GitBox
MartijnVisser closed pull request #16609: [FLINK-23324][connector/jdbc] Make Postgres case-sensitive. URL: https://github.com/apache/flink/pull/16609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] MartijnVisser closed pull request #19495: [FLINK-27268][JDBC Connector] fix build sql query error in JdbcDynamicTableSource

2022-11-29 Thread GitBox
MartijnVisser closed pull request #19495: [FLINK-27268][JDBC Connector] fix build sql query error in JdbcDynamicTableSource URL: https://github.com/apache/flink/pull/19495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] MartijnVisser commented on pull request #12983: [FLINK-18640][jdbc]Fix jdbc table name with schema error

2022-11-29 Thread GitBox
MartijnVisser commented on PR #12983: URL: https://github.com/apache/flink/pull/12983#issuecomment-1330782229 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser commented on pull request #19495: [FLINK-27268][JDBC Connector] fix build sql query error in JdbcDynamicTableSource

2022-11-29 Thread GitBox
MartijnVisser commented on PR #19495: URL: https://github.com/apache/flink/pull/19495#issuecomment-1330781583 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser commented on pull request #19053: [FLINK-26595][flink-connector-jdbc][postgreSQL]Improve the PostgresDi…

2022-11-29 Thread GitBox
MartijnVisser commented on PR #19053: URL: https://github.com/apache/flink/pull/19053#issuecomment-1330781954 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #19053: [FLINK-26595][flink-connector-jdbc][postgreSQL]Improve the PostgresDi…

2022-11-29 Thread GitBox
MartijnVisser closed pull request #19053: [FLINK-26595][flink-connector-jdbc][postgreSQL]Improve the PostgresDi… URL: https://github.com/apache/flink/pull/19053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [flink] MartijnVisser commented on pull request #17933: [FLINK-24948][jdbc] Fix bug that special character in column names breaks JDBC statement parsing

2022-11-29 Thread GitBox
MartijnVisser commented on PR #17933: URL: https://github.com/apache/flink/pull/17933#issuecomment-1330781372 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #12983: [FLINK-18640][jdbc]Fix jdbc table name with schema error

2022-11-29 Thread GitBox
MartijnVisser closed pull request #12983: [FLINK-18640][jdbc]Fix jdbc table name with schema error URL: https://github.com/apache/flink/pull/12983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] MartijnVisser commented on pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails i

2022-11-29 Thread GitBox
MartijnVisser commented on PR #18822: URL: https://github.com/apache/flink/pull/18822#issuecomment-1330782780 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails in time

2022-11-29 Thread GitBox
MartijnVisser closed pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing fails in timer thread URL: https://github.com/apache/flink/pull/18822 -- This is an automated message from the Apache Git

[GitHub] [flink] MartijnVisser commented on pull request #18457: [FLINK-14902][code] Supports jdbc async lookup join

2022-11-29 Thread GitBox
MartijnVisser commented on PR #18457: URL: https://github.com/apache/flink/pull/18457#issuecomment-1330783087 We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc -- This is an automate

[GitHub] [flink] MartijnVisser closed pull request #18457: [FLINK-14902][code] Supports jdbc async lookup join

2022-11-29 Thread GitBox
MartijnVisser closed pull request #18457: [FLINK-14902][code] Supports jdbc async lookup join URL: https://github.com/apache/flink/pull/18457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Updated] (FLINK-28186) Trigger Operator Events on Configuration Changes

2022-11-29 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-28186: -- Fix Version/s: (was: kubernetes-operator-1.3.0) > Trigger Operator Events on Configuration

[jira] [Updated] (FLINK-28186) Trigger Operator Events on Configuration Changes

2022-11-29 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-28186: -- Component/s: Kubernetes Operator > Trigger Operator Events on Configuration Changes >

[jira] [Commented] (FLINK-28186) Trigger Operator Events on Configuration Changes

2022-11-29 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640765#comment-17640765 ] Matyas Orhidi commented on FLINK-28186: --- It's not urgent, removed the tag. > Trig

[GitHub] [flink] XComp commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-29 Thread GitBox
XComp commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1034871767 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -149,19 +155,

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034891596 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializerTest.java: ## @@ -29,7 +30,8 @@ * Tests for

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034891884 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializerTest.java: ## @@ -29,7 +30,8 @@ * Tests for

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034892520 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java: ## @@ -45,15 +46,16 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034892886 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java: ## @@ -45,15 +46,16 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034893121 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkBuilderTest.java: ## @@ -30,7 +31,8 @@ import static org.asser

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034893527 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkBuilderTest.java: ## @@ -30,7 +31,8 @@ import static org.asser

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034894549 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -108,7 +113,9 @@ import static org.assertj.

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034894913 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -108,7 +113,9 @@ import static org.assertj.

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034895784 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -143,12 +151,13 @@ public static void setupA

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034895369 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -123,18 +130,19 @@ public class KafkaSinkITC

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034896169 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -143,12 +151,13 @@ public static void setupA

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034896581 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -158,7 +167,7 @@ public void setUp() throws

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034897140 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaTransactionLogITCase.java: ## @@ -49,19 +51,21 @@ import static or

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034897483 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaTransactionLogITCase.java: ## @@ -49,19 +51,21 @@ import static or

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034897981 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -77,6 +77,7 @@ import static org.assertj.

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034898677 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterStateSerializerTest.java: ## @@ -29,7 +30,8 @@ * Tests for

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034899201 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/TransactionIdFactoryTest.java: ## @@ -17,14 +17,16 @@ package org.apa

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034899740 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/TransactionToAbortCheckerTest.java: ## @@ -17,19 +17,21 @@ package or

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034900090 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceLegacyITCase.java: ## @@ -37,7 +37,7 @@ public KafkaSourceL

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034900636 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceLegacyITCase.java: ## @@ -91,7 +91,7 @@ public void testMul

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034901013 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java: ## @@ -72,14 +73,14 @@ public cla

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034904171 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java: ## @@ -166,7 +167,8 @@ public voi

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034905020 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/initializer/OffsetsInitializerTest.java: ## @@ -25,24 +25,2

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034906144 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/initializer/OffsetsInitializerTest.java: ## @@ -145,10 +148

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034904521 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java: ## @@ -166,7 +167,8 @@ public voi

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034905365 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/initializer/OffsetsInitializerTest.java: ## @@ -25,24 +25,2

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034907187 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriberTest.java: ## @@ -45,17 +45,19 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034907770 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaRecordDeserializationSchemaTest.java: ## @@ -

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1034906776 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriberTest.java: ## @@ -45,17 +45,19 @@

[GitHub] [flink] liuml07 commented on pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources

2022-11-29 Thread GitBox
liuml07 commented on PR #21146: URL: https://github.com/apache/flink/pull/21146#issuecomment-1330834575 Sounds good. Should we remove the connector code from this Flink repo? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Reopened] (FLINK-29109) Checkpoint path conflict with stateless upgrade mode

2022-11-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reopened FLINK-29109: > Checkpoint path conflict with stateless upgrade mode > -

[GitHub] [flink] snuyanzin commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-29 Thread GitBox
snuyanzin commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1330839374 hi @ashmeet-kandhari thanks for conflicts resolution I left some comments (i didn't go through the whole changeset) however there are several types of things which would be nic

[GitHub] [flink] gyfora merged pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

2022-11-29 Thread GitBox
gyfora merged PR #21398: URL: https://github.com/apache/flink/pull/21398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-30214) The resource is not enough

2022-11-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30214. -- Fix Version/s: 1.17.0 Assignee: Rui Fan Resolution: Fixed merged to master ee4d5b8d657

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034922738 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed t

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034930175 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,586 @@ +/* + * Licensed t

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #2: [FLINK-28284] Add JdbcSink with new format

2022-11-29 Thread GitBox
boring-cyborg[bot] commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1330863470 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an a

[GitHub] [flink-connector-jdbc] eskabetxe opened a new pull request, #2: [FLINK-28284] Add JdbcSink with new format

2022-11-29 Thread GitBox
eskabetxe opened a new pull request, #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2 ## What is the purpose of the change Add a JdbcSink with new format (sink2) ## Brief change log - *JdbcSink* the new sink - *JdbcSinkWriter* the writer used by the n

[GitHub] [flink] eskabetxe commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

2022-11-29 Thread GitBox
eskabetxe commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1330864354 re-route the PR on https://github.com/apache/flink-connector-jdbc/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #2: [FLINK-28284] Add JdbcSink with new format

2022-11-29 Thread GitBox
eskabetxe commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1330865353 @wanglijie95 re-route the JDBC PR here.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] eskabetxe closed pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

2022-11-29 Thread GitBox
eskabetxe closed pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format URL: https://github.com/apache/flink/pull/20097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] gyfora commented on pull request #21374: [FLINK-30090] Support timespan for TimerGauges

2022-11-29 Thread GitBox
gyfora commented on PR #21374: URL: https://github.com/apache/flink/pull/21374#issuecomment-1330868527 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #3: [FLINK-15462][connectors] Add Trino dialect

2022-11-29 Thread GitBox
eskabetxe commented on PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1330878872 Im working on docs, but it would be cool some review as documentation depends on implementation. There are two test disabled on TrinoTableSinkITCase, as the Trino connecto

[GitHub] [flink] eskabetxe closed pull request #21223: [FLINK-15462][connectors] Add Trino dialect

2022-11-29 Thread GitBox
eskabetxe closed pull request #21223: [FLINK-15462][connectors] Add Trino dialect URL: https://github.com/apache/flink/pull/21223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

<    1   2   3   4   >