snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1034896169
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -143,12 +151,13 @@ public static void setupAdmin() {
admin = AdminClient.create(properties);
}
- @AfterClass
+ @AfterAll
public static void teardownAdmin() {
admin.close();
+ KAFKA_CONTAINER.close();
}
- @Before
+ @BeforeEach
public void setUp() throws ExecutionException, InterruptedException,
TimeoutException {
Review Comment:
```suggestion
void setUp() throws ExecutionException, InterruptedException,
TimeoutException {
```
could be package private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
