[jira] [Closed] (FLINK-30220) Secure user credentials in Flink SQL JDBC connector

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30220. -- Resolution: Duplicate [~qinjunjerry] I've closed it since the ticket you're linking to already

[GitHub] [flink] Zakelly commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-29 Thread GitBox
Zakelly commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1034413200 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java: ## @@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {

[jira] [Commented] (FLINK-30159) Add Transformer for ANOVATest

2022-11-29 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640450#comment-17640450 ] Jiang Xin commented on FLINK-30159: --- master: d6a5b42aae2a1a84789dfe0a35c7e97461b5d418

[jira] [Resolved] (FLINK-30159) Add Transformer for ANOVATest

2022-11-29 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Xin resolved FLINK-30159. --- Resolution: Fixed > Add Transformer for ANOVATest > - > >

[GitHub] [flink] lsyldliu commented on pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-11-29 Thread GitBox
lsyldliu commented on PR #21401: URL: https://github.com/apache/flink/pull/21401#issuecomment-1330242565 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-30070) Create savepoints without side effects

2022-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-30070: --- Description: Side effects are any external state - a state that is stored not in Flink, but

[jira] [Commented] (FLINK-29856) Triggering savepoint does not trigger operator notifyCheckpointComplete

2022-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640461#comment-17640461 ] Piotr Nowojski commented on FLINK-29856: Yes, this is the intended behavour. {qu

[jira] [Comment Edited] (FLINK-29856) Triggering savepoint does not trigger operator notifyCheckpointComplete

2022-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640461#comment-17640461 ] Piotr Nowojski edited comment on FLINK-29856 at 11/29/22 8:29 AM:

[jira] [Comment Edited] (FLINK-29856) Triggering savepoint does not trigger operator notifyCheckpointComplete

2022-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640461#comment-17640461 ] Piotr Nowojski edited comment on FLINK-29856 at 11/29/22 8:31 AM:

[jira] [Comment Edited] (FLINK-29856) Triggering savepoint does not trigger operator notifyCheckpointComplete

2022-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640461#comment-17640461 ] Piotr Nowojski edited comment on FLINK-29856 at 11/29/22 8:31 AM:

[jira] [Commented] (FLINK-30236) UpsertKafkaTableITCase failed due to timeout when creating a topic

2022-11-29 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640464#comment-17640464 ] Gabor Somogyi commented on FLINK-30236: --- Topic creation can fail because of the Ka

[GitHub] [flink] MartijnVisser commented on pull request #21279: Bump socket.io-parser from 4.0.4 to 4.0.5 in /flink-runtime-web/web-dashboard

2022-11-29 Thread GitBox
MartijnVisser commented on PR #21279: URL: https://github.com/apache/flink/pull/21279#issuecomment-1330269796 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-29634) Support periodic checkpoint triggering

2022-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640466#comment-17640466 ] Piotr Nowojski commented on FLINK-29634: I'm not sure if Flink should try to sat

[jira] [Commented] (FLINK-27916) HybridSourceReaderTest.testReader failed with AssertionError

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640467#comment-17640467 ] Matthias Pohl commented on FLINK-27916: --- [~thomasWeise]/[~binh] may you have a loo

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640471#comment-17640471 ] Matthias Pohl commented on FLINK-18356: --- [~godfrey] Could you have a look at the O

[jira] [Commented] (FLINK-29461) ProcessDataStreamStreamingTests.test_process_function unstable

2022-11-29 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640473#comment-17640473 ] Xingbo Huang commented on FLINK-29461: -- [~mapohl] Sorry for the late reply, I will

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #181: [FLINK-30124] Support collecting model data with arrays and maps

2022-11-29 Thread GitBox
lindong28 commented on code in PR #181: URL: https://github.com/apache/flink-ml/pull/181#discussion_r1034447969 ## flink-ml-python/pyflink/ml/lib/feature/tests/test_kbinsdiscretizer.py: ## @@ -163,7 +166,15 @@ def test_get_model_data(self): expected_field_names = ['binE

[GitHub] [flink] zentol merged pull request #21409: [FLINK-30228][test] Use thread-safe list

2022-11-29 Thread GitBox
zentol merged PR #21409: URL: https://github.com/apache/flink/pull/21409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-30228) RateLimitedSourceReaderITCase.testRateLimitingParallelExecution failed

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30228: - Issue Type: Technical Debt (was: Bug) > RateLimitedSourceReaderITCase.testRateLimitingP

[jira] [Closed] (FLINK-30228) RateLimitedSourceReaderITCase.testRateLimitingParallelExecution failed

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30228. Fix Version/s: 1.17 Resolution: Fixed master: 3130b9a907afb420f95a64a3cada19156fedc

[GitHub] [flink] zentol opened a new pull request, #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
zentol opened a new pull request, #21416: URL: https://github.com/apache/flink/pull/21416 Capturing the checkpointId for a generated record in a subsequent map function is impossible since the notifyCheckpointComplete notification may arrive at any time (or not at all). Instead just assert

[jira] [Updated] (FLINK-30202) DataGeneratorSourceITCase.testGatedRateLimiter failed

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30202: --- Labels: pull-request-available test-stability (was: test-stability) > DataGeneratorSourceIT

[jira] [Updated] (FLINK-30202) DataGeneratorSourceITCase.testGatedRateLimiter failed

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30202: - Issue Type: Technical Debt (was: Bug) > DataGeneratorSourceITCase.testGatedRateLimiter

[GitHub] [flink-table-store] JingsongLi commented on pull request #344: [FLINK-29823] Support to get schema of table snapshot

2022-11-29 Thread GitBox
JingsongLi commented on PR #344: URL: https://github.com/apache/flink-table-store/pull/344#issuecomment-1330296296 > Hi @JingsongLi Sorry for replying late. I think `MyTable$schemas` is so good that we cannot to check the schema change history from Table Store currently. I think we can cre

[GitHub] [flink] flinkbot commented on pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
flinkbot commented on PR #21416: URL: https://github.com/apache/flink/pull/21416#issuecomment-1330298212 ## CI report: * b372c77de18aef2ceea6b00ad64a3278fd91a8d1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zentol opened a new pull request, #21417: [FLINK-29862] Upgrade to flink-shaded 16.1

2022-11-29 Thread GitBox
zentol opened a new pull request, #21417: URL: https://github.com/apache/flink/pull/21417 Second attempt. Identical changes to #21227. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #21417: [FLINK-29862] Upgrade to flink-shaded 16.1

2022-11-29 Thread GitBox
flinkbot commented on PR #21417: URL: https://github.com/apache/flink/pull/21417#issuecomment-1330311573 ## CI report: * 565e4934f4ca7357c75a6a10ead225fe900ba996 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-30237) Only bundle a single Zookeeper version

2022-11-29 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30237: Summary: Only bundle a single Zookeeper version Key: FLINK-30237 URL: https://issues.apache.org/jira/browse/FLINK-30237 Project: Flink Issue Type: Te

[GitHub] [flink-ml] lindong28 commented on pull request #181: [FLINK-30124] Support collecting model data with arrays and maps

2022-11-29 Thread GitBox
lindong28 commented on PR #181: URL: https://github.com/apache/flink-ml/pull/181#issuecomment-1330320243 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] lindong28 merged pull request #181: [FLINK-30124] Support collecting model data with arrays and maps

2022-11-29 Thread GitBox
lindong28 merged PR #181: URL: https://github.com/apache/flink-ml/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] zentol opened a new pull request, #21418: [FLINK-30237][coordination] Only bundle single ZK client

2022-11-29 Thread GitBox
zentol opened a new pull request, #21418: URL: https://github.com/apache/flink/pull/21418 Reverts FLINK-13417 and FLINK-16350 since it's no longer required to bundle 2 different clients. We'll upgrade to 3.7 in FLINK-29420. -- This is an automated message from the Apache Git Servic

[jira] [Updated] (FLINK-29420) Upgrade Zookeeper to 3.7

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29420: - Summary: Upgrade Zookeeper to 3.7 (was: Upgrade Zookeeper to 3.7 / 3.8) > Upgrade Zooke

[jira] [Updated] (FLINK-30237) Only bundle a single Zookeeper version

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30237: --- Labels: pull-request-available (was: ) > Only bundle a single Zookeeper version > -

[jira] [Updated] (FLINK-30124) GenericType is not supported in PyFlink currently

2022-11-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30124: - Fix Version/s: ml-2.2.0 > GenericType is not supported in PyFlink currently > --

[jira] [Resolved] (FLINK-30124) GenericType is not supported in PyFlink currently

2022-11-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-30124. -- Resolution: Fixed > GenericType is not supported in PyFlink currently > --

[GitHub] [flink] flinkbot commented on pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

2022-11-29 Thread GitBox
flinkbot commented on PR #21418: URL: https://github.com/apache/flink/pull/21418#issuecomment-1330324897 ## CI report: * 914511a382988333dfd9d0dfcc28158d197660ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-aws] dannycranmer opened a new pull request, #32: Flink 29907[FLINK-29907][Connectors/AWS] Externalize KDS/KDF and AWS base from Flink repo

2022-11-29 Thread GitBox
dannycranmer opened a new pull request, #32: URL: https://github.com/apache/flink-connector-aws/pull/32 TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (FLINK-29907) Externalize AWS connectors from Flink core

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29907: --- Labels: pull-request-available (was: ) > Externalize AWS connectors from Flink core > -

[jira] [Commented] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-11-29 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640506#comment-17640506 ] Mason Chen commented on FLINK-30052: [~martijnvisser] I started this task over the w

[GitHub] [flink] zentol commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-11-29 Thread GitBox
zentol commented on code in PR #21128: URL: https://github.com/apache/flink/pull/21128#discussion_r1034500893 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -608,10 +611,13 @@ public boolean accept(File dir, String name) { public static boo

[jira] [Commented] (FLINK-30220) Secure user credentials in Flink SQL JDBC connector

2022-11-29 Thread Jun Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640511#comment-17640511 ] Jun Qin commented on FLINK-30220: - The same is needed for JDBC connector: CREATE TABLE M

[jira] [Commented] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640571#comment-17640571 ] Martijn Visser commented on FLINK-30052: [~mason6345] The best course of actions

[jira] [Commented] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640573#comment-17640573 ] Martijn Visser commented on FLINK-30052: [~chesnay] WDYT on the issues that Maso

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-11-29 Thread GitBox
MartijnVisser commented on code in PR #21128: URL: https://github.com/apache/flink/pull/21128#discussion_r1034520479 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -608,10 +611,13 @@ public boolean accept(File dir, String name) { public sta

[GitHub] [flink-connector-jdbc] zentol commented on a diff in pull request #1: [FLINK-30060][Connector/JDBC] Move existing JDBC connector code from Flink repo to dedicated JDBC repo

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-jdbc/pull/1#discussion_r1034507671 ## .idea/vcs.xml: ## @@ -0,0 +1,6 @@ + + + Review Comment: There's a better vcs.xml example in the ES repo. ## pom.xml: ## @@ -0,0 +1,42

[GitHub] [flink-connector-pulsar] zentol commented on a diff in pull request #1: [FLINK-30054][Connector/Pulsar] Move existing Pulsar connector code

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-pulsar/pull/1#discussion_r1034527661 ## pom.xml: ## @@ -0,0 +1,417 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"; +xmlns="http://maven.apache.org/

[GitHub] [flink-table-store] zjureel commented on pull request #347: [FLINK-27847] Support rename/drop column in SchemaManager

2022-11-29 Thread GitBox
zjureel commented on PR #347: URL: https://github.com/apache/flink-table-store/pull/347#issuecomment-1330416747 Hi @JingsongLi @tsreaper I have update the `SchemaManager` and add more test cases in `SchemaEvolutionTest` and `SparkReadITCase` for schema evolution, please help to review them

[jira] [Commented] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640592#comment-17640592 ] Chesnay Schepler commented on FLINK-30052: -- Just replace the {{flink-end-to-end

[jira] [Comment Edited] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640592#comment-17640592 ] Chesnay Schepler edited comment on FLINK-30052 at 11/29/22 10:34 AM: -

[jira] [Commented] (FLINK-30052) Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640593#comment-17640593 ] Chesnay Schepler commented on FLINK-30052: -- Other tests that rely on flink-end-

[GitHub] [flink] huwh commented on pull request #21233: [FLINK-29870] [ResourceManager]Split ResourceActions to ResourceAllocator and ResourceEventListener.

2022-11-29 Thread GitBox
huwh commented on PR #21233: URL: https://github.com/apache/flink/pull/21233#issuecomment-1330443060 > Well, I meant removing `notifyAllocationFailure` in a separate hotfix commit in this PR, to keep the commit history clean. Never mind. I Have merged the PRfor [FLINK-30084](https://issues.

[GitHub] [flink-table-store] zjureel commented on pull request #402: [FLINK-29988] Using lower case fields in hive catalog

2022-11-29 Thread GitBox
zjureel commented on PR #402: URL: https://github.com/apache/flink-table-store/pull/402#issuecomment-1330449444 After discussed with @JingsongLi , I'll create another issue to throw exception when user use `HiveCatalog` and create table with upper case table and column name. We will fix th

[GitHub] [flink-table-store] zjureel closed pull request #402: [FLINK-29988] Using lower case fields in hive catalog

2022-11-29 Thread GitBox
zjureel closed pull request #402: [FLINK-29988] Using lower case fields in hive catalog URL: https://github.com/apache/flink-table-store/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FLINK-30238) Unified Sink committer does not clean up state on final savepoint

2022-11-29 Thread Fabian Paul (Jira)
Fabian Paul created FLINK-30238: --- Summary: Unified Sink committer does not clean up state on final savepoint Key: FLINK-30238 URL: https://issues.apache.org/jira/browse/FLINK-30238 Project: Flink

[GitHub] [flink-connector-jdbc] zentol commented on a diff in pull request #1: [FLINK-30060][Connector/JDBC] Move existing JDBC connector code from Flink repo to dedicated JDBC repo

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-jdbc/pull/1#discussion_r1034606733 ## pom.xml: ## @@ -0,0 +1,395 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"; +xmlns="http://maven.apache.org/PO

[jira] [Comment Edited] (FLINK-15656) Support user-specified pod templates

2022-11-29 Thread lekelei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640626#comment-17640626 ] lekelei edited comment on FLINK-15656 at 11/29/22 11:18 AM:

[jira] [Commented] (FLINK-15656) Support user-specified pod templates

2022-11-29 Thread lekelei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640626#comment-17640626 ] lekelei commented on FLINK-15656: - [~wangyang0918]  Hello, I am using the function of p

[jira] [Comment Edited] (FLINK-15656) Support user-specified pod templates

2022-11-29 Thread lekelei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640626#comment-17640626 ] lekelei edited comment on FLINK-15656 at 11/29/22 11:21 AM:

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #456: FLINK-30222: Operator should handle 'kubernetes' as a valid setting for the 'high-availability' config key

2022-11-29 Thread GitBox
mbalassi commented on PR #456: URL: https://github.com/apache/flink-kubernetes-operator/pull/456#issuecomment-1330486354 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #456: FLINK-30222: Operator should handle 'kubernetes' as a valid setting for the 'high-availability' config key

2022-11-29 Thread GitBox
mbalassi merged PR #456: URL: https://github.com/apache/flink-kubernetes-operator/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Closed] (FLINK-30222) Suspended a job in last-state mode bug

2022-11-29 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30222. -- Resolution: Fixed [{{458022d}}|https://github.com/apache/flink-kubernetes-operator/commit/4580

[GitHub] [flink] XComp merged pull request #20755: [FLINK-29092][tests] Use base path bucket assigner

2022-11-29 Thread GitBox
XComp merged PR #20755: URL: https://github.com/apache/flink/pull/20755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp merged pull request #21413: [BP-1.16][FLINK-29092][Connectors/Test] Use one bucket assigner

2022-11-29 Thread GitBox
XComp merged PR #21413: URL: https://github.com/apache/flink/pull/21413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp merged pull request #21414: [BP-1.15][FLINK-29092][Connectors/Test] Use one bucket assigner

2022-11-29 Thread GitBox
XComp merged PR #21414: URL: https://github.com/apache/flink/pull/21414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Resolved] (FLINK-29092) HadoopPathBasedPartFileWriterTest.testWriteFile failed with AssertionError

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-29092. --- Fix Version/s: 1.16.1 1.15.4 Resolution: Fixed master: ed46cb2fd64

[GitHub] [flink] reswqa opened a new pull request, #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-11-29 Thread GitBox
reswqa opened a new pull request, #21419: URL: https://github.com/apache/flink/pull/21419 ## What is the purpose of the change *Hybrid full result partition is re-consumable now, and we have enabled `VertexwiseSchedulingStrategy` to support the scheduling of hybrid type edges in [FLI

[GitHub] [flink-connector-opensearch] zentol commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034673047 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed

[jira] [Updated] (FLINK-30233) Hybrid full result partition should also work with speculative execution

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30233: --- Labels: pull-request-available (was: ) > Hybrid full result partition should also work with

[GitHub] [flink] flinkbot commented on pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-11-29 Thread GitBox
flinkbot commented on PR #21419: URL: https://github.com/apache/flink/pull/21419#issuecomment-1330549923 ## CI report: * 43f4095e23f3396da77a7b287d18424fd971abfe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp commented on a diff in pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

2022-11-29 Thread GitBox
XComp commented on code in PR #21418: URL: https://github.com/apache/flink/pull/21418#discussion_r1034696632 ## flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh: ## @@ -113,7 +113,6 @@ function run_ha_test() { # jm killing loop set_config_key "

[jira] [Updated] (FLINK-29769) Further limit the explosion range of failover in hybrid shuffle mode

2022-11-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29769: --- Description: Under the current failover strategy, if a region changes to the failed state, all its d

[jira] [Assigned] (FLINK-29769) Further limit the explosion range of failover in hybrid shuffle mode

2022-11-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-29769: -- Assignee: Weijie Guo > Further limit the explosion range of failover in hybrid shuffle mode >

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-11-29 Thread GitBox
gaborgsomogyi commented on code in PR #21128: URL: https://github.com/apache/flink/pull/21128#discussion_r1034716206 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -608,10 +611,13 @@ public boolean accept(File dir, String name) { public sta

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #453: [FLINK-30216] Improve code quality by standardising tab/spaces in pom…

2022-11-29 Thread GitBox
mbalassi commented on code in PR #453: URL: https://github.com/apache/flink-kubernetes-operator/pull/453#discussion_r1034715813 ## pom.xml: ## @@ -349,6 +349,36 @@ under the License. + + +org.code

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #448: Show me every error

2022-11-29 Thread GitBox
mbalassi commented on PR #448: URL: https://github.com/apache/flink-kubernetes-operator/pull/448#issuecomment-1330612254 @pvary is this still relevant or can this be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-11-29 Thread GitBox
gaborgsomogyi commented on code in PR #21128: URL: https://github.com/apache/flink/pull/21128#discussion_r1034716206 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -608,10 +611,13 @@ public boolean accept(File dir, String name) { public sta

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #455: FLINK-30199: Add a script to run Kubernetes Operator e2e tests manually

2022-11-29 Thread GitBox
mbalassi commented on PR #455: URL: https://github.com/apache/flink-kubernetes-operator/pull/455#issuecomment-1330618530 cc @wangyang0918 for your information @pvary has reworked the test suite to block tests together on the same container runs, we hope this effectively will give us more C

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-11-29 Thread GitBox
gaborgsomogyi commented on code in PR #21128: URL: https://github.com/apache/flink/pull/21128#discussion_r1034723930 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -608,10 +611,13 @@ public boolean accept(File dir, String name) { public sta

[GitHub] [flink] Myasuka commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-29 Thread GitBox
Myasuka commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1034731440 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java: ## @@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034734061 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed t

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-29 Thread GitBox
gyfora commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330633259 @yangjf2019 seems like the 1.13 e2e tests started to fail on a noclassdef found error. We should probably use the respective example jars there from the 1.13 version not t

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034741956 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed t

[GitHub] [flink] zentol commented on a diff in pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

2022-11-29 Thread GitBox
zentol commented on code in PR #21418: URL: https://github.com/apache/flink/pull/21418#discussion_r1034742561 ## flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh: ## @@ -113,7 +113,6 @@ function run_ha_test() { # jm killing loop set_config_key

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034755652 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-29815) image apache/flink:1.16.0-scala_2.12 does not exist

2022-11-29 Thread Harkin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640709#comment-17640709 ] Harkin commented on FLINK-29815: Good job! The image now exists! > image apache/flink:1

[jira] [Commented] (FLINK-30116) Don't Show Env Vars in Web UI

2022-11-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640713#comment-17640713 ] Chesnay Schepler commented on FLINK-30116: -- [~ConradJam] Have you made any prog

[GitHub] [flink] zentol commented on pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
zentol commented on PR #21416: URL: https://github.com/apache/flink/pull/21416#issuecomment-1330669367 > You're saying that we would introduce a test instability here if the RateLimitedStrategy wouldn't perform as expected? Yes. At least that was the idea. Now I'm not so sure anymore

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-29 Thread GitBox
yangjf2019 commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330670947 Okay,I revert it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] XComp commented on pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
XComp commented on PR #21416: URL: https://github.com/apache/flink/pull/21416#issuecomment-1330673297 yeah, that's something I was wondering as well. But the behavior of the `RateLimitedStrategy` doesn't necessarily need to be tested here, I guess. It feels like we're missing a `RateLimited

[GitHub] [flink-kubernetes-operator] rgsriram commented on a diff in pull request #438: [FLINK-29974] Not allowing the cancelling the which are already in the completed state.

2022-11-29 Thread GitBox
rgsriram commented on code in PR #438: URL: https://github.com/apache/flink-kubernetes-operator/pull/438#discussion_r1034773811 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -362,11 +362,22 @@ public voi

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #455: FLINK-30199: Add a script to run Kubernetes Operator e2e tests manually

2022-11-29 Thread GitBox
mbalassi commented on code in PR #455: URL: https://github.com/apache/flink-kubernetes-operator/pull/455#discussion_r1034729637 ## e2e-tests/utils.sh: ## @@ -265,3 +270,75 @@ function create_namespace() { fi; } + +function install_cert_manager() { + if [[ -n ${DEBUG} ]];

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-29 Thread GitBox
gyfora commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330682062 @yangjf2019 do you think we could modify the logic so that we pick the jars based on Flink version, similar to how change other parts of the spec? -- This is an automate

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #447: DO_NOT_MERGE [FLINK-30151] Remove AuditUtils from operator error

2022-11-29 Thread GitBox
mbalassi commented on PR #447: URL: https://github.com/apache/flink-kubernetes-operator/pull/447#issuecomment-1330682449 @gaborgsomogyi is this still relevant or can we close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #453: [FLINK-30216] Improve code quality by standardising tab/spaces in pom…

2022-11-29 Thread GitBox
darenwkt commented on code in PR #453: URL: https://github.com/apache/flink-kubernetes-operator/pull/453#discussion_r1034783258 ## pom.xml: ## @@ -349,6 +349,36 @@ under the License. + + +org.code

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #447: DO_NOT_MERGE [FLINK-30151] Remove AuditUtils from operator error

2022-11-29 Thread GitBox
gaborgsomogyi commented on PR #447: URL: https://github.com/apache/flink-kubernetes-operator/pull/447#issuecomment-1330690877 At some point I need to come back and execute all tests to find out the reason. Now we've added several bugfixes so I need to rebase. -- This is an automated mess

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-29 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1034741956 ## flink-connector-opensearch/src/test/java/org/apache/flink/streaming/connectors/opensearch/OpensearchSinkTest.java: ## @@ -0,0 +1,562 @@ +/* + * Licensed t

[GitHub] [flink] zentol commented on pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-11-29 Thread GitBox
zentol commented on PR #21416: URL: https://github.com/apache/flink/pull/21416#issuecomment-1330691876 There is a `RateLimitedSourceReaderITCase`. I'll try finding another way to test this; my current thinking goes towards using a FlatMapFunction that stops emitting values after the f

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #453: [FLINK-30216] Improve code quality by standardising tab/spaces in pom…

2022-11-29 Thread GitBox
mbalassi commented on code in PR #453: URL: https://github.com/apache/flink-kubernetes-operator/pull/453#discussion_r1034789046 ## pom.xml: ## @@ -349,6 +349,36 @@ under the License. + + +org.code

[GitHub] [flink] XComp commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-29 Thread GitBox
XComp commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1034405416 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -149,19 +155,

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-29 Thread GitBox
yangjf2019 commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330698087 Yes, I think it can, in that case, how should we adjust it please? -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   3   4   >