gaborgsomogyi commented on code in PR #21128:
URL: https://github.com/apache/flink/pull/21128#discussion_r1034723930
##########
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java:
##########
@@ -608,10 +611,13 @@ public boolean accept(File dir, String name) {
public static boolean verifyStringsInNamedLogFiles(
final String[] mustHave, final ApplicationId applicationId, final
String fileName) {
final List<String> mustHaveList = Arrays.asList(mustHave);
- final File cwd = new File("target",
YARN_CONFIGURATION.get(TEST_CLUSTER_NAME_KEY));
+ final File cwd =
Review Comment:
I think if we want to have control here then we must just forget relative
paths. Blindly all the logic which is depending on `TEST_CLUSTER_NAME_KEY` must
be just kicked out with hardcoded TMP dir providing full path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
