[GitHub] [flink] tillrohrmann closed pull request #17027: [FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann closed pull request #17027: URL: https://github.com/apache/flink/pull/17027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] tillrohrmann commented on pull request #17028: [BP-1.13][FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17028: URL: https://github.com/apache/flink/pull/17028#issuecomment-908226922 The build failure seems to be related to the updated NoticeFileChecker. This should be fixed now. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] twalthr commented on a change in pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
twalthr commented on a change in pull request #17048: URL: https://github.com/apache/flink/pull/17048#discussion_r698371932 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java ## @@ -90,13 +90,18 @@ publ

[GitHub] [flink] tillrohrmann merged pull request #17028: [BP-1.13][FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann merged pull request #17028: URL: https://github.com/apache/flink/pull/17028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] tillrohrmann commented on pull request #17029: [BP-1.12][FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17029: URL: https://github.com/apache/flink/pull/17029#issuecomment-908231353 The test failure seems to be unrelated. Merging this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [flink] tillrohrmann merged pull request #17029: [BP-1.12][FLINK-23954][tests] Fix e2e test test_queryable_state_restart_tm.sh

2021-08-30 Thread GitBox
tillrohrmann merged pull request #17029: URL: https://github.com/apache/flink/pull/17029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Closed] (FLINK-23954) Queryable state (rocksdb) with TM restart end-to-end test fails on azure

2021-08-30 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-23954. - Resolution: Fixed Fixed via 1.15.0: 6a6dfef228336c560671e6ce8af946e070b8a1d2 (reverted 6a7b5e8

[GitHub] [flink] tillrohrmann commented on pull request #17033: [FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17033: URL: https://github.com/apache/flink/pull/17033#issuecomment-908233948 Thanks for the review @zentol. Merging this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] flinkbot edited a comment on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpse…

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-904741081 ## CI report: * ed07cb76926d2747ac25953e5f5e74c48e64ef25 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 0a6ed86ec26cf3fd8a85ccb00d5b504aa31c4d9b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17037: URL: https://github.com/apache/flink/pull/17037#issuecomment-907731112 ## CI report: * 71ddbbb89bf81896a5acca9466e50d0a6e544758 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tillrohrmann closed pull request #17033: [FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann closed pull request #17033: URL: https://github.com/apache/flink/pull/17033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] flinkbot edited a comment on pull request #17046: [FLINK-24049][python] Handle properly for field types need conversion in TupleTypeInfo

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17046: URL: https://github.com/apache/flink/pull/17046#issuecomment-908096451 ## CI report: * 0ce3f1e021ffd0a8278412dda43198f8c1eb0b8c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tillrohrmann commented on pull request #17032: [BP-1.14][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17032: URL: https://github.com/apache/flink/pull/17032#issuecomment-908235712 Merging this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink] tillrohrmann merged pull request #17032: [BP-1.14][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann merged pull request #17032: URL: https://github.com/apache/flink/pull/17032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] tillrohrmann commented on pull request #17034: [BP-1.13][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17034: URL: https://github.com/apache/flink/pull/17034#issuecomment-908237697 Thanks for the review @zentol. Sure, I'll rebase this PR. Merging this PR then. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink-training] NicoK commented on a change in pull request #31: [FLINK-23653] exercise and test rework

2021-08-30 Thread GitBox
NicoK commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r698359197 ## File path: rides-and-fares/src/main/java/org/apache/flink/training/exercises/ridesandfares/RidesAndFaresExercise.java ## @@ -18,68 +18,119 @@ pack

[GitHub] [flink] tillrohrmann merged pull request #17034: [BP-1.13][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann merged pull request #17034: URL: https://github.com/apache/flink/pull/17034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] tillrohrmann commented on pull request #17035: [BP-1.12][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann commented on pull request #17035: URL: https://github.com/apache/flink/pull/17035#issuecomment-908239381 Thanks for the review @zentol. Merging this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] tillrohrmann merged pull request #17035: [BP-1.12][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

2021-08-30 Thread GitBox
tillrohrmann merged pull request #17035: URL: https://github.com/apache/flink/pull/17035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Closed] (FLINK-23947) DefaultDispatcherRunner does not log when the Dispatcher gains and loses leadership

2021-08-30 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-23947. - Resolution: Fixed Fixed via 1.15.0: 7f69331294ab2ab73f77b40a4320cdda53246afe 1.14.0: dfa1613421

[jira] [Commented] (FLINK-23850) Test Kafka table connector with new runtime provider

2021-08-30 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406678#comment-17406678 ] Matthias commented on FLINK-23850: -- [~renqs] I'm gonna do a manual test accessing a Kaf

[GitHub] [flink] zhwangke commented on pull request #17025: [FLINK-24029][docs] Update doc example sql field in release-1.13.2 to dept_id

2021-08-30 Thread GitBox
zhwangke commented on pull request #17025: URL: https://github.com/apache/flink/pull/17025#issuecomment-908247694 @Myasuka Please help to review this PR about correcting typos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698393164 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateContext.java ## @@ -31,9 +31,17 @@ public in

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698393854 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java ## @@ -91,12 +106,14 @@ public v

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698395936 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/AbstractCommitterHandler.java ## @@ -19,18 +19,58 @@

[jira] [Updated] (FLINK-24031) I am trying to deploy Flink in kubernetes but when I launch the taskManager in other container I get a Exception

2021-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julio Pérez updated FLINK-24031: Attachment: taskmanager.yml jobmanager.yml flink-map.yml > I am tr

[GitHub] [flink] flinkbot edited a comment on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpse…

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-904741081 ## CI report: * ed07cb76926d2747ac25953e5f5e74c48e64ef25 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-907158087 ## CI report: * f954017eb4d81acc1283bae464d7247bda38d904 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698402630 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitRetryer.java ## @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] [flink] ruanhang1993 opened a new pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-30 Thread GitBox
ruanhang1993 opened a new pull request #17049: URL: https://github.com/apache/flink/pull/17049 ## What is the purpose of the change This pull request resolves the error in the connector testing framework, when comparing the result with data in different splits. When achieving your o

[jira] [Updated] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23971: --- Labels: pull-request-available test-stability (was: test-stability) > PulsarSourceITCase.te

[GitHub] [flink] flinkbot commented on pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-30 Thread GitBox
flinkbot commented on pull request #17049: URL: https://github.com/apache/flink/pull/17049#issuecomment-908263350 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Commented] (FLINK-24031) I am trying to deploy Flink in kubernetes but when I launch the taskManager in other container I get a Exception

2021-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406686#comment-17406686 ] Julio Pérez commented on FLINK-24031: - Thank's for the reply [~trohrmann], Yeah I s

[jira] [Comment Edited] (FLINK-24031) I am trying to deploy Flink in kubernetes but when I launch the taskManager in other container I get a Exception

2021-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406686#comment-17406686 ] Julio Pérez edited comment on FLINK-24031 at 8/30/21, 11:31 AM: --

[GitHub] [flink] RocMarshal commented on a change in pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-30 Thread GitBox
RocMarshal commented on a change in pull request #16852: URL: https://github.com/apache/flink/pull/16852#discussion_r698410805 ## File path: docs/content.zh/docs/dev/datastream/overview.md ## @@ -797,12 +677,14 @@ val myOutput: Iterator[(String, Int)] = DataStreamUtils.collect

[GitHub] [flink] RocMarshal commented on a change in pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-30 Thread GitBox
RocMarshal commented on a change in pull request #16852: URL: https://github.com/apache/flink/pull/16852#discussion_r698413142 ## File path: docs/content.zh/docs/dev/datastream/overview.md ## @@ -209,46 +159,30 @@ print() {{< /tab >}} {{< /tabs >}} -Once you specified the c

[GitHub] [flink] flinkbot edited a comment on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-906324142 ## CI report: * c096ede2ac4bd991486ec9fcff878f96b02f2f41 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 0a6ed86ec26cf3fd8a85ccb00d5b504aa31c4d9b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17011: URL: https://github.com/apache/flink/pull/17011#issuecomment-907015222 ## CI report: * 211af17558902443958144ba9f202b75c719982e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-30 Thread GitBox
flinkbot commented on pull request #17049: URL: https://github.com/apache/flink/pull/17049#issuecomment-908270735 ## CI report: * 2469730f9db1e2d688dd971921a7ab68c34d4aee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] fapaul opened a new pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-30 Thread GitBox
fapaul opened a new pull request #17050: URL: https://github.com/apache/flink/pull/17050 …termarks after source operator finishes ## What is the purpose of the change This PR changes the semantic of FileReadingWatermarkITCase to wait for an expected number of

[jira] [Updated] (FLINK-23351) FileReadingWatermarkITCase.testWatermarkEmissionWithChaining fails due to "too few watermarks emitted" on azure

2021-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23351: --- Labels: pull-request-available test-stability (was: test-stability) > FileReadingWatermarkI

[GitHub] [flink] hailuand commented on pull request #13396: [FLINK-19248] add missing lastJobExecutionResult assignment after job finished in ContexEnvironment

2021-08-30 Thread GitBox
hailuand commented on pull request #13396: URL: https://github.com/apache/flink/pull/13396#issuecomment-908272767 Hi @aljoscha I can help with this here if all that’s missing is a test! Do you know where I can find examples of creating a `ContextEnvironment`? I was having trouble finding o

[jira] [Created] (FLINK-24053) stop with savepoint timeout

2021-08-30 Thread Jira
刘方奇 created FLINK-24053: --- Summary: stop with savepoint timeout Key: FLINK-24053 URL: https://issues.apache.org/jira/browse/FLINK-24053 Project: Flink Issue Type: Bug Components: Runtime / Che

[GitHub] [flink] flinkbot commented on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-30 Thread GitBox
flinkbot commented on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908273710 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-23875) ReducingUpsertSink can loose records during failover

2021-08-30 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-23875: Affects Version/s: 1.15.0 > ReducingUpsertSink can loose records during failover > --

[jira] [Updated] (FLINK-24053) stop with savepoint timeout

2021-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 刘方奇 updated FLINK-24053: Description: Hello, when we use the "stop with savepoint" feature, we always meet a bug. We will always cost 5 mi

[GitHub] [flink] pnowojski commented on a change in pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-30 Thread GitBox
pnowojski commented on a change in pull request #17037: URL: https://github.com/apache/flink/pull/17037#discussion_r698424430 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java ## @@ -216,9 +220,10 @@ // Lock is o

[jira] [Commented] (FLINK-24053) stop with savepoint timeout

2021-08-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406693#comment-17406693 ] 刘方奇 commented on FLINK-24053: - [~lzljs3620320] , please help review this comment > stop wit

[jira] [Closed] (FLINK-24053) stop with savepoint timeout

2021-08-30 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-24053. Resolution: Not A Problem This is not a bug. When a stop-with-savepoint operation is trig

[GitHub] [flink] wuchong commented on a change in pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-30 Thread GitBox
wuchong commented on a change in pull request #16852: URL: https://github.com/apache/flink/pull/16852#discussion_r698426348 ## File path: docs/content.zh/docs/dev/datastream/overview.md ## @@ -209,46 +159,30 @@ print() {{< /tab >}} {{< /tabs >}} -Once you specified the comp

[GitHub] [flink] godfreyhe closed pull request #16979: [FLINK-23962][table-planner] Fix updateKind trait propagating problem…

2021-08-30 Thread GitBox
godfreyhe closed pull request #16979: URL: https://github.com/apache/flink/pull/16979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [flink] RocMarshal commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
RocMarshal commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-908285480 @wuchong OK. I changed it based on your comments. Thank you so much for your guidances. PTAL. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [flink] gaoyunhaii commented on pull request #17023: [FLINK-24043][runtime] Reuse the code of 'check savepoint preconditions'.

2021-08-30 Thread GitBox
gaoyunhaii commented on pull request #17023: URL: https://github.com/apache/flink/pull/17023#issuecomment-908285880 Ok,I'll have a look~ Very thanks for opening the PR~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] zentol opened a new pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-30 Thread GitBox
zentol opened a new pull request #17051: URL: https://github.com/apache/flink/pull/17051 With this PR the Scala-reliant FieldAccessors in flink-streaming-java are moved to flink-streaming-scala and loaded via reflection. This implies that users wanting to use Scala types in their jobs need

[jira] [Updated] (FLINK-23978) FieldAccessor has direct scala dependency

2021-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23978: --- Labels: pull-request-available (was: ) > FieldAccessor has direct scala dependency > --

[GitHub] [flink] hapihu commented on a change in pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-30 Thread GitBox
hapihu commented on a change in pull request #16852: URL: https://github.com/apache/flink/pull/16852#discussion_r698432693 ## File path: docs/content.zh/docs/dev/datastream/overview.md ## @@ -797,12 +677,14 @@ val myOutput: Iterator[(String, Int)] = DataStreamUtils.collect(myR

[GitHub] [flink] flinkbot edited a comment on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-893364145 ## CI report: * 1de6e0b83ee64c22c861a9d8e639483aaaba9e7f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-30 Thread GitBox
flinkbot commented on pull request #17051: URL: https://github.com/apache/flink/pull/17051#issuecomment-908293745 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Created] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-30 Thread Timo Walther (Jira)
Timo Walther created FLINK-24054: Summary: Let SinkUpsertMaterializer emit +U instead of only +I Key: FLINK-24054 URL: https://issues.apache.org/jira/browse/FLINK-24054 Project: Flink Issue T

[jira] [Updated] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-30 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-24054: - Priority: Blocker (was: Major) > Let SinkUpsertMaterializer emit +U instead of only +I > --

[jira] [Updated] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-30 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-24054: - Fix Version/s: 1.14.0 > Let SinkUpsertMaterializer emit +U instead of only +I >

[GitHub] [flink] flinkbot edited a comment on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpse…

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-904741081 ## CI report: * 758c42cbc3442c3b95389dc65ef4bd67e2ff3344 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 0a6ed86ec26cf3fd8a85ccb00d5b504aa31c4d9b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17049: URL: https://github.com/apache/flink/pull/17049#issuecomment-908270735 ## CI report: * 2469730f9db1e2d688dd971921a7ab68c34d4aee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17045: [FLINK-23924][python][examples] Add PyFlink examples

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17045: URL: https://github.com/apache/flink/pull/17045#issuecomment-908007478 ## CI report: * edd075f9e5a4dd29de26db54bafedace3c92b9ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wuchong commented on a change in pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-30 Thread GitBox
wuchong commented on a change in pull request #16997: URL: https://github.com/apache/flink/pull/16997#discussion_r698434348 ## File path: docs/content.zh/docs/dev/table/sql/queries/window-join.md ## @@ -0,0 +1,192 @@ +--- +title: "窗口关联" +weight: 10 +type: docs +--- + + +# Windo

[GitHub] [flink] flinkbot commented on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-30 Thread GitBox
flinkbot commented on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908295316 ## CI report: * a4c9501964a166055517eeead5bdebe58cb466a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] fapaul opened a new pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-30 Thread GitBox
fapaul opened a new pull request #17052: URL: https://github.com/apache/flink/pull/17052 …ng a KafkaSource ## What is the purpose of the change Setting a groupdId for the KafkaSource is often not necessary and complicates the setup for users that do not rely on s

[jira] [Updated] (FLINK-24051) Make consumer.group-id optional for KafkaSource

2021-08-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24051: --- Labels: pull-request-available (was: ) > Make consumer.group-id optional for KafkaSource >

[GitHub] [flink] flinkbot commented on pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-30 Thread GitBox
flinkbot commented on pull request #17052: URL: https://github.com/apache/flink/pull/17052#issuecomment-908300762 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698445334 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/GlobalStreamingCommitterHandler.java ## @@ -60,27 +53,2

[jira] [Commented] (FLINK-23748) Testing window TVF session window

2021-08-30 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406706#comment-17406706 ] liwei li commented on FLINK-23748: -- HI [~xtsong] ,sorry for not replying in time. I'm m

[GitHub] [flink] flinkbot edited a comment on pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16852: URL: https://github.com/apache/flink/pull/16852#issuecomment-900037795 ## CI report: * d83b0c74521d0c0d19f62bc3fd24f303b9973157 UNKNOWN * 402208b98e644124de2f539eec8f8c2d02912692 UNKNOWN * bc728a9c34002460abe15a64d661379bb2f0

[GitHub] [flink] flinkbot edited a comment on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908295316 ## CI report: * a4c9501964a166055517eeead5bdebe58cb466a8 UNKNOWN * 7c20e7910b5f15eb88d6d2b25733c50a8c214f14 UNKNOWN Bot commands The @flinkbo

[GitHub] [flink] flinkbot commented on pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-30 Thread GitBox
flinkbot commented on pull request #17051: URL: https://github.com/apache/flink/pull/17051#issuecomment-908310738 ## CI report: * 4170c598fb3bfcf4bb9bdf08d06619cf600e3938 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-30 Thread GitBox
flinkbot commented on pull request #17052: URL: https://github.com/apache/flink/pull/17052#issuecomment-908310855 ## CI report: * 902dc5f07c38c0592dc31e78b2dcdc61fc143290 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Assigned] (FLINK-20427) Remove CheckpointConfig.setPreferCheckpointForRecovery because it can lead to data loss

2021-08-30 Thread Nicolaus Weidner (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolaus Weidner reassigned FLINK-20427: Assignee: Nicolaus Weidner > Remove CheckpointConfig.setPreferCheckpointForRecove

[jira] [Commented] (FLINK-23190) Make task-slot allocation much more evenly

2021-08-30 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406713#comment-17406713 ] Till Rohrmann commented on FLINK-23190: --- Thanks [~loyi]. I cannot promise that I'l

[GitHub] [flink] lirui-apache closed pull request #16907: [FLINK-23897][hive][doc] Fix obsolete doc about creating hive table w…

2021-08-30 Thread GitBox
lirui-apache closed pull request #16907: URL: https://github.com/apache/flink/pull/16907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Resolved] (FLINK-23897) Fix obsolete doc about creating hive table with flink dialect

2021-08-30 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li resolved FLINK-23897. Resolution: Fixed Fixed in master: 5d5565523283332414fb25f4f8765a7268c11b83 Fixed in release-1.14: d3e5553

[GitHub] [flink] Aitozi opened a new pull request #17053: [FLINK-36488942][HA]Handle curator framework start error by register fatalErrorHandler befor start zk client

2021-08-30 Thread GitBox
Aitozi opened a new pull request #17053: URL: https://github.com/apache/flink/pull/17053 ## What is the purpose of the change As described in issue , this PR is meant to fix the potential job unrecoverable due to network failure . This is done by add an unhandledErrorListener before

[GitHub] [flink] lirui-apache commented on a change in pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…

2021-08-30 Thread GitBox
lirui-apache commented on a change in pull request #16936: URL: https://github.com/apache/flink/pull/16936#discussion_r698470965 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java ## @@ -73,6 +73,

[jira] [Commented] (FLINK-24021) Potential job unrecoverable due to Network failure

2021-08-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406723#comment-17406723 ] Aitozi commented on FLINK-24021: I have create a fix [PR|https://github.com/apache/flink

[GitHub] [flink] flinkbot commented on pull request #17053: [FLINK-36488942][HA]Handle curator framework start error by register fatalErrorHandler befor start zk client

2021-08-30 Thread GitBox
flinkbot commented on pull request #17053: URL: https://github.com/apache/flink/pull/17053#issuecomment-908335697 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot edited a comment on pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #16852: URL: https://github.com/apache/flink/pull/16852#issuecomment-900037795 ## CI report: * d83b0c74521d0c0d19f62bc3fd24f303b9973157 UNKNOWN * 402208b98e644124de2f539eec8f8c2d02912692 UNKNOWN * bc728a9c34002460abe15a64d661379bb2f0

[jira] [Created] (FLINK-24055) Deprecate FlinkKafkaConsumer

2021-08-30 Thread Fabian Paul (Jira)
Fabian Paul created FLINK-24055: --- Summary: Deprecate FlinkKafkaConsumer Key: FLINK-24055 URL: https://issues.apache.org/jira/browse/FLINK-24055 Project: Flink Issue Type: Improvement

[GitHub] [flink] flinkbot edited a comment on pull request #17010: [FLINK-24003][python] Fix lookback mode doesn't work when mixing use of Python Table API and Python DataStream API

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17010: URL: https://github.com/apache/flink/pull/17010#issuecomment-906989888 ## CI report: * 269b9d8d23fd5dabbfc0a975b205fe5f0ff816bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17011: URL: https://github.com/apache/flink/pull/17011#issuecomment-907015222 ## CI report: * 211af17558902443958144ba9f202b75c719982e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 0a6ed86ec26cf3fd8a85ccb00d5b504aa31c4d9b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17048: URL: https://github.com/apache/flink/pull/17048#issuecomment-908188488 ## CI report: * 44a4c5b89d03c403df73fae28d464a557444323a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17052: URL: https://github.com/apache/flink/pull/17052#issuecomment-908310855 ## CI report: * 902dc5f07c38c0592dc31e78b2dcdc61fc143290 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908295316 ## CI report: * a4c9501964a166055517eeead5bdebe58cb466a8 UNKNOWN * 7c20e7910b5f15eb88d6d2b25733c50a8c214f14 Azure: [PENDING](https://dev.azure.com/apache-fl

[jira] [Assigned] (FLINK-24055) Deprecate FlinkKafkaConsumer

2021-08-30 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-24055: --- Assignee: Fabian Paul > Deprecate FlinkKafkaConsumer > > >

[GitHub] [flink] flinkbot edited a comment on pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-30 Thread GitBox
flinkbot edited a comment on pull request #17051: URL: https://github.com/apache/flink/pull/17051#issuecomment-908310738 ## CI report: * 4170c598fb3bfcf4bb9bdf08d06619cf600e3938 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wuchong commented on a change in pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-30 Thread GitBox
wuchong commented on a change in pull request #16723: URL: https://github.com/apache/flink/pull/16723#discussion_r698484240 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala ## @@ -808,6 +808,162 @@ class Table

[GitHub] [flink] Airblader commented on a change in pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
Airblader commented on a change in pull request #17011: URL: https://github.com/apache/flink/pull/17011#discussion_r698432369 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/PushFilterPastChangelogNormalizeRule.java

[GitHub] [flink] beyond1920 commented on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-30 Thread GitBox
beyond1920 commented on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-908345723 @wuchong Thanks for suggestion, I've updated the results of sql query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] twalthr commented on a change in pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-30 Thread GitBox
twalthr commented on a change in pull request #17011: URL: https://github.com/apache/flink/pull/17011#discussion_r698472194 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableDescriptor.java ## @@ -51,14 +51,14 @@ * TableEnvironment#

<    1   2   3   4   5   6   >