[GitHub] klion26 commented on issue #6777: [FLINK-10461] [State Backends, Checkpointing] Speed up download files when restore from DFS

2018-11-28 Thread GitBox
klion26 commented on issue #6777: [FLINK-10461] [State Backends, Checkpointing] Speed up download files when restore from DFS URL: https://github.com/apache/flink/pull/6777#issuecomment-442356732 @azagrebin thanks for your review, I've just addressed all your comments and created[ FLINK-11

[jira] [Commented] (FLINK-10461) Speed up download file procedure when restore

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701508#comment-16701508 ] ASF GitHub Bot commented on FLINK-10461: klion26 commented on issue #6777: [FLIN

[GitHub] pnowojski commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation

2018-11-28 Thread GitBox
pnowojski commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051#issuecomment-442358466 Personally I do not mind that much about separating PRs or creating separate Jira issues - but that's my persona

[GitHub] pnowojski edited a comment on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation

2018-11-28 Thread GitBox
pnowojski edited a comment on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051#issuecomment-442358466 Personally I do not mind that much about separating PRs or creating separate Jira issues - but that's my

[jira] [Commented] (FLINK-10820) Simplify the RebalancePartitioner implementation

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701511#comment-16701511 ] ASF GitHub Bot commented on FLINK-10820: pnowojski commented on issue #7051: [FL

[jira] [Commented] (FLINK-10820) Simplify the RebalancePartitioner implementation

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701513#comment-16701513 ] ASF GitHub Bot commented on FLINK-10820: pnowojski edited a comment on issue #70

[GitHub] yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread GitBox
yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442363596 cc @pnowojski This is an a

[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701531#comment-16701531 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLIN

[GitHub] wg1026688210 opened a new pull request #7185: [FLINK-10884] [yarn/mesos] adjust container memory param to set a safe margin from offheap memory

2018-11-28 Thread GitBox
wg1026688210 opened a new pull request #7185: [FLINK-10884] [yarn/mesos] adjust container memory param to set a safe margin from offheap memory URL: https://github.com/apache/flink/pull/7185 What is the purpose of the change This pull request adjust yarn container memory parameters/

[jira] [Updated] (FLINK-10884) Flink on yarn TM container will be killed by nodemanager because of the exceeded physical memory.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10884: --- Labels: pull-request-available yarn (was: yarn) > Flink on yarn TM container will be kille

[GitHub] twalthr commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread GitBox
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r236982074 ## File path: flink-connectors/flink-connector-kafka-0.11/src/test

[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701534#comment-16701534 ] ASF GitHub Bot commented on FLINK-11015: twalthr commented on a change in pull r

[jira] [Commented] (FLINK-10884) Flink on yarn TM container will be killed by nodemanager because of the exceeded physical memory.

2018-11-28 Thread ASF GitHub Bot (JIRA)

[GitHub] shaoxuan-wang commented on issue #7175: [FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in window document

2018-11-28 Thread GitBox
shaoxuan-wang commented on issue #7175: [FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in window document URL: https://github.com/apache/flink/pull/7175#issuecomment-442372337 Hi @yuanyangwu , thanks for the contribution. It is always good to rebase the master wh

[jira] [Commented] (FLINK-11004) Wrong ProcessWindowFunction.process argument in example of Incremental Window Aggregation with ReduceFunction

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701564#comment-16701564 ] ASF GitHub Bot commented on FLINK-11004: shaoxuan-wang commented on issue #7175:

[GitHub] zhijiangW commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation

2018-11-28 Thread GitBox
zhijiangW commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051#issuecomment-442372490 Yeah, thanks for above specific explanations which all make sense in my opinion. I just want to confirm whether

[jira] [Commented] (FLINK-10820) Simplify the RebalancePartitioner implementation

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701565#comment-16701565 ] ASF GitHub Bot commented on FLINK-10820: zhijiangW commented on issue #7051: [FL

[jira] [Commented] (FLINK-10884) Flink on yarn TM container will be killed by nodemanager because of the exceeded physical memory.

2018-11-28 Thread wgcn (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701574#comment-16701574 ] wgcn commented on FLINK-10884: -- https://github.com/apache/flink/pull/7185 > Flink on yarn

[jira] [Commented] (FLINK-11004) Wrong ProcessWindowFunction.process argument in example of Incremental Window Aggregation with ReduceFunction

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701580#comment-16701580 ] ASF GitHub Bot commented on FLINK-11004: asfgit closed pull request #7175: [FLIN

[GitHub] asfgit closed pull request #7175: [FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in window document

2018-11-28 Thread GitBox
asfgit closed pull request #7175: [FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in window document URL: https://github.com/apache/flink/pull/7175 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[jira] [Created] (FLINK-11016) flink chain have a bug???

2018-11-28 Thread Wong (JIRA)
Wong created FLINK-11016: Summary: flink chain have a bug??? Key: FLINK-11016 URL: https://issues.apache.org/jira/browse/FLINK-11016 Project: Flink Issue Type: Bug Components: Core Affe

[jira] [Closed] (FLINK-11004) Wrong ProcessWindowFunction.process argument in example of Incremental Window Aggregation with ReduceFunction

2018-11-28 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-11004. - Resolution: Fixed Fixed and merged into master > Wrong ProcessWindowFunction.process argument i

[GitHub] kl0u edited a comment on issue #6871: [FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins.

2018-11-28 Thread GitBox
kl0u edited a comment on issue #6871: [FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins. URL: https://github.com/apache/flink/pull/6871#issuecomment-442382181 @pnowojski and @twalthr I updated the PR to expose the state retention logic to the joins. Please review and

[GitHub] kl0u commented on issue #6871: [FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins.

2018-11-28 Thread GitBox
kl0u commented on issue #6871: [FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins. URL: https://github.com/apache/flink/pull/6871#issuecomment-442382181 @pnowojski and @twalthr I updated the PR to expose the state retention logic to the joins. Please review and let me

[jira] [Commented] (FLINK-10583) Add support for state retention to the Processing Time versioned joins.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701611#comment-16701611 ] ASF GitHub Bot commented on FLINK-10583: kl0u edited a comment on issue #6871: [

[jira] [Commented] (FLINK-10584) Add support for state retention to the Event Time versioned joins.

2018-11-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701613#comment-16701613 ] Kostas Kloudas commented on FLINK-10584: There is an open PR for this here: htt

[jira] [Updated] (FLINK-10584) Add support for state retention to the Event Time versioned joins.

2018-11-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-10584: --- Labels: pull-request-available (was: ) > Add support for state retention to the Event Time

[jira] [Updated] (FLINK-10584) Add support for state retention to the Event Time versioned joins.

2018-11-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-10584: --- Description: Open PR [here|https://github.com/apache/flink/pull/6871] (was: [Open RP|https:

[GitHub] yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread GitBox
yanghua commented on issue #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#issuecomment-442383678 @twalthr thanks for your suggestion. I have checked the list you gave. I found the builder i

[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701617#comment-16701617 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread GitBox
yanghua commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237006592 ## File path: flink-connectors/flink-connector-kafka-0.11/src/test

[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701616#comment-16701616 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on issue #7182: [FLIN

[jira] [Commented] (FLINK-10583) Add support for state retention to the Processing Time versioned joins.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701610#comment-16701610 ] ASF GitHub Bot commented on FLINK-10583: kl0u commented on issue #6871: [FLINK-1

[jira] [Updated] (FLINK-10584) Add support for state retention to the Event Time versioned joins.

2018-11-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-10584: --- Description: [Open RP|https://github.com/apache/flink/pull/6871] > Add support for state ret

[jira] [Commented] (FLINK-11003) Document of Java Lambda Expressions has a mistake

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701623#comment-16701623 ] ASF GitHub Bot commented on FLINK-11003: zentol closed pull request #7174: [FLIN

[GitHub] zentol closed pull request #7174: [FLINK-11003][docs] Fix mistake in java_lambda doc

2018-11-28 Thread GitBox
zentol closed pull request #7174: [FLINK-11003][docs] Fix mistake in java_lambda doc URL: https://github.com/apache/flink/pull/7174 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[jira] [Updated] (FLINK-2491) Checkpointing only works if all operators/tasks are still running

2018-11-28 Thread Lin Canhuang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Canhuang updated FLINK-2491: Attachment: fix_checkpoint_not_working_if_tasks_are_finished.patch > Checkpointing only works if al

[jira] [Commented] (FLINK-2491) Checkpointing only works if all operators/tasks are still running

2018-11-28 Thread Lin Canhuang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701630#comment-16701630 ] Lin Canhuang commented on FLINK-2491: - I also came across this problem when setting t

[jira] [Closed] (FLINK-11003) Document of Java Lambda Expressions has a mistake

2018-11-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11003. Resolution: Fixed Fix Version/s: 1.7.0 master: e56c58f4345ab740c6c3f3dccb471d289438

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-28 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r237004073 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/a

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-28 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r237018239 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-28 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r237017454 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-28 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r237008338 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/c

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701653#comment-16701653 ] ASF GitHub Bot commented on FLINK-8577: --- pnowojski commented on a change in pull re

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701655#comment-16701655 ] ASF GitHub Bot commented on FLINK-8577: --- pnowojski commented on a change in pull re

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701656#comment-16701656 ] ASF GitHub Bot commented on FLINK-8577: --- pnowojski commented on a change in pull re

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701654#comment-16701654 ] ASF GitHub Bot commented on FLINK-8577: --- pnowojski commented on a change in pull re

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-28 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r237008957 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] twalthr commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread GitBox
twalthr commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237019737 ## File path: flink-connectors/flink-connector-kafka-base/src/main

[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701662#comment-16701662 ] ASF GitHub Bot commented on FLINK-11015: twalthr commented on a change in pull r

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701652#comment-16701652 ] ASF GitHub Bot commented on FLINK-8577: --- pnowojski commented on a change in pull re

[GitHub] QiLuo-BD opened a new pull request #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions

2018-11-28 Thread GitBox
QiLuo-BD opened a new pull request #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions URL: https://github.com/apache/flink/pull/7186 ## What is the purpose of the change This PR fixes the issue described in [1] that slots will be prematurely released

[jira] [Updated] (FLINK-10941) Slots prematurely released which still contain unconsumed data

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10941: --- Labels: pull-request-available (was: ) > Slots prematurely released which still contain unc

[jira] [Commented] (FLINK-10941) Slots prematurely released which still contain unconsumed data

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701668#comment-16701668 ] ASF GitHub Bot commented on FLINK-10941: QiLuo-BD opened a new pull request #718

[jira] [Commented] (FLINK-10941) Slots prematurely released which still contain unconsumed data

2018-11-28 Thread Qi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701679#comment-16701679 ] Qi commented on FLINK-10941: Hi [~till.rohrmann] and [~zjwang], Before the external shuffle

[GitHub] kl0u commented on issue #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
kl0u commented on issue #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#issuecomment-442403581 @azagrebin This is an auto

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701688#comment-16701688 ] ASF GitHub Bot commented on FLINK-10963: kl0u commented on issue #7161: [FLINK-1

[jira] [Closed] (FLINK-10820) Simplify the RebalancePartitioner implementation

2018-11-28 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-10820. -- Resolution: Fixed Fix Version/s: 1.8.0 Merged as 2d511b0624 into the master. > Simplif

[GitHub] asfgit closed pull request #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation

2018-11-28 Thread GitBox
asfgit closed pull request #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] pnowojski commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation

2018-11-28 Thread GitBox
pnowojski commented on issue #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051#issuecomment-442408774 Thanks @zhijiangW for the contribution :) I have reordered commits and merged the to master. --

[jira] [Commented] (FLINK-10820) Simplify the RebalancePartitioner implementation

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701713#comment-16701713 ] ASF GitHub Bot commented on FLINK-10820: pnowojski commented on issue #7051: [FL

[jira] [Commented] (FLINK-10820) Simplify the RebalancePartitioner implementation

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701711#comment-16701711 ] ASF GitHub Bot commented on FLINK-10820: asfgit closed pull request #7051: [FLIN

[jira] [Created] (FLINK-11017) Time interval for window aggregations in SQL is wrongly translated if specified with YEAR_MONTH resolution

2018-11-28 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-11017: Summary: Time interval for window aggregations in SQL is wrongly translated if specified with YEAR_MONTH resolution Key: FLINK-11017 URL: https://issues.apache.org/jira/br

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237008022 ## File path: flink-core/src/main/java/org/apache/flink/co

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237019573 ## File path: flink-filesystems/flink-s3-fs-base/src/main/

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237019983 ## File path: flink-filesystems/flink-s3-fs-base/src/main/

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237005998 ## File path: flink-core/src/main/java/org/apache/flink/co

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237006486 ## File path: flink-core/src/main/java/org/apache/flink/co

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237021819 ## File path: flink-filesystems/flink-s3-fs-hadoop/src/mai

[GitHub] igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
igalshilman commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237028468 ## File path: flink-streaming-java/src/main/java/org/apach

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701720#comment-16701720 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701718#comment-16701718 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701724#comment-16701724 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701721#comment-16701721 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701719#comment-16701719 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701723#comment-16701723 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701722#comment-16701722 ] ASF GitHub Bot commented on FLINK-10963: igalshilman commented on a change in pu

[jira] [Commented] (FLINK-10966) Optimize the release blocking logic in BarrierBuffer

2018-11-28 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701732#comment-16701732 ] vinoyang commented on FLINK-10966: -- [~StephanEwen]  Yes, adding timeouts for blocking

[jira] [Created] (FLINK-11018) Flink ignores logback.xml

2018-11-28 Thread prathamesh (JIRA)
prathamesh created FLINK-11018: -- Summary: Flink ignores logback.xml Key: FLINK-11018 URL: https://issues.apache.org/jira/browse/FLINK-11018 Project: Flink Issue Type: Bug Components:

[jira] [Created] (FLINK-11019) Expose the queryable proxy server port in taskinfo api

2018-11-28 Thread Jiayi Liao (JIRA)
Jiayi Liao created FLINK-11019: -- Summary: Expose the queryable proxy server port in taskinfo api Key: FLINK-11019 URL: https://issues.apache.org/jira/browse/FLINK-11019 Project: Flink Issue Type

[jira] [Updated] (FLINK-11019) Expose the queryable proxy server port in taskinfo api

2018-11-28 Thread Jiayi Liao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao updated FLINK-11019: --- Affects Version/s: 1.6.2 > Expose the queryable proxy server port in taskinfo api >

[jira] [Updated] (FLINK-11019) Expose the queryable proxy server port in taskinfo api

2018-11-28 Thread Jiayi Liao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao updated FLINK-11019: --- Fix Version/s: 1.8.0 > Expose the queryable proxy server port in taskinfo api >

[jira] [Updated] (FLINK-11019) Expose the queryable proxy server port in taskinfo api

2018-11-28 Thread Jiayi Liao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao updated FLINK-11019: --- Component/s: Queryable State > Expose the queryable proxy server port in taskinfo api >

[jira] [Commented] (FLINK-10966) Optimize the release blocking logic in BarrierBuffer

2018-11-28 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701762#comment-16701762 ] Stephan Ewen commented on FLINK-10966: -- Number (2) would break the ability to have

[jira] [Commented] (FLINK-10333) Rethink ZooKeeper based stores (SubmittedJobGraph, MesosWorker, CompletedCheckpoints)

2018-11-28 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701764#comment-16701764 ] Stephan Ewen commented on FLINK-10333: -- Can we simply add the leader ID as payload

[jira] [Commented] (FLINK-10930) Refactor checkpoint directory layout

2018-11-28 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701774#comment-16701774 ] Stephan Ewen commented on FLINK-10930: -- Sorry, the first part was a typo on my side

[jira] [Commented] (FLINK-10966) Optimize the release blocking logic in BarrierBuffer

2018-11-28 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701779#comment-16701779 ] vinoyang commented on FLINK-10966: -- [~StephanEwen]  You are right, the second option, i

[jira] [Commented] (FLINK-10333) Rethink ZooKeeper based stores (SubmittedJobGraph, MesosWorker, CompletedCheckpoints)

2018-11-28 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701780#comment-16701780 ] Stephan Ewen commented on FLINK-10333: -- Forwarding a discussion with the curator fo

[GitHub] yanghua commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread GitBox
yanghua commented on a change in pull request #7182: [FLINK-11015] Remove deprecated methods and classes about table from all the Kafka connectors URL: https://github.com/apache/flink/pull/7182#discussion_r237055489 ## File path: flink-connectors/flink-connector-kafka-base/src/main

[jira] [Commented] (FLINK-10993) Bring bloomfilter as a public API

2018-11-28 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701783#comment-16701783 ] vinoyang commented on FLINK-10993: -- [~StephanEwen] In my opinion, the PR of FLINK-8601

[GitHub] shuiqiangchen commented on issue #7121: [FLINK-9555]Support table api in scala shell

2018-11-28 Thread GitBox
shuiqiangchen commented on issue #7121: [FLINK-9555]Support table api in scala shell URL: https://github.com/apache/flink/pull/7121#issuecomment-442425068 Hi All, Thank you for your attention! I have pushed new codes according to your suggestions. Looking forward to your guidance. ---

[jira] [Commented] (FLINK-9555) Support table api in scala shell

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701788#comment-16701788 ] ASF GitHub Bot commented on FLINK-9555: --- shuiqiangchen commented on issue #7121: [F

[jira] [Commented] (FLINK-11015) Remove deprecated methods and classes about table from all the Kafka connectors

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701784#comment-16701784 ] ASF GitHub Bot commented on FLINK-11015: yanghua commented on a change in pull r

[GitHub] kl0u commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
kl0u commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237059956 ## File path: flink-core/src/main/java/org/apache/flink/core/fs/Re

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701801#comment-16701801 ] ASF GitHub Bot commented on FLINK-10963: kl0u commented on a change in pull requ

[GitHub] kl0u commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
kl0u commented on a change in pull request #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#discussion_r237062852 ## File path: flink-filesystems/flink-s3-fs-base/src/main/java/org

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701817#comment-16701817 ] ASF GitHub Bot commented on FLINK-10963: kl0u commented on a change in pull requ

[jira] [Commented] (FLINK-10333) Rethink ZooKeeper based stores (SubmittedJobGraph, MesosWorker, CompletedCheckpoints)

2018-11-28 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701821#comment-16701821 ] Xiaogang Shi commented on FLINK-10333: -- hi [~StephanEwen], I think the key point to

[GitHub] kl0u commented on issue #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files.

2018-11-28 Thread GitBox
kl0u commented on issue #7161: [FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of in-progress files. URL: https://github.com/apache/flink/pull/7161#issuecomment-442437127 Thanks for the comments @igalshilman . I integrated most of them and answered to the rest. L

[jira] [Commented] (FLINK-10963) Cleanup small objects uploaded to S3 as independent objects

2018-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701840#comment-16701840 ] ASF GitHub Bot commented on FLINK-10963: kl0u commented on issue #7161: [FLINK-1

  1   2   3   >