igalshilman commented on a change in pull request #7161: 
[FLINK-10963][fs-connector, s3] Cleanup tmp S3 objects uploaded as backups of 
in-progress files.
URL: https://github.com/apache/flink/pull/7161#discussion_r237005998
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/core/fs/RecoverableWriter.java
 ##########
 @@ -121,6 +121,32 @@
         */
        RecoverableFsDataOutputStream recover(ResumeRecoverable resumable) 
throws IOException;
 
+       /**
+        * Marks if the writer requires to do any additional cleanup/freeing of 
resources occupied
+        * as part of a {@link ResumeRecoverable}, e.g. temporarily files 
created or objects uploaded
+        * to external systems.
+        *
+        * <p>In case cleanup is required, then {@link 
#cleanupRecoverableState(ResumeRecoverable)} should
+        * be called.
+        *
+        * @return {@code true} if cleanup is required, {@code false} otherwise.
+        */
+       boolean requiresCleanupOfRecoverableState();
+
+       /**
+        * Frees up any resources that were were previously occupied in order 
to be able to
 
 Review comment:
   typo: were were -> were

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to