[jira] [Commented] (FLINK-6575) Disable all tests on Windows that use HDFS

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069609#comment-16069609 ] ASF GitHub Bot commented on FLINK-6575: --- Github user tzulitai commented on the issue

[jira] [Commented] (FLINK-6575) Disable all tests on Windows that use HDFS

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069610#comment-16069610 ] ASF GitHub Bot commented on FLINK-6575: --- Github user tzulitai commented on the issue

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069611#comment-16069611 ] mingleizhang commented on FLINK-7047: - Chesnay Schepler is great. Actually, I did not

[GitHub] flink issue #3776: [FLINK-6376]when deploy flink cluster on the yarn, it is ...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3776 @Rucongzhang ok, understood. I agree that in general the current `AbstractYarnClusterDescriptor` has poor separation of concerns, as is a bit hard to write contained tests. We should remember to add

[jira] [Commented] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069621#comment-16069621 ] ASF GitHub Bot commented on FLINK-6376: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3776: [FLINK-6376]when deploy flink cluster on the yarn, it is ...

2017-06-30 Thread Rucongzhang
Github user Rucongzhang commented on the issue: https://github.com/apache/flink/pull/3776 @tzulitai ,ok,Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069627#comment-16069627 ] ASF GitHub Bot commented on FLINK-6376: --- Github user Rucongzhang commented on the is

[GitHub] flink issue #3891: [FLINK-6575] Disable tests on Windows that use HDFS

2017-06-30 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3891 I ran the tests repeatedly and analyzed why they failed. For these i determined the cause to be hdfs. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[jira] [Commented] (FLINK-6575) Disable all tests on Windows that use HDFS

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069628#comment-16069628 ] ASF GitHub Bot commented on FLINK-6575: --- Github user zentol commented on the issue:

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaming Examples

2017-06-30 Thread ch33hau
Github user ch33hau commented on the issue: https://github.com/apache/flink/pull/2761 @fhueske Sorry for the problems you have raised, I can see the painful now, I will avoid the same mistake. Thanks for your time I really appreciate it. --- If your project is set up for it, you

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069632#comment-16069632 ] ASF GitHub Bot commented on FLINK-3551: --- Github user ch33hau commented on the issue:

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-06-30 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r124977924 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer010.java --- @@ -128,6 +13

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069634#comment-16069634 ] ASF GitHub Bot commented on FLINK-6352: --- Github user zjureel commented on a diff in

[GitHub] flink issue #4206: [FLINK-6996] FlinkKafkaProducer010 doesn't guarantee at-l...

2017-06-30 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4206 Hmm, this is disturbing. Locally it works for me always. I have rewritten test so that it should be less prone to intermittent failures (longer reading from Kafka timeout). Hopefully that will solv

[jira] [Commented] (FLINK-6996) FlinkKafkaProducer010 doesn't guarantee at-least-once semantic

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069657#comment-16069657 ] ASF GitHub Bot commented on FLINK-6996: --- Github user pnowojski commented on the issu

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069667#comment-16069667 ] Till Rohrmann commented on FLINK-7047: -- I like the idea. +1 for the changes. This cou

[jira] [Commented] (FLINK-4022) Partition discovery / regex topic subscription for the Kafka consumer

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069669#comment-16069669 ] ASF GitHub Bot commented on FLINK-4022: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3746: [FLINK-4022] [kafka] Partition and topic discovery for Fl...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3746 (please ignore the batch of commits. I'm just using this branch for an overall Travis run before committing the batch; personal accounts get time-outs too constantly) --- If your project is set up

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaming Examples

2017-06-30 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2761 No worries :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069671#comment-16069671 ] ASF GitHub Bot commented on FLINK-3551: --- Github user fhueske commented on the issue:

[jira] [Comment Edited] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069688#comment-16069688 ] Chesnay Schepler edited comment on FLINK-7047 at 6/30/17 8:23 AM: --

[jira] [Commented] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069688#comment-16069688 ] Chesnay Schepler commented on FLINK-7047: - WIth a split repo we could make the tes

[jira] [Comment Edited] (FLINK-7047) Reorganize build profiles

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069688#comment-16069688 ] Chesnay Schepler edited comment on FLINK-7047 at 6/30/17 8:23 AM: --

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124988636 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java --- @@ -1900,7 +1900,7 @@ public void unparse(

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069696#comment-16069696 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124990474 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class RelTimeIn

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069707#comment-16069707 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124990940 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class RelTimeIn

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069711#comment-16069711 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r124991860 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@ cla

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069718#comment-16069718 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #3984: [FLINK-6710] Remove Twitter-InputFormat

2017-06-30 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/3984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069756#comment-16069756 ] ASF GitHub Bot commented on FLINK-6710: --- Github user zentol closed the pull request

[jira] [Closed] (FLINK-6710) Remove twitter-inputformat

2017-06-30 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6710. --- Resolution: Fixed 1.4: d7d10a130bf7a1856e5ab17ac354f3f2fc4d2f55 > Remove twitter-inputformat

[GitHub] flink pull request #4231: [FLINK-6695] Activate strict checkstyle for flink-...

2017-06-30 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4231 [FLINK-6695] Activate strict checkstyle for flink-contrib This PR moves the checkstyle plugin declaration into the flink-contrib pom. You can merge this pull request into a Git repository by running:

[jira] [Commented] (FLINK-6695) Activate strict checkstyle in flink-contrib

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069760#comment-16069760 ] ASF GitHub Bot commented on FLINK-6695: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #4232: [FLINK-7041] Deserialize StateBackend from JobChec...

2017-06-30 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4232 [FLINK-7041] Deserialize StateBackend from JobCheckpointingSettings with user classloader R: @tzulitai CC: @StephanEwen I noticed that the state backend that is in the configuration is n

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069762#comment-16069762 ] ASF GitHub Bot commented on FLINK-7041: --- GitHub user aljoscha opened a pull request:

[jira] [Created] (FLINK-7050) RFC Compliant CSV Parser for Table Source

2017-06-30 Thread Usman Younas (JIRA)
Usman Younas created FLINK-7050: --- Summary: RFC Compliant CSV Parser for Table Source Key: FLINK-7050 URL: https://issues.apache.org/jira/browse/FLINK-7050 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125000171 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -267,6 +293,177 @@ public void shutDown() { }

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124999617 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -534,33 +537,66 @@ public Integer getKey(Tuple2 va

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124998338 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -157,10 +168,16 @@ public QueryableStateClient(

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124998957 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespaceTypeInfo.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apach

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r124999382 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -234,38 +239,28 @@ public Integer getKey(Tuple2 va

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069779#comment-16069779 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069783#comment-16069783 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069782#comment-16069782 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069781#comment-16069781 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069780#comment-16069780 ] ASF GitHub Bot commented on FLINK-7044: --- Github user aljoscha commented on a diff in

[GitHub] flink issue #4232: [FLINK-7041] Deserialize StateBackend from JobCheckpointi...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4232 Thanks for the quick fix @aljoscha! Regarding tests: Can we also have another test that verifies `JobGraphs` containing custom `StateBackend`s or `StateBackends` with custom classes can

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069793#comment-16069793 ] ASF GitHub Bot commented on FLINK-7041: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125002758 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -349,6 +350,14 @@ class RelTimeIn

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069797#comment-16069797 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125003073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@ cla

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069799#comment-16069799 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125003218 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlGroupFunction.java --- @@ -50,7 +50,8 @@ * GROUP BY HOP(rowtime, INT

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069801#comment-16069801 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink issue #4232: [FLINK-7041] Deserialize StateBackend from JobCheckpointi...

2017-06-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4232 Ah scratch that, perhaps the `CheckpointSettingsSerializableTest` is sufficient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069803#comment-16069803 ] ASF GitHub Bot commented on FLINK-7041: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #4199: [FLINK-6584] [table] Support multiple consecutive ...

2017-06-30 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4199#discussion_r125004836 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowStartEndPropertiesRule.scala --- @@ -54,34 +56,75 @@ cla

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069817#comment-16069817 ] ASF GitHub Bot commented on FLINK-6584: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #4232: [FLINK-7041] Deserialize StateBackend from JobChec...

2017-06-30 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4232#discussion_r125004426 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java --- @@ -223,19 +223,21 @@ public static ExecutionG

[jira] [Commented] (FLINK-7041) Deserialize StateBackend from JobCheckpointingSettings with user classloader

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069822#comment-16069822 ] ASF GitHub Bot commented on FLINK-7041: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125006417 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespaceTypeInfo.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache So

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125006493 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -267,6 +293,177 @@ public void shutDown() { }

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069827#comment-16069827 ] ASF GitHub Bot commented on FLINK-7044: --- Github user kl0u commented on a diff in the

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069829#comment-16069829 ] ASF GitHub Bot commented on FLINK-7044: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125007122 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -234,38 +239,28 @@ public Integer getKey(Tuple2 value)

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069832#comment-16069832 ] ASF GitHub Bot commented on FLINK-7044: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125007394 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -534,33 +537,66 @@ public Integer getKey(Tuple2 value)

[jira] [Commented] (FLINK-7044) Add methods to the client API that take the stateDescriptor.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069834#comment-16069834 ] ASF GitHub Bot commented on FLINK-7044: --- Github user kl0u commented on a diff in the

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-06-30 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai Thank you for your suggestion. I think move the conversion between date and offset to `KafkaConsumerThread` is really a good idea. I have fixed the NPE in test case, and move the conversion

[jira] [Commented] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069846#comment-16069846 ] ASF GitHub Bot commented on FLINK-6352: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream

2017-06-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4229 Hi, @tzulitai I have updated the code. Please check whether it should add more ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125005837 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java --- @@ -153,9 +153,8 @@ public int hashCode() {

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125005984 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -455,6 +548,76 @@ private void addStopStateToLo

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125012573 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java --- @@ -0,0 +1,807 @@ +/* + * Licensed to the Apache So

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125005892 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/TimesRangeITCase.java --- @@ -92,6 +92,57 @@ public boolean filter(Event value)

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125010592 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java --- @@ -0,0 +1,807 @@ +/* + * Licensed to the Apache So

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125005277 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java --- @@ -430,6 +431,54 @@ public Quantifier getQuantifier() {

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069904#comment-16069904 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069909#comment-16069909 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069906#comment-16069906 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069899#comment-16069899 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069903#comment-16069903 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069901#comment-16069901 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069907#comment-16069907 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-7038) Several misused "KeyedDataStream" term in docs and Javadocs

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069896#comment-16069896 ] ASF GitHub Bot commented on FLINK-7038: --- Github user zhangminglei commented on the i

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069905#comment-16069905 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069898#comment-16069898 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069897#comment-16069897 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r124999092 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -455,6 +548,76 @@ private void addStopStateToLo

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069908#comment-16069908 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r124994181 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFAStateNameHandler.java --- @@ -55,6 +55,11 @@ public void checkNameUn

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125009258 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java --- @@ -0,0 +1,807 @@ +/* + * Licensed to the Apache So

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125005796 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java --- @@ -366,8 +366,9 @@ public Quantifier getQuantifier() {

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125012236 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java --- @@ -0,0 +1,807 @@ +/* + * Licensed to the Apache So

[GitHub] flink pull request #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-30 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4153#discussion_r125009695 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GroupITCase.java --- @@ -0,0 +1,807 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069900#comment-16069900 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6927) Support pattern group in CEP

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069902#comment-16069902 ] ASF GitHub Bot commented on FLINK-6927: --- Github user dawidwys commented on a diff in

  1   2   3   >